Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
v8-dev
Home
+ new post
About this group
Join this group
Don't leak inobject space when transforming to fast properties without descriptors. (issue 10828112)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
verwa...@chromium.org  
View profile  
 More options Aug 1 2012, 6:43 am
From: verwa...@chromium.org
Date: Wed, 01 Aug 2012 10:43:51 +0000
Local: Wed, Aug 1 2012 6:43 am
Subject: Don't leak inobject space when transforming to fast properties without descriptors. (issue 10828112)
Print | Individual message | Show original | Report this message | Find messages by this author
Reviewers: Yang,

Message:
PTAL.

Description:
Don't leak inobject space when transforming to fast properties without
descriptors.

Please review this at https://chromiumcodereview.appspot.com/10828112/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
   M src/objects.cc

Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index  
b092d8d67c6d0b62a48dc04abb1a0132e109bafd..6dbc41ea9c18d8a3cc852408ebf228460 03c256d  
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -12577,7 +12577,7 @@ MaybeObject*  
StringDictionary::TransformPropertiesToFastFor(
    if (instance_descriptor_length == 0) {
      ASSERT_LE(unused_property_fields, inobject_props);
      // Transform the object.
-    new_map->set_unused_property_fields(unused_property_fields);
+    new_map->set_unused_property_fields(inobject_props);
      obj->set_map(new_map);
      obj->set_properties(heap->empty_fixed_array());
      // Check that it really works.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
yang...@chromium.org  
View profile  
 More options Aug 1 2012, 6:49 am
From: yang...@chromium.org
Date: Wed, 01 Aug 2012 10:49:58 +0000
Local: Wed, Aug 1 2012 6:49 am
Subject: Re: Don't leak inobject space when transforming to fast properties without descriptors. (issue 10828112)
Print | Individual message | Show original | Report this message | Find messages by this author
On 2012/08/01 10:43:51, Toon Verwaest wrote:

> PTAL.

LGTM.

https://chromiumcodereview.appspot.com/10828112/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google