Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
r12732 committed - Merged r12731 into trunk branch....
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  1 message - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
codesite-nore...@google.com  
View profile  
 More options Oct 15 2012, 8:40 am
From: codesite-nore...@google.com
Date: Mon, 15 Oct 2012 12:40:52 +0000
Local: Mon, Oct 15 2012 8:40 am
Subject: [v8] r12732 committed - Merged r12731 into trunk branch....
Revision: 12732
Author:   svenpa...@chromium.org
Date:     Mon Oct 15 05:39:45 2012
Log:      Merged r12731 into trunk branch.

Fixed VERIFY_HEAP without DEBUG.

R=jkumme...@chromium.org

Review URL: https://codereview.chromium.org/11140023
http://code.google.com/p/v8/source/detail?r=12732

Modified:
  /trunk/src/profile-generator.cc
  /trunk/src/version.cc

=======================================
--- /trunk/src/profile-generator.cc     Mon Oct 15 04:51:39 2012
+++ /trunk/src/profile-generator.cc     Mon Oct 15 05:39:45 2012
@@ -3094,13 +3094,13 @@
        Heap::kMakeHeapIterableMask,
        "HeapSnapshotGenerator::GenerateSnapshot");

-#ifdef DEBUG
+#ifdef VERIFY_HEAP
    Heap* debug_heap = Isolate::Current()->heap();
-  ASSERT(!debug_heap->old_data_space()->was_swept_conservatively());
-  ASSERT(!debug_heap->old_pointer_space()->was_swept_conservatively());
-  ASSERT(!debug_heap->code_space()->was_swept_conservatively());
-  ASSERT(!debug_heap->cell_space()->was_swept_conservatively());
-  ASSERT(!debug_heap->map_space()->was_swept_conservatively());
+  CHECK(!debug_heap->old_data_space()->was_swept_conservatively());
+  CHECK(!debug_heap->old_pointer_space()->was_swept_conservatively());
+  CHECK(!debug_heap->code_space()->was_swept_conservatively());
+  CHECK(!debug_heap->cell_space()->was_swept_conservatively());
+  CHECK(!debug_heap->map_space()->was_swept_conservatively());
  #endif

    // The following code uses heap iterators, so we want the heap to be
=======================================
--- /trunk/src/version.cc       Mon Oct 15 04:51:39 2012
+++ /trunk/src/version.cc       Mon Oct 15 05:39:45 2012
@@ -35,7 +35,7 @@
  #define MAJOR_VERSION     3
  #define MINOR_VERSION     14
  #define BUILD_NUMBER      4
-#define PATCH_LEVEL       0
+#define PATCH_LEVEL       1
  // Use 1 for candidates and 0 otherwise.
  // (Boolean macro values are not supported by all preprocessors.)
  #define IS_CANDIDATE_VERSION 0


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »