Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Fix test failures in r12813. (issue 11264035)
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
yang...@chromium.org  
View profile  
 More options Oct 25 2012, 9:51 am
From: yang...@chromium.org
Date: Thu, 25 Oct 2012 13:51:40 +0000
Local: Thurs, Oct 25 2012 9:51 am
Subject: Fix test failures in r12813. (issue 11264035)
 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
mstarzin...@chromium.org  
View profile  
 More options Oct 25 2012, 9:51 am
From: mstarzin...@chromium.org
Date: Thu, 25 Oct 2012 13:51:39 +0000
Local: Thurs, Oct 25 2012 9:51 am
Subject: Fix test failures in r12813. (issue 11264035)
Reviewers: Yang,

Description:
Fix test failures in r12813.

R=yang...@chromium.org
BUG=v8:1490

Please review this at https://codereview.chromium.org/11264035/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
   M src/objects-inl.h

Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index  
08358cb2939280c51d6c48fb20cf7296affeed9e..4e7d8f8c08702943ef60fb3692b5ceb56 482ec5d  
100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -2290,9 +2290,10 @@ int HashTable<Shape, Key>::FindEntry(Isolate*  
isolate, Key key) {
    // EnsureCapacity will guarantee the hash table is never full.
    while (true) {
      Object* element = KeyAt(entry);
-    // Empty entry.
-    if (element == isolate->heap()->undefined_value()) break;
-    if (element != isolate->heap()->the_hole_value() &&
+    // Empty entry. Uses raw unchecked accessors because it is called by  
the
+    // symbol table during bootstrapping.
+    if (element == isolate->heap()->raw_unchecked_undefined_value()) break;
+    if (element != isolate->heap()->raw_unchecked_the_hole_value() &&
          Shape::IsMatch(key, element)) return entry;
      entry = NextProbe(entry, count++, capacity);
    }


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »