Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Remove one-line helper used in two places. (issue 8387067)
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
fschnei...@chromium.org  
View profile  
 More options Nov 1 2011, 8:10 am
From: fschnei...@chromium.org
Date: Tue, 01 Nov 2011 12:10:58 +0000
Local: Tues, Nov 1 2011 8:10 am
Subject: Remove one-line helper used in two places. (issue 8387067)
Reviewers: William Hesse,

Description:
Remove one-line helper used in two places.

Please review this at http://codereview.chromium.org/8387067/

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
   M     src/arm/full-codegen-arm.cc
   M     src/ia32/full-codegen-ia32.cc
   M     src/mips/full-codegen-mips.cc
   M     src/x64/full-codegen-x64.cc

Index: src/arm/full-codegen-arm.cc
===================================================================
--- src/arm/full-codegen-arm.cc (revision 9855)
+++ src/arm/full-codegen-arm.cc (working copy)
@@ -47,11 +47,6 @@
  #define __ ACCESS_MASM(masm_)

-static unsigned GetPropertyId(Property* property) {
-  return property->id();
-}
-
-
  // A patch site is a location in the code which it is possible to patch.  
This
  // class has a number of methods to emit the code which is patchable and  
the
  // method EmitPatchInfo to record a marker back to the patchable code. This
@@ -1734,7 +1729,7 @@
    __ mov(r2, Operand(key->handle()));
    // Call load IC. It has arguments receiver and property name r0 and r2.
    Handle<Code> ic = isolate()->builtins()->LoadIC_Initialize();
-  __ Call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ Call(ic, RelocInfo::CODE_TARGET, prop->id());
  }

@@ -1742,7 +1737,7 @@
    SetSourcePosition(prop->position());
    // Call keyed load IC. It has arguments key and receiver in r0 and r1.
    Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize();
-  __ Call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ Call(ic, RelocInfo::CODE_TARGET, prop->id());
  }

Index: src/ia32/full-codegen-ia32.cc
===================================================================
--- src/ia32/full-codegen-ia32.cc       (revision 9855)
+++ src/ia32/full-codegen-ia32.cc       (working copy)
@@ -44,11 +44,6 @@
  #define __ ACCESS_MASM(masm_)

-static unsigned GetPropertyId(Property* property) {
-  return property->id();
-}
-
-
  class JumpPatchSite BASE_EMBEDDED {
   public:
    explicit JumpPatchSite(MacroAssembler* masm) : masm_(masm) {
@@ -1680,14 +1675,14 @@
    ASSERT(!key->handle()->IsSmi());
    __ mov(ecx, Immediate(key->handle()));
    Handle<Code> ic = isolate()->builtins()->LoadIC_Initialize();
-  __ call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ call(ic, RelocInfo::CODE_TARGET, prop->id());
  }

  void FullCodeGenerator::EmitKeyedPropertyLoad(Property* prop) {
    SetSourcePosition(prop->position());
    Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize();
-  __ call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ call(ic, RelocInfo::CODE_TARGET, prop->id());
  }

Index: src/mips/full-codegen-mips.cc
===================================================================
--- src/mips/full-codegen-mips.cc       (revision 9855)
+++ src/mips/full-codegen-mips.cc       (working copy)
@@ -55,11 +55,6 @@
  #define __ ACCESS_MASM(masm_)

-static unsigned GetPropertyId(Property* property) {
-  return property->id();
-}
-
-
  // A patch site is a location in the code which it is possible to patch.  
This
  // class has a number of methods to emit the code which is patchable and  
the
  // method EmitPatchInfo to record a marker back to the patchable code. This
@@ -1748,7 +1743,7 @@
    __ li(a2, Operand(key->handle()));
    // Call load IC. It has arguments receiver and property name a0 and a2.
    Handle<Code> ic = isolate()->builtins()->LoadIC_Initialize();
-  __ Call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ Call(ic, RelocInfo::CODE_TARGET, prop->id());
  }

@@ -1757,7 +1752,7 @@
    __ mov(a0, result_register());
    // Call keyed load IC. It has arguments key and receiver in a0 and a1.
    Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize();
-  __ Call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ Call(ic, RelocInfo::CODE_TARGET, prop->id());
  }

Index: src/x64/full-codegen-x64.cc
===================================================================
--- src/x64/full-codegen-x64.cc (revision 9855)
+++ src/x64/full-codegen-x64.cc (working copy)
@@ -44,11 +44,6 @@
  #define __ ACCESS_MASM(masm_)

-static unsigned GetPropertyId(Property* property) {
-  return property->id();
-}
-
-
  class JumpPatchSite BASE_EMBEDDED {
   public:
    explicit JumpPatchSite(MacroAssembler* masm) : masm_(masm) {
@@ -1688,14 +1683,14 @@
    Literal* key = prop->key()->AsLiteral();
    __ Move(rcx, key->handle());
    Handle<Code> ic = isolate()->builtins()->LoadIC_Initialize();
-  __ call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ call(ic, RelocInfo::CODE_TARGET, prop->id());
  }

  void FullCodeGenerator::EmitKeyedPropertyLoad(Property* prop) {
    SetSourcePosition(prop->position());
    Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize();
-  __ call(ic, RelocInfo::CODE_TARGET, GetPropertyId(prop));
+  __ call(ic, RelocInfo::CODE_TARGET, prop->id());
  }


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
whe...@chromium.org  
View profile  
 More options Nov 1 2011, 8:19 am
From: whe...@chromium.org
Date: Tue, 01 Nov 2011 12:19:28 +0000
Local: Tues, Nov 1 2011 8:19 am
Subject: Re: Remove one-line helper used in two places. (issue 8387067)
 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »