Fix performance regression introduced by r12812. (issue 11301014)

9 views
Skip to first unread message

ul...@chromium.org

unread,
Oct 29, 2012, 7:04:16 AM10/29/12
to yan...@chromium.org, da...@chromium.org, v8-...@googlegroups.com
Reviewers: Yang, danno,

Message:
PTAL

Description:
Fix performance regression introduced by r12812.

R=yan...@chromium.org


Please review this at https://chromiumcodereview.appspot.com/11301014/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M src/regexp-stack.cc


Index: src/regexp-stack.cc
diff --git a/src/regexp-stack.cc b/src/regexp-stack.cc
index
fda7253edcee150a6cac9668e0f9db726bd135ce..325a1496c98c9a26d05c9fffc1c97be132e401f0
100644
--- a/src/regexp-stack.cc
+++ b/src/regexp-stack.cc
@@ -51,6 +51,7 @@ RegExpStack::RegExpStack()


RegExpStack::~RegExpStack() {
+ thread_local_.Free();
}


@@ -72,7 +73,7 @@ char* RegExpStack::RestoreStack(char* from) {


void RegExpStack::Reset() {
- if (thread_local_.memory_size_ >= kMinimumStackSize) {
+ if (thread_local_.memory_size_ > kMinimumStackSize) {
DeleteArray(thread_local_.memory_);
thread_local_ = ThreadLocal();
}


yan...@chromium.org

unread,
Oct 29, 2012, 7:44:33 AM10/29/12
to ul...@chromium.org, da...@chromium.org, v8-...@googlegroups.com
On 2012/10/29 11:04:16, ulan wrote:
> PTAL

LGTM.

http://codereview.chromium.org/11301014/
Reply all
Reply to author
Forward
0 new messages