Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Merge fix for incorrect overlap check in mark compact collector to 3.4 branch. (issue7471036)
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
a...@chromium.org  
View profile  
 More options Jul 21 2011, 7:34 am
From: a...@chromium.org
Date: Thu, 21 Jul 2011 11:34:40 +0000
Local: Thurs, Jul 21 2011 7:34 am
Subject: Merge fix for incorrect overlap check in mark compact collector to 3.4 branch. (issue7471036)
Reviewers: fschneider,

Description:
Merge fix for incorrect overlap check in mark compact collector to 3.4  
branch.

Bleeding edge revision 8704.

Please review this at http://codereview.chromium.org/7471036/

SVN Base: http://v8.googlecode.com/svn/branches/3.4/

Affected files:
   M     src/heap-inl.h
   M     src/version.cc

Index: src/heap-inl.h
===================================================================
--- src/heap-inl.h      (revision 8706)
+++ src/heap-inl.h      (working copy)
@@ -368,11 +368,7 @@

    int size_in_words = byte_size / kPointerSize;

-  if ((dst < src) || (dst >= (src + size_in_words))) {
-    ASSERT((dst >= (src + size_in_words)) ||
-           ((OffsetFrom(reinterpret_cast<Address>(src)) -
-             OffsetFrom(reinterpret_cast<Address>(dst))) >= kPointerSize));
-
+  if ((dst < src) || (dst >= (src + byte_size))) {
      Object** src_slot = reinterpret_cast<Object**>(src);
      Object** dst_slot = reinterpret_cast<Object**>(dst);
      Object** end_slot = src_slot + size_in_words;
@@ -390,8 +386,7 @@
                                                     Address src,
                                                     int byte_size) {
    ASSERT(IsAligned(byte_size, kPointerSize));
-  ASSERT((dst >= (src + byte_size)) ||
-         ((OffsetFrom(src) - OffsetFrom(dst)) >= kPointerSize));
+  ASSERT((dst < src) || (dst >= (src + byte_size)));

    CopyBlockToOldSpaceAndUpdateRegionMarks(dst, src, byte_size);
  }
Index: src/version.cc
===================================================================
--- src/version.cc      (revision 8706)
+++ src/version.cc      (working copy)
@@ -35,7 +35,7 @@
  #define MAJOR_VERSION     3
  #define MINOR_VERSION     4
  #define BUILD_NUMBER      14
-#define PATCH_LEVEL       0
+#define PATCH_LEVEL       1
  // Use 1 for candidates and 0 otherwise.
  // (Boolean macro values are not supported by all preprocessors.)
  #define IS_CANDIDATE_VERSION 0


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
fschnei...@chromium.org  
View profile  
 More options Jul 21 2011, 8:17 am
From: fschnei...@chromium.org
Date: Thu, 21 Jul 2011 12:17:58 +0000
Local: Thurs, Jul 21 2011 8:17 am
Subject: Re: Merge fix for incorrect overlap check in mark compact collector to 3.4 branch. (issue7471036)
 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »