Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
v8-dev
Home
+ new post
About this group
Join this group
Ensure that we do not accidentally emit debug code. (issue 11108011)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
mstarzin...@chromium.org  
View profile  
 More options Oct 12 2012, 7:00 am
From: mstarzin...@chromium.org
Date: Fri, 12 Oct 2012 11:00:22 +0000
Local: Fri, Oct 12 2012 7:00 am
Subject: Ensure that we do not accidentally emit debug code. (issue 11108011)
Print | Individual message | Show original | Report this message | Find messages by this author
LGTM (with a few nits).

https://codereview.chromium.org/11108011/diff/1/src/arm/lithium-codeg...
File src/arm/lithium-codegen-arm.cc (right):

https://codereview.chromium.org/11108011/diff/1/src/arm/lithium-codeg...
src/arm/lithium-codegen-arm.cc:4277: __ AssertSmi(r0);
Indentation is off.

https://codereview.chromium.org/11108011/diff/1/src/x64/code-stubs-x6...
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/11108011/diff/1/src/x64/code-stubs-x6...
src/x64/code-stubs-x64.cc:1300: __ AssertRootValue(heap_number_map,
Indentation is off.

https://codereview.chromium.org/11108011/diff/1/src/x64/lithium-codeg...
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/11108011/diff/1/src/x64/lithium-codeg...
src/x64/lithium-codegen-x64.cc:4207: __ AssertSmi(input);
Indentation is off.

https://codereview.chromium.org/11108011/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
svenpa...@chromium.org  
View profile  
 More options Oct 12 2012, 7:05 am
From: svenpa...@chromium.org
Date: Fri, 12 Oct 2012 11:05:36 +0000
Local: Fri, Oct 12 2012 7:05 am
Subject: Re: Ensure that we do not accidentally emit debug code. (issue 11108011)
Print | Individual message | Show original | Report this message | Find messages by this author
Reviewers: Michael Starzinger,

Message:
Fixed nits, landing...

https://codereview.chromium.org/11108011/diff/1/src/arm/lithium-codeg...
File src/arm/lithium-codegen-arm.cc (right):

https://codereview.chromium.org/11108011/diff/1/src/arm/lithium-codeg...
src/arm/lithium-codegen-arm.cc:4277: __ AssertSmi(r0);
On 2012/10/12 11:00:22, Michael Starzinger wrote:

> Indentation is off.

Done.

https://codereview.chromium.org/11108011/diff/1/src/x64/code-stubs-x6...
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/11108011/diff/1/src/x64/code-stubs-x6...
src/x64/code-stubs-x64.cc:1300: __ AssertRootValue(heap_number_map,
On 2012/10/12 11:00:22, Michael Starzinger wrote:

> Indentation is off.

Done.

https://codereview.chromium.org/11108011/diff/1/src/x64/lithium-codeg...
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/11108011/diff/1/src/x64/lithium-codeg...
src/x64/lithium-codegen-x64.cc:4207: __ AssertSmi(input);
On 2012/10/12 11:00:22, Michael Starzinger wrote:

> Indentation is off.

Done.

Description:
Ensure that we do not accidentally emit debug code.

The call sites are more concise, the naming is better and at least one
case of superfluous code in release mode was removed.

R=mstarzin...@chromium.org

Please review this at https://codereview.chromium.org/11108011/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
   M src/arm/code-stubs-arm.cc
   M src/arm/full-codegen-arm.cc
   M src/arm/lithium-codegen-arm.cc
   M src/arm/macro-assembler-arm.h
   M src/arm/macro-assembler-arm.cc
   M src/ia32/code-stubs-ia32.cc
   M src/ia32/full-codegen-ia32.cc
   M src/ia32/lithium-codegen-ia32.cc
   M src/ia32/macro-assembler-ia32.h
   M src/ia32/macro-assembler-ia32.cc
   M src/mips/code-stubs-mips.cc
   M src/mips/full-codegen-mips.cc
   M src/mips/lithium-codegen-mips.cc
   M src/mips/macro-assembler-mips.h
   M src/mips/macro-assembler-mips.cc
   M src/x64/code-stubs-x64.cc
   M src/x64/full-codegen-x64.cc
   M src/x64/lithium-codegen-x64.cc
   M src/x64/macro-assembler-x64.h
   M src/x64/macro-assembler-x64.cc


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google