Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
v8-dev
Home
+ new post
About this group
Join this group
Start migrating profiles processing to C++. (issue910002)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   4 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
fin...@chromium.org  
View profile  
 More options Mar 25 2011, 11:18 am
From: fin...@chromium.org
Date: Fri, 25 Mar 2011 15:18:48 +0000
Local: Fri, Mar 25 2011 11:18 am
Subject: Re: Start migrating profiles processing to C++. (issue910002)
Print | Individual message | Show original | Report this message | Find messages by this author

http://codereview.chromium.org/910002/diff/10001/src/profile-generato...
File src/profile-generator.cc (right):

http://codereview.chromium.org/910002/diff/10001/src/profile-generato...
src/profile-generator.cc:143: callback->AfterChildTraversed(parent.node,
current.node);
If the callback is a DeleteNodesCallback, then we're passing a deleted
node here into AfterChildTraversed due to line 140, no? I don't know how
this code works, can that situation occur? (CID: 9378)

http://codereview.chromium.org/910002/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
mnaga...@chromium.org  
View profile  
 More options Mar 28 2011, 4:16 am
From: mnaga...@chromium.org
Date: Mon, 28 Mar 2011 08:16:37 +0000
Local: Mon, Mar 28 2011 4:16 am
Subject: Re: Start migrating profiles processing to C++. (issue910002)
Print | Individual message | Show original | Report this message | Find messages by this author

http://codereview.chromium.org/910002/diff/10001/src/profile-generato...
File src/profile-generator.cc (right):

http://codereview.chromium.org/910002/diff/10001/src/profile-generato...
src/profile-generator.cc:143: callback->AfterChildTraversed(parent.node,
current.node);
On 2011/03/25 15:18:48, Finnur wrote:

> If the callback is a DeleteNodesCallback, then we're passing a deleted
node here
> into AfterChildTraversed due to line 140, no? I don't know how this
code works,
> can that situation occur? (CID: 9378)

You are right. But in DeleteNodesCallback, AfterChildTraversed is empty,
so passing a stale pointer to it doesn't cause any harm. But I should
add a comment about it, I think. Thanks for noticing!

http://codereview.chromium.org/910002/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
sgje...@chromium.org  
View profile  
 More options Mar 28 2011, 5:24 am
From: sgje...@chromium.org
Date: Mon, 28 Mar 2011 09:24:03 +0000
Local: Mon, Mar 28 2011 5:24 am
Subject: Re: Start migrating profiles processing to C++. (issue910002)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mikhail Naganov  
View profile  
 More options Mar 28 2011, 5:56 am
From: Mikhail Naganov <mnaga...@chromium.org>
Date: Mon, 28 Mar 2011 13:56:11 +0400
Local: Mon, Mar 28 2011 5:56 am
Subject: Re: Start migrating profiles processing to C++. (issue910002)
Print | Individual message | Show original | Report this message | Find messages by this author
Soeren, this issue was committed long ago ;)  This is a late drive-by ;)


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google