Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
v8-dev
Home
+ new post
About this group
Join this group
Delivery logic for Object.observe (issue 11266011)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   5 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
ad...@chromium.org  
View profile  
 More options Nov 6 2012, 5:30 am
From: ad...@chromium.org
Date: Tue, 06 Nov 2012 10:30:11 +0000
Local: Tues, Nov 6 2012 5:30 am
Subject: Re: Delivery logic for Object.observe (issue 11266011)
Print | Individual message | Show original | Report this message | Find messages by this author
Note that this is ready for a look, though it does depend on
https://codereview.chromium.org/11274014/ (and the diff is against that  
patch,
not trunk)

https://codereview.chromium.org/11266011/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
rossb...@chromium.org  
View profile  
 More options Nov 6 2012, 11:45 am
From: rossb...@chromium.org
Date: Tue, 06 Nov 2012 16:45:57 +0000
Local: Tues, Nov 6 2012 11:45 am
Subject: Re: Delivery logic for Object.observe (issue 11266011)
Print | Individual message | Show original | Report this message | Find messages by this author

https://codereview.chromium.org/11266011/diff/16001/src/contexts.h
File src/contexts.h (right):

https://codereview.chromium.org/11266011/diff/16001/src/contexts.h#ne...
src/contexts.h:297: DELIVER_CHANGE_RECORDS_INDEX,
Is this perhaps some orphan duplicate of the above?

https://codereview.chromium.org/11266011/diff/16001/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/11266011/diff/16001/src/isolate.h#new...
src/isolate.h:357: V(bool, has_active_object_observers, false)
                        \
Maybe put a comment here explaining when this is true (the name is
slightly misleading).

https://codereview.chromium.org/11266011/diff/16001/src/object-observ...
File src/object-observe.js (right):

https://codereview.chromium.org/11266011/diff/16001/src/object-observ...
src/object-observe.js:116: var pendingChangeRecords =
observerInfo.pendingChangeRecords;
What is this variable used for?

https://codereview.chromium.org/11266011/diff/16001/src/object-observ...
src/object-observe.js:118: pendingChangeRecords =
observerInfo.pendingChangeRecords = new InternalArray(changeRecord);
Line length

https://codereview.chromium.org/11266011/diff/16001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/11266011/diff/16001/src/objects.cc#ne...
src/objects.cc:1746: isolate->set_has_active_object_observers(false);
This should probably be go to the end.

https://codereview.chromium.org/11266011/diff/16001/src/v8.cc
File src/v8.cc (right):

https://codereview.chromium.org/11266011/diff/16001/src/v8.cc#newcode228
src/v8.cc:228: if (has_active_object_observers) {
FLAG_harmony_observation && ...

https://codereview.chromium.org/11266011/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ad...@chromium.org  
View profile  
 More options Nov 6 2012, 12:00 pm
From: ad...@chromium.org
Date: Tue, 06 Nov 2012 17:00:09 +0000
Local: Tues, Nov 6 2012 12:00 pm
Subject: Re: Delivery logic for Object.observe (issue 11266011)
Print | Individual message | Show original | Report this message | Find messages by this author

https://codereview.chromium.org/11266011/diff/16001/src/contexts.h
File src/contexts.h (right):

https://codereview.chromium.org/11266011/diff/16001/src/contexts.h#ne...
src/contexts.h:297: DELIVER_CHANGE_RECORDS_INDEX,
On 2012/11/06 16:45:57, rossberg wrote:

> Is this perhaps some orphan duplicate of the above?

Yeah, merge fail. Removed.

https://codereview.chromium.org/11266011/diff/16001/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/11266011/diff/16001/src/isolate.h#new...
src/isolate.h:357: V(bool, has_active_object_observers, false)
                        \
On 2012/11/06 16:45:57, rossberg wrote:

> Maybe put a comment here explaining when this is true (the name is
slightly
> misleading).

Maybe a rename is in order? How about "observer_delivery_pending"
(object_observer_delivery_pending?)?

https://codereview.chromium.org/11266011/diff/16001/src/object-observ...
File src/object-observe.js (right):

https://codereview.chromium.org/11266011/diff/16001/src/object-observ...
src/object-observe.js:116: var pendingChangeRecords =
observerInfo.pendingChangeRecords;
On 2012/11/06 16:45:57, rossberg wrote:

> What is this variable used for?

Good question...removed.

https://codereview.chromium.org/11266011/diff/16001/src/object-observ...
src/object-observe.js:118: pendingChangeRecords =
observerInfo.pendingChangeRecords = new InternalArray(changeRecord);
On 2012/11/06 16:45:57, rossberg wrote:

> Line length

Done.

https://codereview.chromium.org/11266011/diff/16001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/11266011/diff/16001/src/objects.cc#ne...
src/objects.cc:1746: isolate->set_has_active_object_observers(false);
On 2012/11/06 16:45:57, rossberg wrote:

> This should probably be go to the end.

Done.

https://codereview.chromium.org/11266011/diff/16001/src/v8.cc
File src/v8.cc (right):

https://codereview.chromium.org/11266011/diff/16001/src/v8.cc#newcode228
src/v8.cc:228: if (has_active_object_observers) {
On 2012/11/06 16:45:57, rossberg wrote:

> FLAG_harmony_observation && ...

Done.

https://codereview.chromium.org/11266011/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
rafa...@chromium.org  
View profile  
 More options Nov 6 2012, 12:04 pm
From: rafa...@chromium.org
Date: Tue, 06 Nov 2012 17:04:41 +0000
Local: Tues, Nov 6 2012 12:04 pm
Subject: Re: Delivery logic for Object.observe (issue 11266011)
Print | Individual message | Show original | Report this message | Find messages by this author
lgtm

https://codereview.chromium.org/11266011/diff/16001/src/contexts.h
File src/contexts.h (right):

https://codereview.chromium.org/11266011/diff/16001/src/contexts.h#ne...
src/contexts.h:297: DELIVER_CHANGE_RECORDS_INDEX,
don't need this any more, right?

https://codereview.chromium.org/11266011/diff/16001/test/cctest/test-...
File test/cctest/test-object-observe.cc (right):

https://codereview.chromium.org/11266011/diff/16001/test/cctest/test-...
test/cctest/test-object-observe.cc:154: "function observer3() {
ordering.push(3); };"
maybe a comment noting that observer3 gets delivered  'a' and 'b' in one
callback.

https://codereview.chromium.org/11266011/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ad...@chromium.org  
View profile  
 More options Nov 6 2012, 12:25 pm
From: ad...@chromium.org
Date: Tue, 06 Nov 2012 17:25:20 +0000
Local: Tues, Nov 6 2012 12:25 pm
Subject: Re: Delivery logic for Object.observe (issue 11266011)
Print | Individual message | Show original | Report this message | Find messages by this author
I've renamed the Isolate member.

On 2012/11/06 17:04:41, rafaelw wrote:

> lgtm
> https://codereview.chromium.org/11266011/diff/16001/src/contexts.h
> File src/contexts.h (right):
> https://codereview.chromium.org/11266011/diff/16001/src/contexts.h#ne...
> src/contexts.h:297: DELIVER_CHANGE_RECORDS_INDEX,
> don't need this any more, right?

Yeah, already gone.

https://codereview.chromium.org/11266011/diff/16001/test/cctest/test-...

> File test/cctest/test-object-observe.cc (right):

https://codereview.chromium.org/11266011/diff/16001/test/cctest/test-...

> test/cctest/test-object-observe.cc:154: "function observer3() {
> ordering.push(3); };"
> maybe a comment noting that observer3 gets delivered  'a' and 'b' in one
> callback.

Added a comment.

https://codereview.chromium.org/11266011/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google