Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Remove unused --peephole-optimization flag. (issue 9361022)
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
kmilli...@chromium.org  
View profile  
 More options Feb 8 2012, 4:43 am
From: kmilli...@chromium.org
Date: Wed, 08 Feb 2012 09:43:31 +0000
Local: Wed, Feb 8 2012 4:43 am
Subject: Remove unused --peephole-optimization flag. (issue 9361022)
Reviewers: danno,

Description:
Remove unused --peephole-optimization flag.

R=da...@chromium.org
BUG=
TEST=

Please review this at https://chromiumcodereview.appspot.com/9361022/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
   M src/flag-definitions.h
   M src/v8.cc

Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index  
9cdea067254f2edab1bdb6ce9cc34b8dc8d2e5a9..2cee444217c8c59cbc769818aa521ef77 f726bf8  
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -168,8 +168,6 @@ DEFINE_int(loop_weight, 1, "loop weight for  
representation inference")
  DEFINE_bool(debug_code, false,
              "generate extra code (assertions) for debugging")
  DEFINE_bool(code_comments, false, "emit comments in code disassembly")
-DEFINE_bool(peephole_optimization, true,
-            "perform peephole optimizations in assembly code")
  DEFINE_bool(enable_sse2, true,
              "enable use of SSE2 instructions if available")
  DEFINE_bool(enable_sse3, true,
Index: src/v8.cc
diff --git a/src/v8.cc b/src/v8.cc
index  
36ee221948dd3a639a609907765fb18e5d5187be..e4b37b180e1f49eefc2601ed93a846769 c961c8f  
100644
--- a/src/v8.cc
+++ b/src/v8.cc
@@ -1,4 +1,4 @@
-// Copyright 2011 the V8 project authors. All rights reserved.
+// Copyright 2012 the V8 project authors. All rights reserved.
  // Redistribution and use in source and binary forms, with or without
  // modification, are permitted provided that the following conditions are
  // met:
@@ -255,9 +255,6 @@ void V8::InitializeOncePerProcess() {

    RuntimeProfiler::GlobalSetup();

-  // Peephole optimization might interfere with deoptimization.
-  FLAG_peephole_optimization = !use_crankshaft_;
-
    ElementsAccessor::InitializeOncePerProcess();

    if (FLAG_stress_compaction) {


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
da...@chromium.org  
View profile  
 More options Feb 8 2012, 4:54 am
From: da...@chromium.org
Date: Wed, 08 Feb 2012 09:54:11 +0000
Local: Wed, Feb 8 2012 4:54 am
Subject: Re: Remove unused --peephole-optimization flag. (issue 9361022)
 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »