Fix test/build failures (win64 compile warning, isolate test parallel compilation failure, gcmole i… (issue 14265024)

[mvst...@chromium.org]

Reviewers: Yang,

Message:
Here are the fixes required.

Description:
Fix test/build failures (win64 compile warning, isolate test parallel
compilation failure, gcmole issue, isolate test intermittant failure)

BUG=

Please review this at https://codereview.chromium.org/14265024/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M src/bootstrapper.cc
M src/heap.cc
M src/hydrogen.cc


Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index
e38603627cf84e0b6e1d707126e2a4e40dc8967b..f81d240a0bb5fb28f3d67c2e643d956d79702fe3
100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -890,15 +890,15 @@ bool Genesis::InitializeGlobal(Handle<GlobalObject>
inner_global,
// overwritten by JS code.
native_context()->set_array_function(*array_function);

- // Cache the array maps
- MaybeObject* cache_result = CacheInitialJSArrayMaps(*native_context(),
- *initial_map);
- if (cache_result->IsFailure()) return false;
-
if (FLAG_optimize_constructed_arrays) {
+ // Cache the array maps, needed by ArrayConstructorStub
+ MaybeObject* cache_result =
CacheInitialJSArrayMaps(*native_context(),
+ *initial_map);
+ if (cache_result->IsFailure()) return false;
+
ArrayConstructorStub array_constructor_stub(isolate);
- array_function->shared()->set_construct_stub(
- *array_constructor_stub.GetCode(isolate));
+ Handle<Code> code = array_constructor_stub.GetCode(isolate);
+ array_function->shared()->set_construct_stub(*code);
} else {
array_function->shared()->set_construct_stub(

isolate->builtins()->builtin(Builtins::kCommonArrayConstructCode));
Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index
f2f0b9bac7421f2441a0aa8787d0babeffea83ac..19735332f469222bc5fd962ae76fa96f424088ef
100644
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -163,7 +163,8 @@ Heap::Heap()
#endif
promotion_queue_(this),
configured_(false),
- chunks_queued_for_free_(NULL) {
+ chunks_queued_for_free_(NULL),
+ relocation_mutex_(NULL) {
// Allow build-time customization of the max semispace size. Building
// V8 with snapshots and a non-default max semispace size is much
// easier if you can define it as part of the build environment.
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
57854b81415fc356578dcf40b7f5d4c223717d02..f1b21d7959a52659af295cfc1078f96fc6d82927
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -1860,7 +1860,7 @@ HValue*
HGraphBuilder::JSArrayBuilder::EmitMapCode(HValue* context) {
HGlobalObject(context));
HInstruction* native_context = AddInstruction(new(zone())
HLoadNamedField(global_object, true,
GlobalObject::kNativeContextOffset));
- size_t offset = Context::kHeaderSize +
+ int offset = Context::kHeaderSize +
kPointerSize * Context::JS_ARRAY_MAPS_INDEX;
HInstruction* map_array = AddInstruction(new(zone())
HLoadNamedField(native_context, true, offset));

[yan...@chromium.org]

On 2013/04/26 08:46:04, mvstanton wrote:
> Here are the fixes required.

LGTM.

https://codereview.chromium.org/14265024/

[mvst...@chromium.org]

Committed patchset #1 manually as r14449 (presubmit successful).

https://codereview.chromium.org/14265024/