Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
v8-dev
Home
+ new post
About this group
Join this group
Define V8_EXPORT to nothing for clients of v8. (issue 10399036)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   8 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
tha...@chromium.org  
View profile  
 More options May 15 2012, 4:35 pm
From: tha...@chromium.org
Date: Tue, 15 May 2012 20:35:17 +0000
Local: Tues, May 15 2012 4:35 pm
Subject: Define V8_EXPORT to nothing for clients of v8. (issue 10399036)
Print | Individual message | Show original | Report this message | Find messages by this author
Reviewers: Mads Sig Ager, Søren Thygesen Gjesse,

Description:
Define V8_EXPORT to nothing for clients of v8.

This is to make sure that inline functions are only exported by
libv8.so and not also by all clients. This is the v8 version of
https://chromiumcodereview.appspot.com/10386108/

This CL depends on http://codereview.chromium.org/10310156/ landing
first.

BUG=chromium:90078

Please review this at https://chromiumcodereview.appspot.com/10399036/

SVN Base: http://v8.googlecode.com/svn/trunk/

Affected files:
   M     include/v8.h

Index: include/v8.h
===================================================================
--- include/v8.h        (revision 11566)
+++ include/v8.h        (working copy)
@@ -66,7 +66,11 @@
  // between building or using the V8 shared library, but we should not
  // export symbols when we are building a static library.
  #if defined(__GNUC__) && (__GNUC__ >= 4) && defined(V8_SHARED)
+#ifdef BUILDING_V8_SHARED
  #define V8EXPORT __attribute__ ((visibility("default")))
+#else
+#define V8EXPORT
+#endif
  #else  // defined(__GNUC__) && (__GNUC__ >= 4)
  #define V8EXPORT
  #endif  // defined(__GNUC__) && (__GNUC__ >= 4)


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
a...@chromium.org  
View profile  
 More options May 16 2012, 3:55 am
From: a...@chromium.org
Date: Wed, 16 May 2012 07:55:36 +0000
Local: Wed, May 16 2012 3:55 am
Subject: Re: Define V8_EXPORT to nothing for clients of v8. (issue 10399036)
Print | Individual message | Show original | Report this message | Find messages by this author
LGTM

http://codereview.chromium.org/10399036/diff/1/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/10399036/diff/1/include/v8.h#newcode65
include/v8.h:65: // Setup for Linux shared library export. There is no
need to distinguish
Please update the comment as well. :)

http://codereview.chromium.org/10399036/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
sgje...@google.com  
View profile  
 More options May 16 2012, 4:01 am
From: sgje...@google.com
Date: Wed, 16 May 2012 08:01:48 +0000
Local: Wed, May 16 2012 4:01 am
Subject: Re: Define V8_EXPORT to nothing for clients of v8. (issue 10399036)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
tha...@chromium.org  
View profile  
 More options May 16 2012, 12:16 pm
From: tha...@chromium.org
Date: Wed, 16 May 2012 16:16:04 +0000
Local: Wed, May 16 2012 12:16 pm
Subject: Re: Define V8_EXPORT to nothing for clients of v8. (issue 10399036)
Print | Individual message | Show original | Report this message | Find messages by this author
Thanks!

The prerequisite landed in r11586 – could someone land this CL?

http://codereview.chromium.org/10399036/diff/1/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/10399036/diff/1/include/v8.h#newcode65
include/v8.h:65: // Setup for Linux shared library export. There is no
need to distinguish
On 2012/05/16 07:55:36, Mads Sig Ager wrote:

> Please update the comment as well. :)

Done.

http://codereview.chromium.org/10399036/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
yang...@chromium.org  
View profile  
 More options May 18 2012, 5:48 am
From: yang...@chromium.org
Date: Fri, 18 May 2012 09:48:52 +0000
Local: Fri, May 18 2012 5:48 am
Subject: Re: Define V8_EXPORT to nothing for clients of v8. (issue 10399036)
Print | Individual message | Show original | Report this message | Find messages by this author
On 2012/05/16 16:16:04, Nico wrote:

> Thanks!
> The prerequisite landed in r11586 – could someone land this CL?
> http://codereview.chromium.org/10399036/diff/1/include/v8.h
> File include/v8.h (right):
> http://codereview.chromium.org/10399036/diff/1/include/v8.h#newcode65
> include/v8.h:65: // Setup for Linux shared library export. There is no  
> need to
> distinguish
> On 2012/05/16 07:55:36, Mads Sig Ager wrote:
> > Please update the comment as well. :)
> Done.

I'll land this then.

http://codereview.chromium.org/10399036/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
yang...@chromium.org  
View profile  
 More options May 18 2012, 5:54 am
From: yang...@chromium.org
Date: Fri, 18 May 2012 09:54:29 +0000
Local: Fri, May 18 2012 5:54 am
Subject: Re: Define V8_EXPORT to nothing for clients of v8. (issue 10399036)
Print | Individual message | Show original | Report this message | Find messages by this author
On 2012/05/18 09:48:52, Yang wrote:

Landed as r11590. Please base your future CLs on svn/bleeding_edge instead  
of
svn/trunk :)

http://codereview.chromium.org/10399036/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Nico Weber  
View profile  
 More options May 18 2012, 9:57 am
From: Nico Weber <tha...@chromium.org>
Date: Fri, 18 May 2012 06:57:01 -0700
Local: Fri, May 18 2012 9:57 am
Subject: Re: Define V8_EXPORT to nothing for clients of v8. (issue 10399036)
Print | Individual message | Show original | Report this message | Find messages by this author

Thanks!

> Please base your future CLs on svn/bleeding_edge instead of
> svn/trunk :)

Will do. Is there a wiki page somewhere that explains how to send out
patches to v8 when using the v8 directory in a chromium checkout? I just
did `cd v8; gcl change blah; gcl upload blah;`, and chromium seems to pull
from svn/trunk.

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jakob Kummerow  
View profile  
 More options May 18 2012, 10:05 am
From: Jakob Kummerow <jkumme...@chromium.org>
Date: Fri, 18 May 2012 16:05:37 +0200
Local: Fri, May 18 2012 10:05 am
Subject: Re: Define V8_EXPORT to nothing for clients of v8. (issue 10399036)
Print | Individual message | Show original | Report this message | Find messages by this author

On Fri, May 18, 2012 at 3:57 PM, Nico Weber <tha...@chromium.org> wrote:

> Will do. Is there a wiki page somewhere that explains how to send out
> patches to v8 when using the v8 directory in a chromium checkout? I just
> did `cd v8; gcl change blah; gcl upload blah;`, and chromium seems to pull
> from svn/trunk.

There isn't, because that's not supported.

V8 development happens on svn/branches/bleeding_edge; a few times per week
we push a reasonably stable snapshot of that to svn/trunk, and roll that
into Chromium.

So, to contribute to V8 (which you are most welcome to!), you should get a
checkout of bleeding_edge. See http://code.google.com/p/v8/wiki/Source (SVN)
or http://code.google.com/p/v8/wiki/UsingGit (git). These checkouts work
with gcl/git-cl just fine, so you'll get pretty close to your usual
Chromium workflow (biggest difference: there are no try bots for V8).


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google