Fixed assertion. (issue 11368141)

4 views
Skip to first unread message

sven...@chromium.org

unread,
Nov 8, 2012, 10:03:54 AM11/8/12
to verw...@chromium.org, v8-...@googlegroups.com
Reviewers: Toon Verwaest,

Description:
Fixed assertion.

The name in question is not necessarily a symbol, so we have to use Equals
instead of ==.

BUG=http://www.playescapegoat.com/


Please review this at http://codereview.chromium.org/11368141/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
M src/objects.cc


Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
4b84c9202871f3e0e53981d5056dd2923b7dffb2..b9cd0c3cfb98486803dfb23dc86a26c9698e1a7d
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -4989,7 +4989,8 @@ MaybeObject* JSObject::DefineFastAccessor(String*
name,
if (result.IsFound()) {
Map* target = result.GetTransitionTarget();
int descriptor_number = target->LastAdded();
- ASSERT(target->instance_descriptors()->GetKey(descriptor_number) ==
name);
+ ASSERT(target->instance_descriptors()->GetKey(descriptor_number)
+ ->Equals(name));
return TryAccessorTransition(
this, target, descriptor_number, component, accessor,
attributes);
}


verw...@chromium.org

unread,
Nov 8, 2012, 10:20:38 AM11/8/12
to sven...@chromium.org, v8-...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages