Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
v8-dev
Home
+ new post
About this group
Join this group
Pass the SIGPROF signal on to previously registered signal handler. (issue 11195045)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   8 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
willc...@chromium.org  
View profile  
 More options Oct 31 2012, 5:58 pm
From: willc...@chromium.org
Date: Wed, 31 Oct 2012 21:58:12 +0000
Local: Wed, Oct 31 2012 5:58 pm
Subject: Re: Pass the SIGPROF signal on to previously registered signal handler. (issue 11195045)
Print | Individual message | Show original | Report this message | Find messages by this author
Sorry for the delay, I think I've address the comment now.

https://codereview.chromium.org/11195045/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
da...@chromium.org  
View profile  
 More options Nov 2 2012, 6:35 am
From: da...@chromium.org
Date: Fri, 02 Nov 2012 10:35:52 +0000
Local: Fri, Nov 2 2012 6:35 am
Subject: Re: Pass the SIGPROF signal on to previously registered signal handler. (issue 11195045)
Print | Individual message | Show original | Report this message | Find messages by this author
lgtm, I'll land this for you.

https://codereview.chromium.org/11195045/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
da...@chromium.org  
View profile  
 More options Nov 2 2012, 6:40 am
From: da...@chromium.org
Date: Fri, 02 Nov 2012 10:40:15 +0000
Local: Fri, Nov 2 2012 6:40 am
Subject: Re: Pass the SIGPROF signal on to previously registered signal handler. (issue 11195045)
Print | Individual message | Show original | Report this message | Find messages by this author
Hold on, although the patch applies cleanly, the call of
SignalSender::CallOldSignalHandler isn't declared before it's use, so
compilation fails. Can you please address this (make sure that "make check  
-j15"
runs on your V8 directory) and resubmit the patch?

https://codereview.chromium.org/11195045/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
willc...@chromium.org  
View profile  
 More options Nov 2 2012, 5:25 pm
From: willc...@chromium.org
Date: Fri, 02 Nov 2012 21:25:18 +0000
Local: Fri, Nov 2 2012 5:25 pm
Subject: Re: Pass the SIGPROF signal on to previously registered signal handler. (issue 11195045)
Print | Individual message | Show original | Report this message | Find messages by this author
OK, I think this should work for real this time.

https://codereview.chromium.org/11195045/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
da...@chromium.org  
View profile  
 More options Nov 7 2012, 12:19 pm
From: da...@chromium.org
Date: Wed, 07 Nov 2012 17:19:30 +0000
Local: Wed, Nov 7 2012 12:19 pm
Subject: Re: Pass the SIGPROF signal on to previously registered signal handler. (issue 11195045)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
mstarzin...@chromium.org  
View profile  
 More options Nov 7 2012, 2:57 pm
From: mstarzin...@chromium.org
Date: Wed, 07 Nov 2012 19:57:38 +0000
Local: Wed, Nov 7 2012 2:57 pm
Subject: Re: Pass the SIGPROF signal on to previously registered signal handler. (issue 11195045)
Print | Individual message | Show original | Report this message | Find messages by this author
Two Webkit tests started crashing with this change on both (32 bit and 64  
bit)
Webkit Linux integration builders. The name strongly suggests that it is
actually related to this change and not just a flake.

Regressions: Unexpected crashes (2)
   inspector/profiler/cpu-profiler-profiling-without-inspector.html
   inspector/profiler/cpu-profiler-profiling.html

http://build.chromium.org/p/client.v8/builders/Webkit%20Linux/builds/...
http://build.chromium.org/p/client.v8/builders/Webkit%20Linux%2064/bu...

https://codereview.chromium.org/11195045/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
陈智昌 William Chan  
View profile  
 More options Nov 7 2012, 3:03 pm
From: William Chan (陈智昌) <willc...@chromium.org>
Date: Wed, 7 Nov 2012 12:03:05 -0800
Local: Wed, Nov 7 2012 3:03 pm
Subject: Re: Pass the SIGPROF signal on to previously registered signal handler. (issue 11195045)
Print | Individual message | Show original | Report this message | Find messages by this author

That sounds likely. I will return to the office next week and would be
happy to look at this then. Feel free to revert this in the meanwhile.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Michael Starzinger  
View profile  
 More options Nov 7 2012, 3:07 pm
From: Michael Starzinger <mstarzin...@google.com>
Date: Wed, 7 Nov 2012 21:07:26 +0100
Local: Wed, Nov 7 2012 3:07 pm
Subject: Re: Pass the SIGPROF signal on to previously registered signal handler. (issue 11195045)
Print | Individual message | Show original | Report this message | Find messages by this author

OK, I guess in that case we will have to revert the change, because it will
prevent us from rolling into Chromium otherwise. I'll do the revert.

Best regards,
Michael

On Wed, Nov 7, 2012 at 9:03 PM, William Chan (陈智昌) <willc...@chromium.org>wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google