[textpattern commit] r2984 - development/4.0/textpattern/include

[codesite...@google.com]

Author: ru...@vanmelick.com
Date: Tue Oct 7 10:33:06 2008
New Revision: 2984

Modified:
development/4.0/textpattern/include/txp_admin.php

Log:
Precedence order for the NOT operator was different before MySQL 5.0.2,
causing this query to always return an empty result set (Thanks Rick\!) on
older MySQL versions. Same problem can occur on more recent MySQL versions
when enabling HIGH_NOT_PRECEDENCE SQL mode. If we can't rely on a stable
precedence order for the NOT operator, a tiny rewrite of the SQL query is
necessary.

Modified: development/4.0/textpattern/include/txp_admin.php
==============================================================================
--- development/4.0/textpattern/include/txp_admin.php (original)
+++ development/4.0/textpattern/include/txp_admin.php Tue Oct 7 10:33:06
2008
@@ -454,7 +454,7 @@
return admin();
}

- $names = safe_column('name', 'txp_users', "name IN ('".join("','",
doSlash($selected))."') AND NOT name = '".doSlash($txp_user)."'");
+ $names = safe_column('name', 'txp_users', "name IN ('".join("','",
doSlash($selected))."') AND name != '".doSlash($txp_user)."'");

if (!$names) return admin();