                                                                                                                                                                                                                                                                
Received-SPF: pass (google.com: domain of alessandro.mol...@gmail.com designates 209.85.220.176 as permitted sender) client-ip=209.85.220.176;
MIME-Version: 1.0
In-Reply-To: <506B3C08.4060...@sysgroup.fr>
References: <5066C8EC.8050...@sysgroup.fr>
	<CAJfq2JG88nRHea6VGjGEcJEHLyHMZODTieF+EpsJAyJUsmQ...@mail.gmail.com>
	<5066FD47.3060...@sysgroup.fr>
	<CAJfq2JHa+ovfO4yDwJdRs+gYvV3ocutPRkk+t6RN+UQ6V7m...@mail.gmail.com>
	<50672390.9010...@sysgroup.fr>
	<CAEF3qb=aujj-Mdgm7j-biRCAoFhGetGe8+vakufrZWqCsvc...@mail.gmail.com>
	<50672860.8060...@sysgroup.fr>
	<CAEF3qbnHjiZ7Ugfgg1DX4GxshxW0NGKmYYNwTNfAwLQ1any...@mail.gmail.com>
	<506744CD.9040...@sysgroup.fr>
	<CAEF3qbn55QH2mdFc-zUcX-Ju98K479g+pevGVV9A8gaG8he...@mail.gmail.com>
	<506B3C08.4060...@sysgroup.fr>
Date: Wed, 3 Oct 2012 11:21:25 +0200
Message-ID: <CAJfq2JGCLy4S8ObLL8V4vAzkbAhdvcsCgMWmxQr4G3DY9CS...@mail.gmail.com>
Subject: Re: [TurboGears] adding filters to jinja : templatetools - more
 changes to app_config.py
From: Alessandro Molina <alessandro.mol...@gmail.com>
To: turbogears@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Currently Jinja autoescape has been set to True for upcoming releases
by default to match the behavior all the other template engines have.
I agree that an option would be great, but the default behavior should
be to enable autoscaping to be coherent with the current behavior for
the other template engines.

It probably also make sense to make this options unique for all the
template engines (much like the templates reload is) as it is probably
rare that the user is going to work with escaping enable on some
template engines and disable on others. Then we can provide a template
engine specific option to override it.

On Tue, Oct 2, 2012 at 9:10 PM, Remi Jolin <remi.jo...@sysgroup.fr> wrote:
> Carlos,
>
> While you are making changes to app_config.py could you add a new
> configuration option to be able define autoescape at the main level :
>
>         if not 'jinja_filters' in self:
>             self.jinja_filters =3D {}
>
>         if not 'jinja_autoescape' in self:
>             self.jinja_autoescape =3D False
>
>         loader =3D ChoiceLoader(
>             [TemplateLoader(path) for path in self.paths['templates']])
>
>         config['pylons.app_globals'].jinja2_env =3D Environment(
>                  autoescape=3Dself.jinja_autoescape, loader=3Dloader,
>                  auto_reload=3Dself.auto_reload_templates,
> extensions=3Dself.jinja_extensions)
>
> so we can define
> base_config.jinja_extensions =3D ['jinja2.ext.with_', 'jinja2.ext.autoesc=
ape']
> base_config.jinja_autoescape =3D True
>  in app_cfg.py
>
> or perhaps there is a better option to achieve this.
>
> Le 29/09/2012 21:58, Carlos Daniel Ruvalcaba Valenzuela a =E9crit :
>>
>> I pushed to my development branch something very similar, but would
>> like some input from core developers before getting to the pull
>> request.
>>
>>
>> https://github.com/clsdaniel/tg2/commit/7cc62f9130fc9651e7258490874bbc3c=
a886ba90
>>
>> I'm not sure about having a dictionary inside the __init__.py called
>> jinja_filters, if you have the file and define the dict on __init__.py
>> you will not be able to import jinja_filters.py the way we are doing
>> it right now (via __import__), but we can add a special case to manage
>> that. Keeping it simple seems to be the way to go in my opinion.
>>
>> Perhaps the jinja quickstart template could include
>> templatetools/__init__.py and jinja_filter.py files with some comments
>> to guide the developer.
>>
>> Regards,
>> Carlos Daniel Ruvalcaba Valenzuela
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "TurboGears" group.
> To post to this group, send email to turbogears@googlegroups.com.
> To unsubscribe from this group, send email to
> turbogears+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/turbogears?hl=3Den.
>