Paginate: sorting by multiple fields in default_order - TurboGears

Message from discussion Paginate: sorting by multiple fields in default_order

Roger Demetrescu

More options Nov 20 2007, 9:34 pm

From: "Roger Demetrescu" <roger.demetre...@gmail.com>

Date: Tue, 20 Nov 2007 23:34:24 -0300

Local: Tues, Nov 20 2007 9:34 pm

Subject: Re: [TurboGears] Paginate: sorting by multiple fields in default_order

  Reply to author
  |
  Forward
  | Print
  | View thread
  | Show original
  | Report this message
  | Find messages by this author
  

On Nov 20, 2007 10:20 PM, Joel Pearson <j...@pythonica.com> wrote:

> Roger Demetrescu wrote:
> > Have you any news on this ?
> > I'd really like to see this feature in TG 1.0.4.... ;)

> > If you can quickly fill a ticket with your patch, we can ask Florent
> > to wait a couple of hours more before releasing 1.0.4b3 ...

> > And don't worry about tests. I can code them before applying your patch... :)

> Sorry for the delay. I just went to re-create the patch against the current
> version, but I won't be able to finish merging my changes for another 6 hours
> or so, due to prior commitments. Also, I didn't mention previously that my
> current version alters the appearance of the URL variable *_tgp_ordering from
> being a URL-encoded dict to being a simple comma-separated list of field names
> in sort order, with optional leading dashes on each field name to indicate
> reversed order. (Note: I didn't change any internal data structures, just how
> the URL is produced in get_href() and how it is parsed in convert_order().)

> Thus, what previously looked like this (in the URL):

> company_tgp_ordering=%7B%27state%27%3A%20%5B1%2C%20True%5D%2C%20u%27city%27 %3A%20%5B0%2C%20True%5D%7D

> now looks like this:

> company_tgp_ordering=state,city

Hmm.. the actual code already produces an ugly URL when you start
changing the order of columns, so I think this is not an issue.

Basically the core portion of my modification became:

====
elif default_order and not ordering:
# ordering = {default_order:[0, not default_reversed]}

if isinstance(default_order, basestring):
# adapt old style to new style
df = [(default_reversed and "-" or "") + default_order]
elif default_reversed:
raise StandardError("default_reversed (deprecated) is only "
" allowed when default_order is basestring type")
else:
df = default_order

ordering = dict([(v.lstrip('-'), [k, not v.startswith('-')])
for k,v in enumerate(df)])
====

BTW, It doesn't handle some strange configuration, like ['city',
'----street'], for the sake of simplicity...

I hope it will work as expected... :)

[]s

Reply to author Forward