Attached is an SVN diff against util.py that should resolve ticket #1396.
However, I think that there may also be an error in the "if key or not args" line. getargvalues returns the local variables for the frame in addition to the call parameters, so it's unlikely that args will ever be empty, even (especially?) for a call with an empty parameter list. Additionally, it conflicts with the preceding loop, which allows a match even if there are extra call parameters, as long as the parameters that are in kw are present in args and match (ie, [a, b] == [a, b, c]). As I am unsure what the intended behavior is (ability to compare local variables seems unlikely, but not entirely out of the question), I did not make any changes to that part. If someone would like to clarify the expected behavior, I'd be happy to submit a more complete patch.
Cory Johns Systems Tower Hill Insurance Group, Inc.
<<util.diff>>
CONFIDENTIAL NOTICE: This email including any attachments, contains confidential information belonging to the sender. It may also be privileged or otherwise protected by work product immunity or other legal rules. This information is intended only for the use of the individual or entity named above. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or the taking of any action in reliance on the contents of this emailed information is strictly prohibited. If you have received this email in error, please immediately notify us by reply email of the error and then delete this email immediately.
> Attached is an SVN diff against util.py that should resolve ticket #1396.
> However, I think that there may also be an error in the "if key or not args" > line. getargvalues returns the local variables for the frame in addition to > the call parameters, so it's unlikely that args will ever be empty, even > (especially?) for a call with an empty parameter list. Additionally, it > conflicts with the preceding loop, which allows a match even if there are > extra call parameters, as long as the parameters that are in kw are present > in args and match (ie, [a, b] == [a, b, c]). As I am unsure what the > intended behavior is (ability to compare local variables seems unlikely, but > not entirely out of the question), I did not make any changes to that part. > If someone would like to clarify the expected behavior, I'd be happy to > submit a more complete patch.
> Cory Johns > Systems > Tower Hill Insurance Group, Inc.
> <<util.diff>>
> CONFIDENTIAL NOTICE: This email including any attachments, contains > confidential information belonging to the sender. It may also be > privileged or otherwise protected by work product immunity or other > legal rules. This information is intended only for the use of the > individual or entity named above. If you are not the intended > recipient, you are hereby notified that any disclosure, copying, > distribution or the taking of any action in reliance on the contents > of this emailed information is strictly prohibited. If you have > received this email in error, please immediately notify us by > reply email of the error and then delete this email immediately.
On 7/3/07, Florent Aide <florent.a...@gmail.com> wrote:
> Hi Cory,
> Your patch seems full of =3D and =0A= when I download it, it must be > some mangling done by the mailer (either yours or mine)...
> Could you attach the file directly to the trac ticket or maybe try to > send it again ?
> Thanks in advance, > Florent.
Hi Cory,
I am doing some review of the tickets for the upcoming 1.0.4 release and wondered if you wanted to send us back a new patch in our track so we could try to incorporate your changes in the release...
