ticket #1166 for TG 1.0b?

0 views
Skip to first unread message

Max Ischenko

unread,
Dec 22, 2006, 7:45:06 AM12/22/06
to turbogea...@googlegroups.com
Hello,

Can I apply patch from ticket #1166 to Turbogears stable branch so that it will appear in next 1.0 release?

I have already applied it to tg trunk.

Max.

Alberto Valverde

unread,
Dec 22, 2006, 7:49:22 AM12/22/06
to turbogea...@googlegroups.com

On Dec 22, 2006, at 1:45 PM, Max Ischenko wrote:

> Hello,
>
> Can I apply patch from ticket #1166 to Turbogears stable branch so
> that it will appear in next 1.0 release?
>

+1 from me. I'm about to commit #930 which will complement each
other... :)

Alberto

Jorge Vargas

unread,
Dec 22, 2006, 8:46:37 AM12/22/06
to turbogea...@googlegroups.com
yes indeed anything that makes tests more robust should go in
> Alberto
>
>
> >
>

Max Ischenko

unread,
Dec 22, 2006, 10:08:08 AM12/22/06
to turbogea...@googlegroups.com
Hi,

On 12/22/06, Jorge Vargas <jorge....@gmail.com> wrote:
> +1 from me. I'm about to commit #930 which will complement each
> other... :)
>
yes indeed anything that makes tests more robust should go in

Applied in 2258.

Do I need to update any docs or ChangeLog?

Basically, from the user  API, the patch adds a couple of new methods.

testutil.set_identity_user method allows you to set user for requests executed eventuall with testutil.call or testutil.create_request. This method uses new Identity API,
authenticated_identity which allows you to set idenitity.current.user directly, instead of normal authentication process.

Max.

Alberto Valverde

unread,
Dec 22, 2006, 10:43:26 AM12/22/06
to turbogea...@googlegroups.com
On Dec 22, 2006, at 4:08 PM, Max Ischenko wrote:

Hi,

On 12/22/06, Jorge Vargas <jorge....@gmail.com> wrote:
> +1 from me. I'm about to commit #930 which will complement each
> other... :)
>
yes indeed anything that makes tests more robust should go in

Applied in 2258.

Do I need to update any docs or ChangeLog?

An update to the docs would be useful. Don't worry, I'll take care of updating the changelog when the dust settles from today's ticket rally :)

Alberto
Reply all
Reply to author
Forward
0 new messages