Re: Code cleanup for modulestorage.py (issue190069)
Hartmut Goebel
>> datas[position + i][j]
>
>> renders unreadable
>
> We do it is the rule.
So you are not accepting this patchset, which fixes bugs, because of to
spaces?! You are a fool!
Removing the isse.
--
Schönen Gruß - Regards
Hartmut Goebel
Dipl.-Informatiker (univ.), CISSP, CSSLP
Goebel Consult
Spezialist für IT-Sicherheit in komplexen Umgebungen
http://www.goebel-consult.de
Monatliche Kolumne: http://www.cissp-gefluester.de/
Goebel Consult mit Mitglied bei http://www.7-it.de
Cédric Krier
> cedric...@b2ck.com schrieb:
>
> >> datas[position + i][j]
> >
> >> renders unreadable
> >
> > We do it is the rule.
>
> So you are not accepting this patchset, which fixes bugs, because of to
> spaces?! You are a fool!
>
> Removing the isse.
>
- How do you want people react about this kind of messages on tryton-dev.
Nobody knows what you are talking about. (Crossposting is bad).
So I resume for everybody, he is talking about this
http://codereview.appspot.com/190069/ (but it is no more readable), a patch
to refactore import_data in ModelStorage. There was some discussion about
issue, better way and coding guidelines.
You complain about coding guidelines that says to put one space arround
arithmetic operators. It is not the first time, we talk about this one. You
continue to not respect it and you try to submit patches.
You complain about the lake of coding guidelines but when we try to enforce
it, you complain again.
- I spend a lot of time to review patches and make comments. I try to explain
what is wrong and how to do it like for
http://codereview.appspot.com/189092/
I think it helps contributors to learn better Tryton and submit in the
future better patches.
For me, I could see this like a lost of time because it will be faster to do
it myself.
- Don't worry about bugs. We will spend the time to fix it anyway with or
without your patch.
--
Cédric Krier
B2CK SPRL
Rue de Rotterdam, 4
4000 Liège
Belgium
Tel: +32 472 54 46 59
Email: cedric...@b2ck.com
Jabber: cedric...@b2ck.com
Website: http://www.b2ck.com/
twitter: http://twitter.com/cedrickrier
identi.ca: http://identi.ca/cedrickrier