Code clean up

[Diego Búrigo Zacarão]

Hey,

I just started a 'clean up' of code this week and I've pushed a branch to bitbucket.

I would like some feedback on it before actually commit it in mainline.

Does anyone interested in give me a 'hand'? :)

http://bitbucket.org/diegobz/transifex-django/

Regards

--
Diego Búrigo Zacarão

Transifex: The Multilingual Publishing Revolution
http://www.transifex.net/ -- http://www.indifex.com/

[Christos Trochalakis]

2009/9/19 Diego Búrigo Zacarão <die...@indifex.com>:

> Hey,
>
> I just started a 'clean up' of code this week and I've pushed a branch to
> bitbucket.
>
> I would like some feedback on it before actually commit it in mainline.
>
> Does anyone interested in give me a 'hand'? :)
>

I am not that familiar with the current code, but those changes
definitely look good :)

Just two points,
* POTManager.po_file_stats() method parses the output even if msgmerge
throws an Exception, is that what we want to do?
* Do we support python 2.4 or only 2.5+?

I just sent a few minor stylistic changes, mostly regexp-replace kind of stuff

-christos

[John Beredimas]

Hey Christos,

> * Do we support python 2.4 or only 2.5+?

We support Python 2.4 as well, since this is what is bundled in RHEL 5.x.

Kr,

John

--
John Beredimas
Indifex Ltd.

[Diego Búrigo Zacarão]

Hey!

On Sun, Sep 20, 2009 at 3:56 PM, Christos Trochalakis <yat...@ideopolis.gr> wrote:

2009/9/19 Diego Búrigo Zacarão <die...@indifex.com>:

> Hey,
>
> I just started a 'clean up' of code this week and I've pushed a branch to
> bitbucket.
>
> I would like some feedback on it before actually commit it in mainline.
>
> Does anyone interested in give me a 'hand'? :)
>

I am not that familiar with the current code, but those changes
definitely look good :)

Great!

 

Just two points,
* POTManager.po_file_stats() method parses the output even if msgmerge
throws an Exception, is that what we want to do?

Yes. It is expected.
In case the msgmerge fails we set the 'is_msgmerged' field of the translations.models.POFile
to False and copy the original PO file to the static directory.
 

* Do we support python 2.4 or  only 2.5+?

We support both as John said in the other email.
 

I just sent a few minor stylistic changes, mostly regexp-replace kind of stuff

Awesome!!
But I just tried to import it and it failed. :(
Were those changes really made on my BB branch?

Thanks, Christos!