Diffs between Wiki Pages leads to stacktrace.

[mb]

Hi all,

there seems to be no button to directly view the history of a Wiki
Page, but once I tried
http://OUR_SERVER/TRAC/wiki/WikiStart?action=history I got a full
history.
(It would be nice to have a link or button to go to the history of a
page.)

If I choose two revisions, that are at least 2 apart, I can view the
diff between them. But any
diff between direct revision neighbours leads to the following
stacktrace.

So neither URL works for me to view the diff between two direct
revision neighbours:

http://OUR_SERVERTRAC/wiki/WikiStart?action=diff&version=12 (aka
'Last change')

http://OUR_SERVERTRAC/wiki/WikiStart?action=diff&version=12&old_version=11

That is with a r4450 of trunk and r441 of genshi/branches/stable/0.3.x.

Traceback (most recent call last):
File "/usr/lib/python2.4/site-packages/trac/web/api.py", line 329, in
send_error
'text/html')
File "/usr/lib/python2.4/site-packages/trac/web/chrome.py", line 547,
in render_template
return stream.render(method, doctype=doctype)
File "/usr/lib/python2.4/site-packages/genshi/core.py", line 141, in
render
output = u''.join(list(generator))
File "/usr/lib/python2.4/site-packages/genshi/output.py", line 200,
in __call__
for kind, data, pos in stream:
File "/usr/lib/python2.4/site-packages/genshi/output.py", line 488,
in __call__
for kind, data, pos in chain(stream, [(None, None, None)]):
File "/usr/lib/python2.4/site-packages/genshi/output.py", line 436,
in __call__
for kind, data, pos in stream:
File "/usr/lib/python2.4/site-packages/genshi/core.py", line 202, in
_ensure
for event in stream:
File "/usr/lib/python2.4/site-packages/genshi/core.py", line 202, in
_ensure
for event in stream:
File "/usr/lib/python2.4/site-packages/trac/web/chrome.py", line 567,
in _strip_accesskeys
for kind, data, pos in stream:
File "/usr/lib/python2.4/site-packages/genshi/core.py", line 202, in
_ensure
for event in stream:
File "/usr/lib/python2.4/site-packages/trac/web/chrome.py", line 556,
in _generate
for kind, data, pos in stream:
File "/usr/lib/python2.4/site-packages/genshi/filters.py", line 147,
in __call__
for kind, data, pos in stream:
File "/usr/lib/python2.4/site-packages/genshi/template.py", line
1148, in _match
content = list(content)
File "/usr/lib/python2.4/site-packages/genshi/filters.py", line 147,
in __call__
for kind, data, pos in stream:
File "/usr/lib/python2.4/site-packages/genshi/template.py", line
1123, in _match
for kind, data, pos in stream:
File "/usr/lib/python2.4/site-packages/genshi/template.py", line
1112, in _strip
kind, data, pos = stream.next()
File "/usr/lib/python2.4/site-packages/genshi/template.py", line 946,
in _eval
for event in substream:
File "/usr/lib/python2.4/site-packages/genshi/template.py", line 925,
in _eval
result = data.evaluate(ctxt)
File "/usr/lib/python2.4/site-packages/genshi/eval.py", line 93, in
evaluate
{'data': data})
File "/usr/share/trac/templates/error.html", line 51, in <Expression
u""\\n" in v and ["`%s`[[br]]" % line for line in v.split("\\n")] or
"`%s`" % v">
</py:for>
TypeError: iterable argument required

I didn't find an entry in the tickets. (The closest match seemed to be
4420). Is this a known Problem, a new Bug or did I make mistake?

TIA
Max

[Christian Boos]

mb wrote:
>
> Hi all,
>
> there seems to be no button to directly view the history of a Wiki
> Page, but once I tried
> http://OUR_SERVER/TRAC/wiki/WikiStart?action=history I got a full
> history.
> (It would be nice to have a link or button to go to the history of a
> page.)

That would be useful, though there's currently a shortage of space, so I
didn't want to add a 5th link, as I've found the "Last change" link to
be more frequently used.

The idea is to eventually add Tabs, a la Wikipedia: "<page title>" for
the default view, "Discussion" and "History".
The last change navigation link would stay in the "View" tab.
(more details about this proposal in
http://trac.edgewall.org/wiki/TracProject/UiGuidelines).

>
> If I choose two revisions, that are at least 2 apart, I can view the
> diff between them. But any
> diff between direct revision neighbours leads to the following
> stacktrace.
>
> So neither URL works for me to view the diff between two direct
> revision neighbours:
>
> http://OUR_SERVERTRAC/wiki/WikiStart?action=diff&version=12 (aka
> 'Last change')
>
> http://OUR_SERVERTRAC/wiki/WikiStart?action=diff&version=12&old_version=11
>
>
> That is with a r4450 of trunk and r441 of genshi/branches/stable/0.3.x.
>
> Traceback (most recent call last):

> ...

> u""\\n" in v and ["`%s`[[br]]" % line for line in v.split("\\n")] or
> "`%s`" % v">

> TypeError: iterable argument required

Well this error is actually hiding the real error.
That secondary error has been recently fixed, so you should try to
upgrade to the latest trunk (r4607).
I wouldn't be surprised if the original error was also fixed at that
revision!

(btw, you'll need to upgrade Genshi as well, I've checked that r441
doesn't contain the r461 change needed for latest trunk, so either
upgrade to the released 0.3.6 or to the latest of the 0.3.x stable
branch or alternatively get a recent 0.4dev).

-- Christian

[mb]

Thanks I'll try that first thing Monday.

Max

[mb]

Hi,

the update worked just fine. Except now most macros don't work anymore
(I think because of r4451). But I fixed the most important ones for our
environment. So thanks for the help.

Max