Received: by 10.52.23.170 with SMTP id n10mr544195vdf.10.1312366830785;
        Wed, 03 Aug 2011 03:20:30 -0700 (PDT)
X-BeenThere: tpf-gsoc-students@googlegroups.com
Received: by 10.220.39.74 with SMTP id f10ls3633276vce.5.canary; Wed, 03 Aug
 2011 03:20:30 -0700 (PDT)
Received: by 10.52.176.35 with SMTP id cf3mr313333vdc.15.1312366830230;
        Wed, 03 Aug 2011 03:20:30 -0700 (PDT)
Received: by 10.52.176.35 with SMTP id cf3mr313332vdc.15.1312366830222;
        Wed, 03 Aug 2011 03:20:30 -0700 (PDT)
Return-Path: <reini.ur...@gmail.com>
Received: from mail-qy0-f178.google.com (mail-qy0-f178.google.com [209.85.216.178])
        by gmr-mx.google.com with ESMTPS id h2si935265vdv.0.2011.08.03.03.20.29
        (version=TLSv1/SSLv3 cipher=OTHER);
        Wed, 03 Aug 2011 03:20:29 -0700 (PDT)
Received-SPF: pass (google.com: domain of reini.ur...@gmail.com designates 209.85.216.178 as permitted sender) client-ip=209.85.216.178;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of reini.ur...@gmail.com designates 209.85.216.178 as permitted sender) smtp.mail=reini.ur...@gmail.com; dkim=pass (test mode) header...@gmail.com
Received: by qyk27 with SMTP id 27so505614qyk.2
        for <tpf-gsoc-students@googlegroups.com>; Wed, 03 Aug 2011 03:20:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
        bh=fIRA8T7GzN8dRSocGe7ok2f0gDWCxUuQUVkj6sZzsCw=;
        b=Nq17dOHBpCNeBtjiPgVbAchvSpZOuZkf+F6/HF2g49c+zcrCduH2tAFC55YSPKNob9
         NZjOlhtdEW9sti5f/vMJXIUGSRUR4XUlgYkbUzFLquBHChvDIe7mW9953ljkKjM5VvxB
         5sdlcVD7HM+YmYV+xLVLxp3dhWwWRUU6AMSt0=
MIME-Version: 1.0
Received: by 10.229.231.66 with SMTP id jp2mr1466987qcb.83.1312366828928; Wed,
 03 Aug 2011 03:20:28 -0700 (PDT)
Sender: reini.ur...@gmail.com
Received: by 10.229.211.146 with HTTP; Wed, 3 Aug 2011 03:20:28 -0700 (PDT)
In-Reply-To: <CA+nL+nbZqYxjZbPU9m1vO5sYCZi17gBnr=is2R4irjunAB3wSw@mail.gmail.com>
References: <CA+nL+nbZqYxjZbPU9m1vO5sYCZi17gBnr=is2R4irjunAB3...@mail.gmail.com>
Date: Wed, 3 Aug 2011 12:20:28 +0200
Message-ID: <CAHiT=DGT3v_qRRdiV-PYzfei7s2cyyojvKj99c-WF1cfMnj...@mail.gmail.com>
Subject: Re: GSOC Status Report, Week 10
From: Reini Urban <rur...@x-ray.at>
To: tpf-gsoc-students@googlegroups.com, Brian Fraser <frase...@gmail.com>
Cc: Perl5 Porters Mailing List <perl5-port...@perl.org>, Florian Ragwitz <r...@debian.org>, 
	Father Chrysostomos <spr...@cpan.org>, Zefram <zef...@fysh.org>, 
	Karl Williamson <pub...@khwilliamson.com>
Content-Type: text/plain; charset=ISO-8859-1

2011/8/3 Brian Fraser <frase...@gmail.com>:
> Turns out cleaning up labels was a bit more work than I had anticipated; I
> had to add new versions of the C(op|x)LABEL() macros to get the length and
> the flags of the label, modify the PVOP struct and the do*label() functions
> to take a flags parameter, add _flags variants to newPVOP and newSTATEOP,
> and change LABEL's type in perly.y from p_tkval to opval, which meant
> modifying toke.c too.
> I thought it was going to take adding a flags parameter somewhere. This was
> the complete opposite of attributes : (

I see the attributes work on github, but not CopLABEL's yet.

I'm also concerned about the public HEK API.
I see only functions accepting HEK's, but no functions getting those.
How should we create HEK's which need to be passed to the setters?

#if defined(PERL_IN_HV_C)
...
sa	|HE*	|new_he
sanR	|HEK*	|save_hek_flags	|NN const char *str|I32 len|U32 hash|int flags

Shouldn't those be public now?
-- 
Reini