toroiseproc commit hangs

21 views
Skip to first unread message

Michael Corr

unread,
Jun 28, 2009, 7:27:23 PM6/28/09
to us...@tortoisesvn.tigris.org
Hi,
I'm trying to run tortoiseproc commit from the command line. The dialog opens properly, my comments get filled in correctly, and the modified files are checked correctly - but the dialog does not automatically press the 'ok' button. It simply hangs waiting for a manual button press

Here is my command line:
tortoiseproc /command:commit /path:"%FW_PRODUCTS_PATH%" /logmsg:"[AutoBuild] %VERSION_NUMBER% %BUILD_TYPE%" /closeonend:1

Isn't /closeonend:1 supposed to automatically submit the entry and close the dialog?

It seems to work fine on /command:update

any ideas? I'm running v1.6.3

thanks
Michael

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2366183

To unsubscribe from this discussion, e-mail: [users-un...@tortoisesvn.tigris.org].

Stefan Küng

unread,
Jun 29, 2009, 4:17:43 AM6/29/09
to us...@tortoisesvn.tigris.org
Michael Corr wrote:
> Hi,
> I'm trying to run tortoiseproc commit from the command line. The dialog opens properly, my comments get filled in correctly, and the modified files are checked correctly - but the dialog does not automatically press the 'ok' button. It simply hangs waiting for a manual button press
>
> Here is my command line:
> tortoiseproc /command:commit /path:"%FW_PRODUCTS_PATH%" /logmsg:"[AutoBuild] %VERSION_NUMBER% %BUILD_TYPE%" /closeonend:1
>
> Isn't /closeonend:1 supposed to automatically submit the entry and close the dialog?
>
> It seems to work fine on /command:update

The /closeonend param is used to close the progress info dialog at the
*end* of the operation. There is no way to automatically close the
commit dialog (or any other dialog besides the progress info dialog).

If you want to fully automate commits without any user interaction, you
should use the command line client. TortoiseSVN is an UI client and not
suited for such tasks.

Stefan

--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2366270

signature.asc

Michael Corr

unread,
Jun 30, 2009, 2:37:12 AM6/30/09
to us...@tortoisesvn.tigris.org
Stefan,
Thanks for the reply.

How come the /command:update /closeonend:1 automatically closes the update dialog, then?

I guess I don't understand what the /closeonend:1 does for the /command:commit dialog. If I have to manually press the 'ok' button to close the dialog window, what is left for the /closeonend to do? Why have it?

I copied the example code in the help files

thanks
Michael

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2366620

Jean-Marc van Leerdam

unread,
Jun 30, 2009, 2:51:10 AM6/30/09
to us...@tortoisesvn.tigris.org
Michael,

2009/6/30 Michael Corr <mic...@aduratech.com>:


> Stefan,
> Thanks for the reply.
>
> How come the /command:update /closeonend:1 automatically closes the update dialog, then?
>
> I guess I don't understand what the /closeonend:1 does for the /command:commit dialog. If I have to manually press the 'ok' button to close the dialog window, what is left for the /closeonend to do? Why have it?
>

The closeonend is meant to close the progress window after the command
finishes. The commit dialog expects confirmation from the user before
the command starts; there is no such pre-command dialog for the update
command.

--
Regards,

Jean-Marc
--
. ___
. @@ // \\ "De Chelonian Mobile"
. (_,\/ \_/ \ TortoiseSVN
. \ \_/_\_/> The coolest Interface to (Sub)Version Control
. /_/ \_\ http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2366626

Simon Large

unread,
Jun 30, 2009, 4:34:28 AM6/30/09
to us...@tortoisesvn.tigris.org
2009/6/30 Michael Corr <mic...@aduratech.com>:

> Stefan,
> Thanks for the reply.
>
> How come the /command:update /closeonend:1 automatically closes the update dialog, then?
>
> I guess I don't understand what the /closeonend:1 does for the /command:commit dialog. If I have to manually press the 'ok' button to close the dialog window, what is left for the /closeonend to do? Why have it?

Please take the trouble to read the reply. As Stefan said /closeonend
closes the *progress* dialog which comes up while the commit is
executing. Your requirement is to commit without user intervention,
and you need a non-GUI client for that, like the subversion command
line client.

Simon

--
: ___
: oo // \\ "De Chelonian Mobile"
: (_,\/ \_/ \ TortoiseSVN
: \ \_/_\_/> The coolest Interface to (Sub)Version Control
: /_/ \_\ http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2366646

Kurt Pruenner

unread,
Jun 30, 2009, 5:36:59 AM6/30/09
to us...@tortoisesvn.tigris.org
Simon Large wrote:
> Michael Corr:

> > I guess I don't understand what the /closeonend:1 does for the
> > /command:commit dialog. If I have to manually press the 'ok' button
> > to close the dialog window, what is left for the /closeonend to do?
> > Why have it?
>
> Please take the trouble to read the reply. As Stefan said /closeonend
> closes the *progress* dialog which comes up while the commit is
> executing. Your requirement is to commit without user intervention,
> and you need a non-GUI client for that, like the subversion command
> line client.

Then again it's not unthinkable for people to want to use TortoiseSVN
instead of the command-line library or the svn libraries because it
actually pops up the results in a nice status dialog, instead of a
command line window or no UI at all...

I'm pretty sure there's enough cases where you don't want the user to
interfere with the actual command, but want him to be able to view the
progress and take note of the result - which is something TortoiseSVN
does a lot better than most other methods.

Just my 0.02 EUR...

--
Kurt Bernhard Pruenner --- Haendelstrasse 17 --- 4020 Linz --- Austria
.......It might be written "Mindfuck", but it's spelt "L-A-I-N".......

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2366654

Michael Corr

unread,
Jul 1, 2009, 5:20:40 AM7/1/09
to us...@tortoisesvn.tigris.org
Ahh. Ok. I see that there are two separate dialog windows, now. So, the second window can be automatically closed, but not the first.

Doesn't really seem to be worth the effort of offering an auto dialog close at all, if you still have to manually close the first window. I don't see the point in offering any automated steps if you don't offer complete automation.

I've done plenty of windows programming - it shouldn't be too hard to grab a handle to the first commit dialog window and automatically press the 'ok' button once the list of commits fills in.

I guess I'm still confused as to why the /closeonend option is even offered - if it doesn't fully automate - and from reading through some other posts, you seem to be strongly suggesting to users to use a command line svn client for automation.

I use Tortoise because I really like the user interface and the ease of immediate visibility to see the status of all my files. It would be nice to continue to just use Tortoise for all my needs, and not have to support two separate tools.

Thanks for the prompt replies.

Michael

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2366974

Andy Levy

unread,
Jul 1, 2009, 5:59:45 AM7/1/09
to us...@tortoisesvn.tigris.org
On Wed, Jul 1, 2009 at 05:20, Michael Corr<mic...@aduratech.com> wrote:
> Ahh. Ok. I see that there are two separate dialog windows, now. So, the second window can be automatically closed, but not the first.
>
> Doesn't really seem to be worth the effort of offering an auto dialog close at all, if you still have to manually close the first window. I don't see the point in offering any automated steps if you don't offer complete automation.
>
> I've done plenty of windows programming - it shouldn't be too hard to grab a handle to the first commit dialog window and automatically press the 'ok' button once the list of commits fills in.

OK, so code it up & submit a patch, if you feel that strongly about it.

> I guess I'm still confused as to why the /closeonend option is even offered - if it doesn't fully automate - and from reading through some other posts, you seem to be strongly suggesting to users to use a command line svn client for automation.

The CLI client is *designed* to be built into scripts. People suggest
that you use it for automation because it's meant to be used that way.
Tortoise is a GUI client, with /some/ command-line abilities provided.
But GUI apps as a rule rarely lend themselves to non-GUI automation.

> I use Tortoise because I really like the user interface and the ease of immediate visibility to see the status of all my files. It would be nice to continue to just use Tortoise for all my needs, and not have to support two separate tools.

You'd be horrified at my workstation then; I have 4 separate SVN
clients, and use them all.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2366985

Simon Large

unread,
Jul 1, 2009, 9:03:50 AM7/1/09
to us...@tortoisesvn.tigris.org
2009/7/1 Michael Corr <mic...@aduratech.com>:

> Ahh. Ok. I see that there are two separate dialog windows, now. So, the second window can be automatically closed, but not the first.
>
> Doesn't really seem to be worth the effort of offering an auto dialog close at all, if you still have to manually close the first window. I don't see the point in offering any automated steps if you don't offer complete automation.

The first dialog is the one where you choose what to commit and write
a message. Since this is the whole point if a GUI app there seems no
point in bypassing this. If you don't need any GUI input then script
with a command line program.

The second dialog is a simple progress/status dialog which you have to
click through at the end. Since many people don't like click throughs
there are options to close it automatically if nothing untoward has
happened.

> I've done plenty of windows programming - it shouldn't be too hard to grab a handle to the first commit dialog window and automatically press the 'ok' button once the list of commits fills in.
>
> I guess I'm still confused as to why the /closeonend option is even offered - if it doesn't fully automate - and from reading through some other posts, you seem to be strongly suggesting to users to use a command line svn client for automation.

For full automation without any user input then yes, the svn client is
the one to use. For partial automation where the initial setup is
automated and the user has to make the final selections then a GUI app
is appropriate.

> I use Tortoise because I really like the user interface and the ease of immediate visibility to see the status of all my files. It would be nice to continue to just use Tortoise for all my needs, and not have to support two separate tools.
>

Nice for you, but a load of work for the developers of TSVN and a lot
more maintenance, and all so that you can avoid installing another
program?

Simon

--
: ___
: oo // \\ "De Chelonian Mobile"
: (_,\/ \_/ \ TortoiseSVN
: \ \_/_\_/> The coolest Interface to (Sub)Version Control
: /_/ \_\ http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2367035

Michael Corr

unread,
Jul 2, 2009, 11:38:06 AM7/2/09
to us...@tortoisesvn.tigris.org
All,
I seemed to have started a little heated debate. That was not my intention. I am a big fan of TortoiseSVN - I've been using it for years, and have even introduced it to all the developers in my office, so everyone now uses it.

I was poking around at some of the advanced features recently, and was simply trying to understand some of the design decisions, and wanted to make sure I was using the features correctly.

The tortoiseproc command allows for 95% automation, including auto message entry from the command line for committing. Since the /closeonend feature allows for auto close of the progress dialog, I was just trying to understand why it didn't have an option to auto close the first dialog, too. Perhaps a separate "/closecommit" parameter?

If it is not the intention to offer this capability in Tortoise - then that's fine. I just wanted to make sure I was using the available features correctly.

I'm happy to install cygwin and a CLI svn client on my Windows machine. I simply wanted to make sure I was utilizing my current tools to their full potential before adding new ones.

thanks
Michael

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2367405

Andy Levy

unread,
Jul 2, 2009, 1:24:21 PM7/2/09
to us...@tortoisesvn.tigris.org
On Thu, Jul 2, 2009 at 11:38, Michael Corr<mic...@aduratech.com> wrote:

> I'm happy to install cygwin and a CLI svn client on my Windows machine. I simply wanted to make sure I was utilizing my current tools to their full potential before adding new ones.

Cygwin isn't a good idea here. There's a native Win32 client that
works perfectly fine. Cygwin, nowadays, is really not needed in 90% of
the cases where it's used. If you use it with Subversion, then you'll
have a Subversion client running on Windows, but pretending it's on
*NIX, so any files with svn:eol-style set to native will get UNIX EOL
markers, not Windows.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2367516

Jean-Marc van Leerdam

unread,
Jul 2, 2009, 3:37:47 PM7/2/09
to us...@tortoisesvn.tigris.org
Hi,

2009/7/2 Andy Levy <andy...@gmail.com>:


> On Thu, Jul 2, 2009 at 11:38, Michael Corr<mic...@aduratech.com> wrote:
>
>> I'm happy to install cygwin and a CLI svn client on my Windows machine. I simply wanted to make sure I was utilizing my current tools to their full potential before adding new ones.
>
> Cygwin isn't a good idea here. There's a native Win32 client that
> works perfectly fine. Cygwin, nowadays, is really not needed in 90% of
> the cases where it's used. If you use it with Subversion, then you'll
> have a Subversion client running on Windows, but pretending it's on
> *NIX, so any files with svn:eol-style set to native will get UNIX EOL
> markers, not Windows.
>

IIRC it is even worse: there is no guarantee that working copy formats
between *NIX and Windows are compatible. Using mixed platform clients
on the same working copy is asking for trouble.

--
Regards,

Jean-Marc
--
. ___
. @@ // \\ "De Chelonian Mobile"
. (_,\/ \_/ \ TortoiseSVN

. \ \_/_\_/> The coolest Interface to (Sub)Version Control
. /_/ \_\ http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2367571

Michael Corr

unread,
Jul 4, 2009, 4:07:34 AM7/4/09
to us...@tortoisesvn.tigris.org
>
> Cygwin isn't a good idea here. There's a native Win32 client that
> works perfectly fine.

Hmm. What's the name of it? I did a Google search and found several products. Do you recommend any?

thanks
Michael

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2367950

Stefan Küng

unread,
Jul 4, 2009, 4:18:51 AM7/4/09
to us...@tortoisesvn.tigris.org
Michael Corr wrote:
>> Cygwin isn't a good idea here. There's a native Win32 client that
>> works perfectly fine.
>
> Hmm. What's the name of it? I did a Google search and found several products. Do you recommend any?

http://subversion.tigris.org/getting.html#windows

Stefan

--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN

\ \_/_\_/> The coolest Interface to (Sub)Version Control

/_/ \_\ http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2367952

signature.asc
Reply all
Reply to author
Forward
0 new messages