Issue Tracker Plugin and bugtraq:warnifnoissue

[David Henderson]

Hi,

 

I’m currently in the process of writing an issue tracker plugin for FogBugz in C#.

 

When testing on our local repository, the plugin executes fine and returns the correct string (e.g. “BugzID: 81725”).

 

However, when I hit OK, I receive the “You haven’t entered an issue number” warning.

 

From a quick look through of the source yesterday (I can’t access it right now due to the tigris.org upgrades), it looks like the check for an issue number only takes Regex mode into account.

 

The properties I have set in my working copy are as follows:

 

bugtraq:label                 Case:

bugtraq:message           BugzID: %BUGID%

bugtraq:number             true

bugtraq:warnifnoissue    true

 

I only have the bugtraq:message property set so that my users that do not wish to use the fogbugz plugin still retain the issue number input area at the top.

 

Is this an issue that I can solve locally, or will it need work doing to the commit dialog (say adding a flag that gets set when an issue tracker plugin returns)?

 

Thanks,

 

David Henderson

[Stefan Kueng]

Unfortunately, the issue tracker plugins only work together with the
regex properties.
But you're right, it should also recognize non-regex based issue ids and
fill those in automatically.
I'll change that for the 1.6 release.

Stefan

--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=598128

To unsubscribe from this discussion, e-mail: [users-un...@tortoisesvn.tigris.org].

[Stefan Kueng]

On Tue, Dec 2, 2008 at 18:24, Stefan Küng <torto...@gmail.com> wrote:
> Unfortunately, the issue tracker plugins only work together with the
> regex properties.
> But you're right, it should also recognize non-regex based issue ids and
> fill those in automatically.
> I'll change that for the 1.6 release.

Done in r14752.

Stefan

--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=860888

[David Henderson]

Thanks Stefan,

On a related note, I've had some feedback that it'd be useful to retain
the issue textbox as well as having the "Choose Issue" button. Their
reasoning is that if they know the issue number, it is a lot quicker to
enter it directly than to load an extra dialog.

Would this be feasible?

I could see it working in such a way that the results from the issue
tracker plugin (probably a comma separated list of issue IDs) were
inserted into the issue box rather than the message box.
If regex based issue ids were in use, the results from the plugin would
be passed into the message body as they currently are.

Thanks,

David Henderson

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=978772

[Stefan Kueng]

David Henderson wrote:
> Thanks Stefan,
>
> On a related note, I've had some feedback that it'd be useful to retain
> the issue textbox as well as having the "Choose Issue" button. Their
> reasoning is that if they know the issue number, it is a lot quicker to
> enter it directly than to load an extra dialog.
>
> Would this be feasible?
>
> I could see it working in such a way that the results from the issue
> tracker plugin (probably a comma separated list of issue IDs) were
> inserted into the issue box rather than the message box.
> If regex based issue ids were in use, the results from the plugin would
> be passed into the message body as they currently are.

Done in r14768.

Stefan

--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=979021

[David Henderson]

Stefan Kueng wrote:

> Done in r14768.

Thanks Stefan,

I've tried it out in the nightly build and its spot on.

Regards,

David Henderson

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=979331

[David Henderson]

Hi Stefan,

I've just found a small bug in the issue tracker implementation (that
you did some work on in early December):

To reproduce (using yesterday's nightly build):

1) Do 1 commit with a BugzID using the issue tracker plug-in.
2) Open the commit dialog for a second commit
3) Click the recent messages button and select the previous message.
The Issue box will be filled with the value from the previous entry.
4) Click OK. The message "Only Numbers (optionally separated by commas)
are allowed!" will be shown in a tooltip.

There are no characters before or after the number in the box. To
complete the commit, you need to make a change within the issue # box.

Regards,

David Henderson

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1007682

[Stefan Kueng]

David Henderson wrote:
> Hi Stefan,
>
> I've just found a small bug in the issue tracker implementation (that
> you did some work on in early December):
>
> To reproduce (using yesterday's nightly build):
>
> 1) Do 1 commit with a BugzID using the issue tracker plug-in.
> 2) Open the commit dialog for a second commit
> 3) Click the recent messages button and select the previous message.
> The Issue box will be filled with the value from the previous entry.
> 4) Click OK. The message "Only Numbers (optionally separated by commas)
> are allowed!" will be shown in a tooltip.
>
> There are no characters before or after the number in the box. To
> complete the commit, you need to make a change within the issue # box.

Strange. I can't reproduce this.
Also, the code responsible for the check gets the text from the edit box
directly, not from a variable:

CString id;
GetDlgItemText(IDC_BUGID, id);
if (!m_ProjectProperties.CheckBugID(id))
{
ShowBalloon(IDC_BUGID, IDS_COMMITDLG_ONLYNUMBERS, IDI_EXCLAMATION);
return;
}

which means that if the text is shown in the issue # box, it will be
used and it should not be necessary to edit the text in there first.

Stefan

--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1008166

[David Henderson]

> Strange. I can't reproduce this.
> Also, the code responsible for the check gets the text from the edit
box
> directly, not from a variable:
>
> CString id;
> GetDlgItemText(IDC_BUGID, id);
> if (!m_ProjectProperties.CheckBugID(id))
> {
> ShowBalloon(IDC_BUGID, IDS_COMMITDLG_ONLYNUMBERS,
>IDI_EXCLAMATION);
> return;
> }
>
> which means that if the text is shown in the issue # box, it will be
> used and it should not be necessary to edit the text in there first.

>Stefan

Hi Stefan, I've just tired again, I've narrowed it down to what looks
like extra line breaks at the end of the BuzId string.

Thanks,

David Henderson

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1011499

[David Henderson]

Stefan,

I saw that you'd added the Trim() before the check was carried out, so I
tried out last night's build - it works fine now - thanks!

David Henderson

-----Original Message-----
From: David Henderson [mailto:dhend...@smartFOCUS.com]
Sent: 08 January 2009 11:48
To: us...@tortoisesvn.tigris.org
Subject: RE: Issue Tracker Plugin and Recent Messages

> Strange. I can't reproduce this.
> Also, the code responsible for the check gets the text from the edit
box
> directly, not from a variable:
>
> CString id;
> GetDlgItemText(IDC_BUGID, id);
> if (!m_ProjectProperties.CheckBugID(id))
> {
> ShowBalloon(IDC_BUGID, IDS_COMMITDLG_ONLYNUMBERS,
>IDI_EXCLAMATION);
> return;
> }
>
> which means that if the text is shown in the issue # box, it will be
> used and it should not be necessary to edit the text in there first.

>Stefan

Hi Stefan, I've just tired again, I've narrowed it down to what looks
like extra line breaks at the end of the BuzId string.

Thanks,

David Henderson

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1011780