Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
tog_users
Home
About this group
Apply for group membership
even transition name for publishing a post should be publish!
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   8 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Balint Erdi  
View profile  
 More options Feb 25 2009, 9:28 am
From: Balint Erdi <balint.e...@gmail.com>
Date: Wed, 25 Feb 2009 06:28:00 -0800 (PST)
Subject: [tog_conversatio] even transition name for publishing a post should be publish!
Print | Individual message | Show original | Report this message | Find messages by this author
Hi,

In post.rb de tog_conversatio, there is the following snippet:

  event :published do
    transitions :from => [:draft] , :to => :published
  end

Event names IMO should be verbs whenever possible even more so since
as it is now I have to do:

post.published!

to make a post published (which should be post.publish!)

So the code snippet should be replaced by:

 event :publish do
    transitions :from => [:draft] , :to => :published
  end

What do you think?
Balint


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "[tog_conversatio] even transition name for publishing a post should be publish!" by Alberto Molpeceres
Alberto Molpeceres  
View profile  
 More options Feb 25 2009, 9:49 am
From: Alberto Molpeceres <alberto.molpece...@gmail.com>
Date: Wed, 25 Feb 2009 15:49:56 +0100
Local: Wed, Feb 25 2009 9:49 am
Subject: Re: [tog] [tog_conversatio] even transition name for publishing a post should be publish!
Print | Individual message | Show original | Report this message | Find messages by this author

> What do you think?
> Balint

Sure!. I'm sure Roberto will be happy if you for the repo in github
and send him a pull request XD.

   al.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "even transition name for publishing a post should be publish!" by Balint Erdi
Balint Erdi  
View profile  
 More options Feb 26 2009, 4:24 am
From: Balint Erdi <balint.e...@gmail.com>
Date: Thu, 26 Feb 2009 01:24:58 -0800 (PST)
Local: Thurs, Feb 26 2009 4:24 am
Subject: Re: [tog_conversatio] even transition name for publishing a post should be publish!
Print | Individual message | Show original | Report this message | Find messages by this author
I have done just that, sending the pull req. to the tog user.

On a side note, I could not run the tests of tog_conversation neither
in "standalone" mode nor when plugged in to a host application. That
latter presented me with an unpleasant:

/Users/balint/code/rails/host_for_tog_conversatio/vendor/plugins/
tog_conversatio/init.rb:1:in `evaluate_init_rb': undefined method
`require_plugin' for #<Rails::Plugin:0x21ba9ac> (NoMethodError) (I
have not found require_plugin in the Rails 2.2.2 source anywhere)

Is this a known issue?
Balint

On Feb 25, 3:49 pm, Alberto Molpeceres <alberto.molpece...@gmail.com>
wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "[tog_conversatio] even transition name for publishing a post should be publish!" by Aitor Garcia Rey
Aitor Garcia Rey  
View profile  
 More options Feb 26 2009, 4:37 am
From: Aitor Garcia Rey <aitor.gar...@gmail.com>
Date: Thu, 26 Feb 2009 10:37:38 +0100
Local: Thurs, Feb 26 2009 4:37 am
Subject: Re: [tog] Re: [tog_conversatio] even transition name for publishing a post should be publish!
Print | Individual message | Show original | Report this message | Find messages by this author
This is defined in tog-desert... Do the app starts correctly?

--
Kind Regards,
Aitor Garcia
Cofounder - Linking Paths
http://www.linkingpaths.com

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "even transition name for publishing a post should be publish!" by Balint Erdi
Balint Erdi  
View profile  
 More options Feb 26 2009, 10:53 am
From: Balint Erdi <balint.e...@gmail.com>
Date: Thu, 26 Feb 2009 07:53:01 -0800 (PST)
Local: Thurs, Feb 26 2009 10:53 am
Subject: Re: [tog_conversatio] even transition name for publishing a post should be publish!
Print | Individual message | Show original | Report this message | Find messages by this author
Thank you, so the tests should be run inside a "tog-enabled" rails
app, is that it?

I tried that (standing in /vendor/plugins/tog_conversatio I did: rake
test) and it worked, the tests were run but there were quite some
errors so I would not be able to see if my simple change works as it
should.

Balint

ps. A sample error:

test: A Post should find one result. (PostTest):
ActiveRecord::RecordInvalid: Validation failed: Summary no puede estar
en blanco

On Feb 26, 10:37 am, Aitor Garcia Rey <aitor.gar...@gmail.com> wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "[tog_conversatio] even transition name for publishing a post should be publish!" by Alberto Molpeceres
Alberto Molpeceres  
View profile  
 More options Feb 26 2009, 11:36 am
From: Alberto Molpeceres <alberto.molpece...@gmail.com>
Date: Thu, 26 Feb 2009 17:36:07 +0100
Local: Thurs, Feb 26 2009 11:36 am
Subject: Re: [tog] Re: [tog_conversatio] even transition name for publishing a post should be publish!
Print | Individual message | Show original | Report this message | Find messages by this author
Yeah, tog-enabled app would be nice XD.

Then you can run the test for a given plugin with:

rake tog:plugins:test PLUGIN=plugin_name

(http://wiki.github.com/tog/tog/developer-faq#run_plugin_tests)


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "even transition name for publishing a post should be publish!" by Balint Erdi
Balint Erdi  
View profile  
 More options Feb 27 2009, 5:04 am
From: Balint Erdi <balint.e...@gmail.com>
Date: Fri, 27 Feb 2009 02:04:38 -0800 (PST)
Local: Fri, Feb 27 2009 5:04 am
Subject: Re: [tog_conversatio] even transition name for publishing a post should be publish!
Print | Individual message | Show original | Report this message | Find messages by this author
I did it like this and it gives lots of errors as I describe above.

Balint

On Feb 26, 5:36 pm, Alberto Molpeceres <alberto.molpece...@gmail.com>
wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "[tog_conversatio] even transition name for publishing a post should be publish!" by Alberto Molpeceres
Alberto Molpeceres  
View profile  
 More options Feb 27 2009, 5:13 am
From: Alberto Molpeceres <alberto.molpece...@gmail.com>
Date: Fri, 27 Feb 2009 11:13:40 +0100
Local: Fri, Feb 27 2009 5:13 am
Subject: Re: [tog] Re: [tog_conversatio] even transition name for publishing a post should be publish!
Print | Individual message | Show original | Report this message | Find messages by this author
Balint,

Ough, I didn't read your mail properly XD. This is a known issue that
we don't know/we haven't decide how to solve yet.

You are testing this plugin in a project that extends conversatio
(field 'summary' isn't part of conversatio), and this field is
declared as mandatory in your project. The factory used by
tog_conversatio's test doesn't set this field, so any try to
instantiate a Post fails, so every test using a Post fails.

Any Idea about solving this is welcomed!.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google