"fields" param in store.saveTiddler() is mutable

[Michael Mahemoff]

I'm not sure if this is a problem or not, but it caused some pain for
me recently. If i call store.saveTiddler(), specifying a value for the
fields map paameter, the value is assigned directly rather than being
cloned.

i.e.:
var fields = { hot: true };
var tid = store.saveTiddler(......., fields, ......);
tid.hot = false; // now fields.hot is false too

This bit me when I passed in config.defaultCustomFields; it turned out
TiddlyWebAdaptor was setting "server.title" on each tiddler, and this
was magically appearing on config.defaultCustomFields (where it would
be applied to subsequent tiddlers).

I am thinking it would be nice if the fields argument was cloned by
store.saveTiddler(). Interested in others' thoughts on that.

[FND]

> If i call store.saveTiddler(), specifying a value for the
> fields map paameter, the value is assigned directly rather than being
> cloned.

This does sound like something that should be addressed. Can you raise a
ticket (just set the milestone to 2.6 for now, referencing this thread)?

-- F.

[Michael Mahemoff]

That's done, thanks.