Gmail Calendar Documents Reader Web more »
Recently Visited Groups | Help | Sign in
Google Groups Home
Heads up: Apple store rejection for apps using three20
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  Messages 1 - 25 of 121 - Collapse all  -  Translate all to Translated (View all originals)   Newer >
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Pradeepta Dash  
View profile  
 More options Oct 26, 6:20 pm
From: Pradeepta Dash <pradee...@gmail.com>
Date: Mon, 26 Oct 2009 15:20:53 -0700
Local: Mon, Oct 26 2009 6:20 pm
Subject: Heads up: Apple store rejection for apps using three20

Apologies if this has been reported earlier.

An app of mine got rejected because three20 uses private API/ivars.

- UITouch._locationInWindow
- UITouch._phase
- UITouch._previousLocationInWindow
- UITouch._tapCount
- UITouch._timestamp
- UITouch._touchFlags
- UITouch._view
- UITouch._window

--pradeepta


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mads Rasmussen  
View profile  
 More options Oct 26, 6:27 pm
From: Mads Rasmussen <rasmussen.m...@gmail.com>
Date: Mon, 26 Oct 2009 20:27:25 -0200
Local: Mon, Oct 26 2009 6:27 pm
Subject: Re: Heads up: Apple store rejection for apps using three20

That's bad !!

Any workarounds? are the use of these private APIs isolated or used in all
classes?

Mads

--
Mads Rasmussen
Creative-Apps
Chief Technology Officer
------------------------------------------
mads.rasmus...@creative-apps.com
www.creative-apps.com
Mobile: 55 11 7533-6292
Mobile: 55 11 9407-4493
Skype: rasmussen.brazil2
@mazebr

    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Pradeepta Dash  
View profile  
 More options Oct 26, 6:38 pm
From: Pradeepta Dash <pradee...@gmail.com>
Date: Mon, 26 Oct 2009 15:38:15 -0700
Local: Mon, Oct 26 2009 6:38 pm
Subject: Re: Heads up: Apple store rejection for apps using three20

To be fair the source code in three20 calls it out

"/**

 * WARNING: This depends on undocumented APIs and may be fragile.  For
testing only.

 */

"

From UIViewAdditions, I am going to remove

a) - (void)simulateTapAtPoint:(CGPoint)location
b) UITouch (TTCategory)

That *should* be enough.

I will let everyone know how that works out.

--pradeepta

On Mon, Oct 26, 2009 at 3:27 PM, Mads Rasmussen <rasmussen.m...@gmail.com>wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
uprise78  
View profile  
 More options Oct 26, 6:38 pm
From: uprise78 <des...@gmail.com>
Date: Mon, 26 Oct 2009 15:38:35 -0700 (PDT)
Local: Mon, Oct 26 2009 6:38 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
Ummmm....those arent private.  They are listed right in the UITouch
docs:

http://developer.apple.com/iphone/library/documentation/UIKit/Referen...

What you may be referring to is the simulateTapAtPoint: method and the
UITouch/UIEvent categories.  Just remove the simulateTapAtPoint:
method and everything it references which is just the  UITouch
(TTCategory) and UIEvent (TTCategory). You can get extra efficient and
remove the UIEventFake class.


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Pradeepta Dash  
View profile  
 More options Oct 26, 6:47 pm
From: Pradeepta Dash <pradee...@gmail.com>
Date: Mon, 26 Oct 2009 15:47:14 -0700
Local: Mon, Oct 26 2009 6:47 pm
Subject: Re: Heads up: Apple store rejection for apps using three20

Here is the code :
http://github.com/joehewitt/three20/blob/master/src/UIViewAdditions.m

@implementation UITouch (TTCategory)

- (id)initInView:(UIView *)view location:(CGPoint)location {
  if (self = [super init]) {
    _tapCount = 1; <= BAD
    _locationInWindow = location; <= BAD
    _previousLocationInWindow = location; <= BAD

    UIView *target = [view.window hitTest:_locationInWindow withEvent:nil];
    _view = [target retain]; <= BAD
    _window = [view.window retain]; <= BAD
    _phase = UITouchPhaseBegan; <= BAD
    _touchFlags._firstTouchForView = 1; <= BAD
    _touchFlags._isTap = 1; <= BAD
    _timestamp = [NSDate timeIntervalSinceReferenceDate]; <= BAD
  }
  return self;

}

- (void)changeToPhase:(UITouchPhase)phase {
  _phase = phase; <= BAD
  _timestamp = [NSDate timeIntervalSinceReferenceDate]; <= BAD

}

@end


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Matt Vague  
View profile  
 More options Oct 26, 8:32 pm
From: Matt Vague <mattva...@gmail.com>
Date: Mon, 26 Oct 2009 17:32:06 -0700 (PDT)
Local: Mon, Oct 26 2009 8:32 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
So were supposed to remove this from three20??

On Oct 26, 3:47 pm, Pradeepta Dash <pradee...@gmail.com> wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
uprise78  
View profile  
 More options Oct 26, 10:51 pm
From: uprise78 <des...@gmail.com>
Date: Mon, 26 Oct 2009 19:51:50 -0700 (PDT)
Local: Mon, Oct 26 2009 10:51 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
To be safe, you probably should.  That being said, I have a few apps
in the app store that have that code in them.  It just depends on your
luck with the Apple employee who does your review.

On Oct 26, 5:32 pm, Matt Vague <mattva...@gmail.com> wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
neptune2000  
View profile  
 More options Oct 27, 11:58 am
From: neptune2000 <papa.ma...@gmail.com>
Date: Tue, 27 Oct 2009 08:58:36 -0700 (PDT)
Local: Tues, Oct 27 2009 11:58 am
Subject: Re: Heads up: Apple store rejection for apps using three20
Can anyone else confirm rejection?

On Oct 26, 3:20 pm, Pradeepta Dash <pradee...@gmail.com> wrote:


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
neptune2000  
View profile  
 More options Oct 27, 12:01 pm
From: neptune2000 <papa.ma...@gmail.com>
Date: Tue, 27 Oct 2009 09:01:02 -0700 (PDT)
Local: Tues, Oct 27 2009 12:01 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
Can anyone give a list of "safe" changes that are going to satisfy the
requirement and not break everything?

Notice that three20 is included in the Facebook app.

On Oct 26, 7:51 pm, uprise78 <des...@gmail.com> wrote:


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jonathan Saggau  
View profile  
 More options Oct 27, 12:10 pm
From: Jonathan Saggau <sag...@gmail.com>
Date: Tue, 27 Oct 2009 12:10:10 -0400
Local: Tues, Oct 27 2009 12:10 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
Is it perhaps time for a #define APP_STORE_SAFE  ?  :)

On 10/27/09 12:01 PM, neptune2000 wrote:


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mike D  
View profile  
 More options Oct 27, 12:16 pm
From: Mike D <des...@gmail.com>
Date: Tue, 27 Oct 2009 09:16:07 -0700
Local: Tues, Oct 27 2009 12:16 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
Safe changes are listed below in one of my previous replies.


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Nazar  
View profile  
 More options Oct 27, 12:55 pm
From: Nazar <niva...@gmail.com>
Date: Tue, 27 Oct 2009 09:55:26 -0700 (PDT)
Local: Tues, Oct 27 2009 12:55 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
Thanks for the heads up, Pradeepta

    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
neptune2000  
View profile  
 More options Oct 27, 1:43 pm
From: neptune2000 <papa.ma...@gmail.com>
Date: Tue, 27 Oct 2009 10:43:18 -0700 (PDT)
Local: Tues, Oct 27 2009 1:43 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
What about the call to simulateTapAtPoint in UIWebViewAdditions.m ?

On Oct 26, 3:38 pm, uprise78 <des...@gmail.com> wrote:


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mike D  
View profile  
 More options Oct 27, 1:46 pm
From: Mike D <des...@gmail.com>
Date: Tue, 27 Oct 2009 10:46:10 -0700
Local: Tues, Oct 27 2009 1:46 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
you will need to remove that as well or your project wont compile.


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
neptune2000  
View profile  
 More options Oct 27, 3:56 pm
From: neptune2000 <papa.ma...@gmail.com>
Date: Tue, 27 Oct 2009 12:56:35 -0700 (PDT)
Local: Tues, Oct 27 2009 3:56 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
I get that, but removing the call is going to pretty much break the
function that uses it.

On Oct 27, 10:46 am, Mike D <des...@gmail.com> wrote:


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mike D  
View profile  
 More options Oct 27, 4:48 pm
From: Mike D <des...@gmail.com>
Date: Tue, 27 Oct 2009 13:48:18 -0700
Local: Tues, Oct 27 2009 4:48 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
Nothing in three20 uses it.  As long as you arent using it then it
won't hurt anything.


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
neptune2000  
View profile  
 More options Oct 27, 6:08 pm
From: neptune2000 <papa.ma...@gmail.com>
Date: Tue, 27 Oct 2009 15:08:06 -0700 (PDT)
Local: Tues, Oct 27 2009 6:08 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
That's good. So if I remove

- (void) simulateTapAtPoint:(CGPoint_ location

- (id)initInView:(UIView *)view location:(CGPoint)location {

- (void)changeToPhase:(UITouchPhase)phase {

- (void)simulateTopElement:(NSString*) query {

I should not be getting any compilation errors, right?

I guess it is time to try.

On Oct 27, 1:48 pm, Mike D <des...@gmail.com> wrote:


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
neptune2000  
View profile  
 More options Oct 27, 6:21 pm
From: neptune2000 <papa.ma...@gmail.com>
Date: Tue, 27 Oct 2009 15:21:30 -0700 (PDT)
Local: Tues, Oct 27 2009 6:21 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
That seems to do it. No compilation errors.

On Oct 27, 3:08 pm, neptune2000 <papa.ma...@gmail.com> wrote:


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Nick Partridge  
View profile  
 More options Oct 28, 9:02 pm
From: Nick Partridge <nkp...@gmail.com>
Date: Thu, 29 Oct 2009 11:02:23 +1000
Local: Wed, Oct 28 2009 9:02 pm
Subject: Re: Heads up: Apple store rejection for apps using three20

Related to this rejection, I just had an app rejected with the following
feedback:

> The non-public APIs that are included in your applications are the
> following:
> - firstResponder
> - undocumented, Private UITouch instance variables

I'm going to assume that the UITouch instance variables is the same issue as
Pradeepta's, however the firstResponder problem is troubling.

That selector is used whenever Three20 (or otherwise) needs to know if the
keyboard is visible, or to scroll the first responder into the view. I'll
have to strip all that functionality out of three20 to use it.

A greater concern though, is that Three20 is using private APIs without
flagging it to the consumer of the library. As much as I find three20 to be
a great productivity to boost to working with cocoa, we're going to be
phasing it out of our applications.

-Nick


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
taco  
View profile  
 More options Oct 28, 9:49 pm
From: taco <wee...@gmail.com>
Date: Wed, 28 Oct 2009 18:49:39 -0700 (PDT)
Local: Wed, Oct 28 2009 9:49 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
Ouch.

I've just started adopting Three20. Abandon ship?

On Oct 28, 9:02 pm, Nick Partridge <nkp...@gmail.com> wrote:


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mike D  
View profile  
 More options Oct 28, 9:51 pm
From: Mike D <des...@gmail.com>
Date: Wed, 28 Oct 2009 18:51:15 -0700
Local: Wed, Oct 28 2009 9:51 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
I sure wouldn't abandon ship.  TTStyle alone is more than enough
reason to keep using it let alone all the other built in goodies.


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Pradeepta Dash  
View profile  
 More options Oct 28, 9:53 pm
From: Pradeepta Dash <pradee...@gmail.com>
Date: Wed, 28 Oct 2009 18:53:26 -0700
Local: Wed, Oct 28 2009 9:53 pm
Subject: Re: Heads up: Apple store rejection for apps using three20

I got rejected for the 2nd reason, exact same verbage.

However, I took out the all calls to firstResponder as well and re-submitted
the app just now (just to safe)

Thanks for the heads up.
--pradeepta


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Lyndsay Hackett  
View profile  
 More options Oct 28, 10:13 pm
From: Lyndsay Hackett <lyndsay.hack...@gmail.com>
Date: Wed, 28 Oct 2009 19:13:28 -0700 (PDT)
Local: Wed, Oct 28 2009 10:13 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
Pradeepta & Nick, were the calls ones that you'd made inside your own
code or were they calls that are made in the Three20 libraries? In
other words, will just having the library in your app trigger a
possible rejection or do you need to make those calls yourself to
trigger the rejection?

Thanks

Lyndsay

On Oct 28, 6:53 pm, Pradeepta Dash <pradee...@gmail.com> wrote:


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
siong1987  
View profile  
 More options Oct 28, 10:24 pm
From: siong1987 <siong1...@gmail.com>
Date: Wed, 28 Oct 2009 19:24:06 -0700 (PDT)
Local: Wed, Oct 28 2009 10:24 pm
Subject: Re: Heads up: Apple store rejection for apps using three20
Hi Pradeepta,

Is it possible for you to fork a branch on github to share your SAFE
three20 library with us?

Thank you.

On Oct 28, 6:53 pm, Pradeepta Dash <pradee...@gmail.com> wrote:


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Nick Partridge  
View profile  
 More options Oct 28, 11:25 pm
From: Nick Partridge <nkp...@gmail.com>
Date: Thu, 29 Oct 2009 13:25:45 +1000
Local: Wed, Oct 28 2009 11:25 pm
Subject: Re: Heads up: Apple store rejection for apps using three20

For firstResponder, any TTViewController that has a keyboard displayed
within it will call the private selector. Given this is the base for every
view controller in three20... :-s . We are definitely calling this code.

However, I'm confident we're not using the code that accesses the UITouch
private variables and yet they have included that in the rejection notice. I
suspect they're using static analysis to find the usages and that just
having the code within your project will be enough for a rejection.

-Nick
On Thu, Oct 29, 2009 at 12:13 PM, Lyndsay Hackett <lyndsay.hack...@gmail.com


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Messages 1 - 25 of 121   Newer >
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2009 Google