Received: by 10.52.75.42 with SMTP id z10mr1684835vdv.0.1344117790410;
        Sat, 04 Aug 2012 15:03:10 -0700 (PDT)
X-BeenThere: thecodeshop@googlegroups.com
Received: by 10.220.223.77 with SMTP id ij13ls3975645vcb.1.gmail; Sat, 04 Aug
 2012 15:03:10 -0700 (PDT)
Received: by 10.58.117.41 with SMTP id kb9mr1882450veb.27.1344117790023;
        Sat, 04 Aug 2012 15:03:10 -0700 (PDT)
Received: by 10.58.117.41 with SMTP id kb9mr1882449veb.27.1344117790011;
        Sat, 04 Aug 2012 15:03:10 -0700 (PDT)
Return-Path: <luislav...@gmail.com>
Received: from mail-vc0-f176.google.com (mail-vc0-f176.google.com [209.85.220.176])
        by gmr-mx.google.com with ESMTPS id c10si1079825vdu.1.2012.08.04.15.03.10
        (version=TLSv1/SSLv3 cipher=OTHER);
        Sat, 04 Aug 2012 15:03:10 -0700 (PDT)
Received-SPF: pass (google.com: domain of luislav...@gmail.com designates 209.85.220.176 as permitted sender) client-ip=209.85.220.176;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of luislav...@gmail.com designates 209.85.220.176 as permitted sender) smtp.mail=luislav...@gmail.com; dkim=pass header...@gmail.com
Received: by vcbfl11 with SMTP id fl11so2247422vcb.35
        for <thecodeshop@googlegroups.com>; Sat, 04 Aug 2012 15:03:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type:content-transfer-encoding;
        bh=xPLxtduhr+g4+uWPeFvSkKsmom6YKojx1EkgTbQqXjo=;
        b=s2NmWbpbvYk9LIY7PTT7IoIfqNXYP7SfLksTu6YssBhW14QKjjwTzHCmoUUbL/BKh4
         RfhRQ/8AkPjcdlMaTn1LmgVjZsqflQloZf091AnMXIh5mKVWMHF6VWyLstkH9CEmDjDi
         tZCdVjisQ0eZk4YFBNZCjFtIkfqb+82jHlQIikKrMYxFynV9qD+0Zw3dvbJbhsCmEJhq
         tQDekFJGBSZ6X1c5w4YSfaozcpVs29wakkiuSsMfoSKXezx2E57MZDWbMdcrIL/RuysH
         H3GrwZZHVpgYQQo2JzukPg1CpDaA+oz6+UECLJlSKbMvph0b6or7obradN6qfab+dR/J
         FISQ==
Received: by 10.52.66.162 with SMTP id g2mr4053688vdt.32.1344117789841; Sat,
 04 Aug 2012 15:03:09 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.52.28.35 with HTTP; Sat, 4 Aug 2012 15:02:49 -0700 (PDT)
In-Reply-To: <20120803183923.33f911644123d182ebad3...@gmail.com>
References: <72de20e0-3d2c-4e81-9366-e2faab49e...@h12g2000yqg.googlegroups.com>
 <2224a58b-6991-4771-9675-38f9dd967113@googlegroups.com> <CAOWZXk0RJgr1ciKCKX=Sdd=vmOyTFApJq9S8QmuDy3ybo0W...@mail.gmail.com>
 <CAN_J9asO-iKA=0P87Gr_hE85exXrTpR=W3_7OrPH6bE+kto...@mail.gmail.com>
 <CAOWZXk1ijZEBXtJjBZSkzrWRdjXYngv4QfpuTNYvXF2z_Pk...@mail.gmail.com>
 <CAN_J9asnOMKFiDKVkdwB5=A7eeApwJAZPE9a=W0NstNSj2Q...@mail.gmail.com>
 <CAOWZXk3BLK=WtPGdBx1abO+zK8dnO=RnmfPds7LyhxNbm5O...@mail.gmail.com>
 <CAOWZXk2eCJwH_jZBVVKS-vub5a=Wjr+7_OabCJ_xtO6=BN-...@mail.gmail.com>
 <20120802135508.a88da3b763589d408adf7...@gmail.com> <CAN_J9aupqti8seuoT3YH1M3z18C74nAs+AR8iwpVDLh-Obr...@mail.gmail.com>
 <CAN_J9atTybAv6kjYcAgFmJYyZmF276SEU1Bmnf15+NMPq_w...@mail.gmail.com>
 <CAOWZXk3jZn5gJTpzggTyb3Oqy95zA1h2=CjWsw6zX8LeVsx...@mail.gmail.com>
 <CAOWZXk1xoSZit0cqhnFgDF4STO1+M7fPVrx9fW2WH_+JO1Q...@mail.gmail.com>
 <CAN_J9asAWvA6U+xv7HiXv21S5Oj6t_jT37inCfOBH8vqDTb...@mail.gmail.com> <20120803183923.33f911644123d182ebad3...@gmail.com>
From: Luis Lavena <luislav...@gmail.com>
Date: Sat, 4 Aug 2012 19:02:49 -0300
Message-ID: <CAN_J9avmxBvAuELH6OVOC9MN2mc3ZW7EwRLyuOrjhvumNsm...@mail.gmail.com>
Subject: Re: [TheCodeShop] continuing win32/file.c effort
To: thecodeshop@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 3, 2012 at 7:39 PM, Jon <jon.for...@gmail.com> wrote:
>
> Luis, the gist containing the background and data for your proposal looks=
 good. I have just a couple suggestions:
>

Bug submitted:
http://bugs.ruby-lang.org/issues/6836

> 1) Update "Patch has been tested also against..." to explicitly list OS's=
 tested against, eg - Ubuntu 12.04 GCC 4.X.Y, Win7 32bit MinGW 4.6.2, Win7 =
64bit MinGW 4.6.1, Win7 64bit Visual Studio ??, OS X Snow Leopard clang ??,=
 etc. Show that the patch works on Windows and also doesn't break *nix.
>

Updated the list of environment on which this was tested.

> 2) In the "Real life impact: Rails" section, reach out to Alex Chaffey to=
 see if he has additional Rails-on-Windows data. IIRC, he sent an email (ru=
by-talk ??) saying Rails startup was so slow on Windows (~30s) that it nega=
tively impacted the Ruby/Rails classes he has teaching. It would be spectac=
ular if he'd download the latest tcs-ruby and provide additional Rails star=
tup time data.
>

I think having this in front of Core might be better than collect all
the positive feedback we could, simply because the proposal could be
rejected and waiting for the feedback could take longer than a try on
this.

I believe I started to work on Fenix almost a year ago, so I don't
want to delay getting core feedback any longer.

Was planning on mention that the WEBrick fix was bad, take for example
Rack, which also fixes directory traversal without even using
File.expand_path at all.

But didn't want to stir the pot more than necessary, I just want Ruby
be a bit faster :-)

Thank you guys for be there all this time and contributing workloads,
tests results and patches.

Let's see how it goes :-D
--=20
Luis Lavena
AREA 17
-
Perfection in design is achieved not when there is nothing more to add,
but rather when there is nothing more to take away.
Antoine de Saint-Exup=E9ry