xiterm+thai: RFC for some advices from DD during build the 1.10-1 debian package
Neutron Soutmun
Since I have build the xiterm+thai_1.10-1 debian package and it's
already uploaded but still have some advices from Paul Wise (DD) as
the details below
Ref: http://lists.debian.org/debian-mentors/2012/01/msg00081.html (to
follow the threads)
=== 8< ===
On Fri, Jan 6, 2012 at 11:00 AM, Paul Wise <pa...@debian.org> wrote:
...
...
...
> A warning from configure:
>
> config.status: WARNING: 'Make.common.in' seems to ignore the
> --datarootdir setting
I will forward to upstream. <<< === RFC === >>>
...
...
...
> Some warnings from cppcheck:
>
> [test/graphics/qplot.c:120]: (error) Resource leak: fd
> [src/Xtensions/graphics/command.c:1028]: (error) Resource leak: ptyfd
> [src/command.c:1077]: (error) Resource leak: ptyfd
> [src/Xtensions/menubar+graphics/command.c:1030]: (error) Resource leak: ptyfd
>
> There are some duplicate files:
>
> src/Xtensions/graphics/graphics.h
> src/Xtensions/menubar+graphics/graphics.h
>
> src/Xtensions/graphics/graphics.c
> src/Xtensions/menubar+graphics/graphics.c
I will also forward to the upstream. <<< === RFC === >>>
> Please add a comment to the lintian overrides file explaining why
> setgid-binary has been overridden.
Sure, I will consult with upstream why it should overrides as it's
already overridden in the debian package since I have adopted. <<<
=== RFC === >>>
> How about including some things from debian/ upstream? Maybe inputrc
> txiterm txiterm.1 xiterm+thai.desktop?
Actually, the debian/ in the upstream repository is outdated. In the
past few years, I and the upstream have to sync the debian/ dir when
the current deb has been changed. But now I have maintained the deb in
git (Alioth) and consider the syncing debian/ dir with upstream is the
duplicate work. Therefore, I'll ask the upstream to drop the debian/
dir soon. <<< === RFC === >>>
=== 8< ===
Please add your comments for the "<<< === RFC === >>>" quotes.
Thanks in advance.
Best regards,
Neutron Soutmun