Fwd: Re: Bug 771439 - Text in Thunderbird's account provisioner dialog is not right aligned in Arabic locale

[Ludovic Hirlimann]

Asking on Tb-planning is better - as I don't know the source tree that well. Also asking on #maildev on irc.mozilla.org would probably do the trick.

Guys if you answer make sure to have Sri on the cc line.


Ludo

-------- Original Message --------

Subject:	Re: Bug 771439 - Text in Thunderbird's account provisioner dialog is not right aligned in Arabic locale
Date:	Mon, 8 Apr 2013 16:04:21 +0530
From:	Srish Sri <srishse...@gmail.com>
To:	Ludovic Hirlimann <lud...@mozilla.com>

Hi Ludo

I did build the src code, but I am not able to figure out in which file I should look for the code.

On Thu, Apr 4, 2013 at 7:41 PM, Ludovic Hirlimann <lud...@mozilla.com> wrote:

On 4/4/13 4:07 PM, Srish Sri wrote:

Hi

I am interested in fixing bug #771439  in Thunderbird. Can you tell me from where can I get the source code and get started with working on it?

Below is the link to the bug I am referring to
https://bugzilla.mozilla.org/show_bug.cgi?id=771439

so first you need to be able to build Thunderbird as per <https://developer.mozilla.org/en-US/docs/Simple_Thunderbird_build>. Once you've done that you'll need to fix the bug and provide a patch <https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in>, which will need to be reviewed.

You can always request help on coding issues in #maildev on irc.mozilla.org or on mozilla.dev.apps.Thunderbird.

If you need anything else ask me or mark (cc on this email)

Ludo

--
[:Usul] SRE Team at Mozilla
QA Lead fof Thunderbird
http://sietch-tabr.tumblr.com/

[acel...@atlas.sk]

If that's the new account provisioner (offering to create new accounts on servers/services) then I think it is in the /mail/components/newmailaccount/content directory.

I think XUL files have proper RTL automatically, but this one is in xhtml (accountProvisioner.xhtml) so maybe it needs some html attribute passed in to get proper direction.
______________________________________________________________
> Od: "Ludovic Hirlimann" <lud...@mozilla.com>
> Komu: <tb-pl...@mozilla.org>, Srish Sri <srishse...@gmail.com>
> Dátum: 08.04.2013 12:40
> Predmet: Fwd: Re: Bug 771439 - Text in Thunderbird's account provisioner dialogis not right aligned in Arabic locale

> irc.mozilla.org <http://irc.mozilla.org> or on

> mozilla.dev.apps.Thunderbird.
>
> If you need anything else ask me or mark (cc on this email)
>
> Ludo
>
> --
> [:Usul] SRE Team at Mozilla
> QA Lead fof Thunderbird
> http://sietch-tabr.tumblr.com/
>
>
>
>
>
>
>

>----------
>
>_______________________________________________
>tb-planning mailing list
>tb-pl...@mozilla.org
>https://mail.mozilla.org/listinfo/tb-planning
>
_______________________________________________
tb-planning mailing list
tb-pl...@mozilla.org
https://mail.mozilla.org/listinfo/tb-planning

[Richard Marti]

Hi

The Account Provisioner files are located at comm-central/mail/components/newmailaccount and the CSS files are at comm-central/mail/themes/platform/mail/newmailaccount where platform can be linux, osx and windows.

I saw in the CSS files some padding-left where should be a -moz-padding-start. I've also seen a text-align: left. But this was only a quick check, it may have more things to correct.

Richard

[Srish Sri]

On Mon, Apr 8, 2013 at 4:27 PM, <acelists@atlas.sk> wrote:

If that's the new account provisioner (offering to create new accounts on servers/services) then I think it is in the /mail/components/newmailaccount/content directory.

The issue is in account provisioner dialog box ,arabic text is not rtl ,I am not sure if it is related to a new account provisioner ,please correct me if I am wrong.
 

I think XUL files have proper RTL automatically, but this one is in xhtml (accountProvisioner.xhtml) so maybe it needs some html attribute passed in to get proper direction.

 

 <script type="text/javascript;version=1.8"
          src="chrome://messenger/content/newmailaccount/accountProvisioner.js">
  </script>

    <div id="success-compose">
      <img src="chrome://messenger/skin/newmailaccount/success-compose.png"/>
      <h4>&successful.write;</h4>
      &successful.write.desc;
    </div>

the &successful.write.desc;  here is the text written here in the dialog box , please explain me the code ,as I am not able to figure that out.

Regards
Srishti

[Magnus Melin]

On 13.04.2013 14:59, Srish Sri wrote:

I think XUL files have proper RTL automatically, but this one is in xhtml (accountProvisioner.xhtml) so maybe it needs some html attribute passed in to get proper direction.

 

 <script type="text/javascript;version=1.8"
          src="chrome://messenger/content/newmailaccount/accountProvisioner.js">
  </script>

    <div id="success-compose">
      <img src="chrome://messenger/skin/newmailaccount/success-compose.png"/>
      <h4>&successful.write;</h4>
      &successful.write.desc;
    </div>

the &successful.write.desc;  here is the text written here in the dialog box , please explain me the code ,as I am not able to figure that out.

Try setting adding the dir="&locale.dir;" attribute in the accountProvisioner.xhtml file, and for &locale.dir; to exist you need this on top
<!ENTITY % globalDTD SYSTEM "chrome://global/locale/global.dtd">
   %globalDTD;

 -Magnus