using codereview with mercurial

[Ondrej Certik]

Hi,

my aim is to use codereview (http://code.google.com/p/rietveld/) with
sympy where we use mercurial. As a first step, two days ago I
implemented uploading of base files:

http://codereview.appspot.com/1026

I would appreciate very much any feedback/review from anyone
interested in these features. To get things going, I've setup:

http://reviews.sympy.org/

with my latest code applied. You can upload things using:

$ python static/upload.py -l -s reviews.sympy.org

here is an example issue:

http://reviews.sympy.org/81

where I've uploaded some of the base files, so that you can see how it
looks like. See e.g.:

http://reviews.sympy.org/81/diff/1/4

If there are no major objections, my plan is this:

1) fix the server to accept mercurial patches (currently it only
accepts svn patches)
2) fix upload.py to upload the base files automatically, for svn, but
especially for Mercurial (so far you need to upload the base files by
hand using the web interface)
3) fix the remainging issues/problems, polish the patches

Is this the way to go? Any comments/feedback/help is welcome.

Ondrej

[Kirill Smelkov]

Hi Ondrej,

I'm sorry, unfortunately I don't have time to study rietveld or your
patch to add meaningful comment, so please feel free to ignore what
comes next.

---

Hmm, If I got it right, you upload a patch file, + all base files for
this patch, right?

Why upload base files?

Even if you want to do full-file two side diffs, it would be better to
"upload" hash of the base revision for the patch series (and btw, this
is already present in the patch header), and the app could then get
appropriate base files via 'hg cat', hg python api or something like
that.

We can connect mercurial and rietveld, right? Why do redundant steps at
all? If it needs base files - let it ask hg...

--
Всего хорошего, Кирилл.