Show version and mercurial revision in the isympy

0 views
Skip to first unread message

Friedrich Hagedorn

unread,
Apr 25, 2008, 7:44:53 PM4/25/08
to sympy-...@googlegroups.com
Here is my patch for that.

Friedrich

Friedrich Hagedorn

unread,
Apr 25, 2008, 7:45:38 PM4/25/08
to sympy-...@googlegroups.com
and now the file...
hg-rev.patch

Ondrej Certik

unread,
Apr 25, 2008, 8:12:54 PM4/25/08
to sympy-...@googlegroups.com
On Sat, Apr 26, 2008 at 1:45 AM, Friedrich Hagedorn <fried...@gmx.de> wrote:
> and now the file...
>
>

Thanks, the patch looks good and it works. However, there is a problem with:

--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/sympy/revision.py Sat Apr 26 01:21:45 2008 +0200
@@ -0,0 +1,81 @@
+# Copyright (C) 2005, 2006, 2008 by Intevation GmbH
+# Author(s):
+# Thomas Arendsen Hein <tho...@intevation.de>
+#
+# This program is free software under the GNU GPL (>=v2)
+# Read the file COPYING coming with the software for details.


That'd mean that sympy would become GPL as a whole. Where is this file
from? Maybe the author would make it BSD for us, or we may import it
from Mercurial somewhere.

Ondrej

Friedrich Hagedorn

unread,
Apr 26, 2008, 8:59:56 AM4/26/08
to sympy-...@googlegroups.com

I just copied the file

http://selenic.com/repo/index.cgi/hg/file/tip/mercurial/version.py

directly from mercurial repository. This was the advice from Kirill in

http://groups.google.com/group/sympy/browse_thread/thread/38fd4e5739f9a325

And as you can read there

http://www.selenic.com/mercurial/wiki/index.cgi/FAQ

mercurial is under GPL licence. What do we want to do now? Ask the autor?

By,

Friedrich

Friedrich Hagedorn

unread,
Apr 26, 2008, 9:23:37 AM4/26/08
to sympy-...@googlegroups.com
Here is a new patch. This time you see in the global isympy this

[friedrich@wuschel:~] % isympy
Python 2.5.1 console for SymPy 0.5.13-hg-2d15ceab52b0

and in the local sympy

[friedrich@wuschel:~/src/sympy] % ./bin/isympy
Python 2.5.1 console for SymPy 0.5.13-hg-work-directory

I think it is better and isympy starts faster because it didnt run every
time 'hg identity'.

hg-rev.patch

Kirill Smelkov

unread,
Apr 26, 2008, 1:24:05 PM4/26/08
to sympy-...@googlegroups.com

Not sure about this - for bug reports i'd prefer knowing the revision.

On the other hand, when users post script output to issues they seldomly
post full output and this particular line header is often ommited.

If we'd manage to know workdir revision fast, I'm for printing it too.

> I just copied the file
>
> http://selenic.com/repo/index.cgi/hg/file/tip/mercurial/version.py
>
> directly from mercurial repository. This was the advice from Kirill in
>
> http://groups.google.com/group/sympy/browse_thread/thread/38fd4e5739f9a325
>
> And as you can read there
>
> http://www.selenic.com/mercurial/wiki/index.cgi/FAQ
>
> mercurial is under GPL licence. What do we want to do now? Ask the autor?

I think yes, we should ask the author about this.

Also, I'd ask on mercurial mailing list what they could suggest for
projects like SymPy (who uses mercurial) to do in order to get current
version.

I think this topic is general, and would be interesting for all.

Could you please do it Friedrich, or shall I care of this?

--
Всего хорошего, Кирилл.

Friedrich Hagedorn

unread,
Apr 26, 2008, 3:14:51 PM4/26/08
to sympy-...@googlegroups.com
On Sat, Apr 26, 2008 at 09:24:05PM +0400, Kirill Smelkov wrote:
>
> On Sat, Apr 26, 2008 at 03:23:37PM +0200, Friedrich Hagedorn wrote:
> > Here is a new patch. This time you see in the global isympy this
> >
> > [friedrich@wuschel:~] % isympy
> > Python 2.5.1 console for SymPy 0.5.13-hg-2d15ceab52b0
> >
> > and in the local sympy
> >
> > [friedrich@wuschel:~/src/sympy] % ./bin/isympy
> > Python 2.5.1 console for SymPy 0.5.13-hg-work-directory
> >
> > I think it is better and isympy starts faster because it didnt run every
> > time 'hg identity'.
>
> Not sure about this - for bug reports i'd prefer knowing the revision.

I think when you work with local ./bin/isympy you could do

In [1]: !hg id
IPython system call: hg id
2348232f41b0 tip

to get the parent revision. The original problem was that I want to know
the revision of the _installed_ isympy. Once sympy is installed I have
no chance to know the revision.



> On the other hand, when users post script output to issues they seldomly
> post full output and this particular line header is often ommited.

Thats right. And after more then 20 Input this line is gone away.

> If we'd manage to know workdir revision fast, I'm for printing it too.

OK. Then I have to improve the current patch.

> > I just copied the file
> >
> > http://selenic.com/repo/index.cgi/hg/file/tip/mercurial/version.py
> >
> > directly from mercurial repository. This was the advice from Kirill in
> >
> > http://groups.google.com/group/sympy/browse_thread/thread/38fd4e5739f9a325
> >
> > And as you can read there
> >
> > http://www.selenic.com/mercurial/wiki/index.cgi/FAQ
> >
> > mercurial is under GPL licence. What do we want to do now? Ask the autor?
>
> I think yes, we should ask the author about this.
>
> Also, I'd ask on mercurial mailing list what they could suggest for
> projects like SymPy (who uses mercurial) to do in order to get current
> version.
>
> I think this topic is general, and would be interesting for all.
>
> Could you please do it Friedrich, or shall I care of this?

The topic to care for the licence stuff is relativly new for me because
its my first open source project I am working for it. Could you care for
this, please?

Thanks,

Friedrich

Kirill Smelkov

unread,
Apr 26, 2008, 3:37:30 PM4/26/08
to sympy-...@googlegroups.com

Sure, I'll do it.

I'll try tommorow, after having some rest.

Thanks,

--
Всего хорошего, Кирилл.

Kirill Smelkov

unread,
May 31, 2008, 10:21:47 AM5/31/08
to sympy-...@googlegroups.com

I've finally found time to give my debt:

http://www.selenic.com/pipermail/mercurial-devel/2008-May/006399.html

and here is Matt reply:

http://www.selenic.com/pipermail/mercurial-devel/2008-May/006401.html

It seems everything seems to be much simpler :)

--
Всего хорошего, Кирилл.

Kirill Smelkov

unread,
Jun 5, 2008, 4:38:21 AM6/5/08
to sympy-...@googlegroups.com, Friedrich Hagedorn

And also we've got explicit "feel free to use it" from version.py
author:

http://marc.info/?l=mercurial-devel&m=121224630109273&w=2

So let's get things moving...

Friedrich?

--
Всего хорошего, Кирилл.

P.S. I apologize again for so long delay with performing this task at my
side...

Friedrich Hagedorn

unread,
Jun 5, 2008, 6:26:35 AM6/5/08
to sympy-...@googlegroups.com
On Thu, Jun 05, 2008 at 12:38:21PM +0400, Kirill Smelkov wrote:
>
> On Sat, May 31, 2008 at 06:21:47PM +0400, Kirill Smelkov wrote:
> >
> > On Sat, Apr 26, 2008 at 11:37:30PM +0400, Kirill Smelkov wrote:
> > >
> > > On Sat, Apr 26, 2008 at 09:14:51PM +0200, Friedrich Hagedorn wrote:
> > > >
> > > > I think when you work with local ./bin/isympy you could do
> > > >
> > > > In [1]: !hg id
> > > > IPython system call: hg id
> > > > 2348232f41b0 tip
> > > >
> > > > to get the parent revision. The original problem was that I want to know
> > > > the revision of the _installed_ isympy. Once sympy is installed I have
> > > > no chance to know the revision.
> > > >
> > > >
> > > > The topic to care for the licence stuff is relativly new for me because
> > > > its my first open source project I am working for it. Could you care for
> > > > this, please?
> > >
> > > Sure, I'll do it.
> > >
> > > I'll try tommorow, after having some rest.
> >
> > I've finally found time to give my debt:
> >
> > http://www.selenic.com/pipermail/mercurial-devel/2008-May/006399.html
> >
> > and here is Matt reply:
> >
> > http://www.selenic.com/pipermail/mercurial-devel/2008-May/006401.html
> >
> > It seems everything seems to be much simpler :)
>
> And also we've got explicit "feel free to use it" from version.py
> author:
>
> http://marc.info/?l=mercurial-devel&m=121224630109273&w=2
>
> So let's get things moving...
>
> Friedrich?

Yes, I can do it in 2 weeks. I have to finish my own work now. But also
everyone else can do it.


By, Friedrich

Kirill Smelkov

unread,
Jun 20, 2008, 5:17:25 AM6/20/08
to sympy-...@googlegroups.com, Friedrich Hagedorn

Friedrich, it would be great if you could find free time to finish this.

Thanks beforehand.

--
Всего хорошего, Кирилл.

Reply all
Reply to author
Forward
0 new messages