Michael Chletsos <mpchl...@gmail.com> writes:
> The current patch I used does not fix the configure script, I could
> modify that to only use <= 1.8.7 or >= 1.9.3 if you like.
> sorry about confusion - here is the updated patch, with swig updates.
Your patch seems to be reversed ('diff -u {new} {old}' whereas what
everyone wants to see is 'diff -u {old} {new}' or 'svn diff'), and also
seems to have been developed against something older than Subversion
trunk. I note for example that you change some Config to RbConfig, a
change that was made in Subversion trunk months ago in r1337514.
Please update your Subversion checkout to the current trunk, apply your
patch, then run 'svn diff' to generate a more current patch.
On Wed, Nov 7, 2012 at 8:54 AM, Peter Samuelson <pe...@p12n.org> wrote:
> [Michael Chletsos]
>> sorry about confusion - here is the updated patch, with swig updates.
> Your patch seems to be reversed ('diff -u {new} {old}' whereas what
> everyone wants to see is 'diff -u {old} {new}' or 'svn diff'), and also
> seems to have been developed against something older than Subversion
> trunk. I note for example that you change some Config to RbConfig, a
> change that was made in Subversion trunk months ago in r1337514.
> Please update your Subversion checkout to the current trunk, apply your
> patch, then run 'svn diff' to generate a more current patch.
On Wed, Nov 7, 2012 at 8:57 AM, Michael Chletsos <mpchl...@gmail.com> wrote:
> Sorry - I am having one of those morning - this one should be good, I
> keep reversing my files and my thoughts . . .
> I will check out trunk later and fix the patches and this patch and
> make them all nice and be real.
> On Wed, Nov 7, 2012 at 8:54 AM, Peter Samuelson <pe...@p12n.org> wrote:
>> [Michael Chletsos]
>>> sorry about confusion - here is the updated patch, with swig updates.
>> Your patch seems to be reversed ('diff -u {new} {old}' whereas what
>> everyone wants to see is 'diff -u {old} {new}' or 'svn diff'), and also
>> seems to have been developed against something older than Subversion
>> trunk. I note for example that you change some Config to RbConfig, a
>> change that was made in Subversion trunk months ago in r1337514.
>> Please update your Subversion checkout to the current trunk, apply your
>> patch, then run 'svn diff' to generate a more current patch.
Michael Chletsos <mpchl...@gmail.com> writes:
> Here is a complete patch that I tested - more work needs to be done on
> the tests, but currently all tests that are run, succeed on my system.
It breaks the tests when run with ruby 1.8.7 on my Debian/testing
machine which is a regression since they pass without the patch.
Loaded suite .
Started
............................Killed
make: *** [check-swig-rb] Error 137
I don't know much about Ruby but with --verbose=verbose the output ends:
Michael Chletsos <mpchl...@gmail.com> writes:
> OK - this should fix your issues, tested on ruby1.9.3 and ruby1.8.7 -
> passed for me, let me know what you get.
Initial support for ruby 1.9.3 when creating swig bindings for subversion.
* Makefile.in:
Ruby 1.8 uses --verbose, 1.9 does not for run-test.rb
* subversion/bindings/swig/ruby/test/test_core.rb:
Updated for ruby1.9 time, which uses nanoseconds
* subversion/bindings/swig/ruby/test/test_repos.rb:
ruby1.8 carries the assignment through block, ruby1.9 does not carry
assignments, we need to explicitly do this.
* subversion/bindings/swig/ruby/test/test-unit-ext/priority.rb:
run priority tests only for ruby1.8
* subversion/bindings/swig/ruby/test/test_delta.rb:
fix nil return in ruby1.9,
ruby1.8 carries the assignment through block, ruby1.9 does not carry
assignments, we need to explicitly do this
fix StringIO encoding to be ASCII-8BIT, no longer assumed as in ruby1.8
* subversion/bindings/swig/ruby/test/test-unit-ext.rb:
turn off some tests for ruby1.9, they should be fixed still
* subversion/bindings/swig/ruby/test/test_fs.rb:
update md5 to digest/md5 in require
* subversion/bindings/swig/ruby/test/test_wc.rb,
subversion/bindings/swig/ruby/test/test_client.rb:
ruby1.8 carries the assignment through block, ruby1.9 does not carry
assignments, we need to explicitly do this
* subversion/bindings/swig/ruby/test/my-assertions.rb:
create intermediary assertion block handler
* subversion/bindings/swig/ruby/svn/util.rb:
convert to string before splitting for ruby1.9 compat
* subversion/bindings/swig/ruby/svn/info.rb:
use each_line for ruby1.9 and each for ruby1.8
* configure.ac:
detect ruby1.9.3 - added teeny version detection
restrict build to 1.8.x and >= 1.9.3
Patch by: Michael Chletsos <mpchl...@gmail.com>,
Vincent Batts <vba...@slackware.com>
