NullReferenceException in Comments Control

[Travis Illig]

In Subtext 2.5.2.0 I'm finding that my error log is filling up with
these:

System.NullReferenceException: Object reference not set to an instance
of an object. at
Subtext.Web.UI.Controls.Comments.CommentsCreated(Object sender,
RepeaterItemEventArgs e) at
System.Web.UI.WebControls.RepeaterItemEventHandler.Invoke(Object
sender, RepeaterItemEventArgs e) at
System.Web.UI.WebControls.Repeater.OnItemCreated(RepeaterItemEventArgs
e) at System.Web.UI.WebControls.Repeater.CreateItem(Int32 itemIndex,
ListItemType itemType, Boolean dataBind, Object dataItem) at
System.Web.UI.WebControls.Repeater.CreateControlHierarchy(Boolean
useDataSource) at
System.Web.UI.WebControls.Repeater.OnDataBinding(EventArgs e) at
System.Web.UI.WebControls.Repeater.DataBind() at
Subtext.Web.UI.Controls.Comments.BindFeedback(Entry entry, Boolean
fromCache)

I've been walking through that method, but I can't figure out which
line it's on. There aren't any 2.5.2.0 PDBs for download and I'm not
really itching to do a custom build and redeploy just for the PDBs...
has anyone seen this or know how to fix it? THOUSANDS of them.

[Travis Illig]

I ended up building a custom version of 2.5.2.0 Subtext.Web.dll with
symbols (boo!) and found the issue. The comments control checks for
feedbackItem.Body.Length > 0 but doesn't first check to see if
feedbackItem.Body != null.

Added issue 306 along with a code review comment on the latest trunk
revision pointing right to the line that needs to be fixed.
http://code.google.com/p/subtext/issues/detail?id=306

-T

[Simone Chiaretta]

Thx,
We'll get that fixed

Simone

---
Simone Chiaretta
@simonech
Sent from a tablet

> --
> You received this message because you are subscribed to the Google Groups "Subtext" group.
> To post to this group, send email to sub...@googlegroups.com.
> To unsubscribe from this group, send email to subtext+u...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/subtext?hl=en.
>