[STUMP] [PATCH] Add support for LispWorks 6 in 'mpd.lisp' module.

[Kamil Shakirov]

Hi,

Pull request (92214d8) at https://github.com/sabetts/stumpwm/pull/11
now adds support for LispWorks 6 in mpd.lisp module.

--
--ska

_______________________________________________
Stumpwm-devel mailing list
Stumpw...@nongnu.org
https://lists.nongnu.org/mailman/listinfo/stumpwm-devel

[Shawn Betts]

Thanks Kamil. Can someone confirm that it still works on clisp and sbcl?

-Shawn

[Dirk Sondermann]

On 10/26/12 20:54, Shawn Betts wrote:
> Thanks Kamil. Can someone confirm that it still works on clisp and sbcl?

It builds and works on SBCL.

--
Dirk

[Shawn Betts]

On Sat, Oct 27, 2012 at 1:19 AM, Dirk Sondermann <ds-st...@dyximaq.de> wrote:
> On 10/26/12 20:54, Shawn Betts wrote:
>> Thanks Kamil. Can someone confirm that it still works on clisp and sbcl?
>
> It builds and works on SBCL.

Good enough for me. Thanks! Kamil, it's been merged.

-Shawn

[Dirk Sondermann]

On 10/28/12 01:55, Shawn Betts wrote:

> On Sat, Oct 27, 2012 at 1:19 AM, Dirk Sondermann wrote:
>> On 10/26/12 20:54, Shawn Betts wrote:
>>> Thanks Kamil. Can someone confirm that it still works on clisp and sbcl?
>>
>> It builds and works on SBCL.
>
> Good enough for me. Thanks! Kamil, it's been merged.

Unfortunately, I missed an issue while testing the mpd module
on SBCL yesterday.

In the function MPD-RECEIVE, the symbol READ-LINE is used as the
name of a function defined by FLET. By default, SBCL locks the
package COMMON-LISP, to which READ-LINE belongs, so binding this
symbol by FLET leads to an error:

caught ERROR:
Lock on package COMMON-LISP violated when binding READ-LINE
as a local function while in package STUMPWM.
See also:
The SBCL Manual, Node "Package Locks"
The ANSI Standard, Section 11.1.2.1.2

In principle, one could avoid this error by unlocking the package
(I did that accidentally yesterday by using SB-EXT:UNLOCK-PACKAGE
somewhere in my ~/.stumpwmrc), but it seems to be better to replace
READ-LINE with a less controversial name (cf. the attached patch).

--
Dirk

[Kamil Shakirov]

Hi Dirk,

On 10/29/2012 12:02 AM, Dirk Sondermann wrote:
> On 10/28/12 01:55, Shawn Betts wrote:
>> On Sat, Oct 27, 2012 at 1:19 AM, Dirk Sondermann wrote:
>>> On 10/26/12 20:54, Shawn Betts wrote:
>>>> Thanks Kamil. Can someone confirm that it still works on clisp and sbcl?
>>>
>>> It builds and works on SBCL.
>>
>> Good enough for me. Thanks! Kamil, it's been merged.
>
> Unfortunately, I missed an issue while testing the mpd module
> on SBCL yesterday.
>
> In the function MPD-RECEIVE, the symbol READ-LINE is used as the
> name of a function defined by FLET. By default, SBCL locks the
> package COMMON-LISP, to which READ-LINE belongs, so binding this
> symbol by FLET leads to an error:
>
> caught ERROR:
> Lock on package COMMON-LISP violated when binding READ-LINE
> as a local function while in package STUMPWM.
> See also:
> The SBCL Manual, Node "Package Locks"
> The ANSI Standard, Section 11.1.2.1.2

Ooops. :)

Hmm, CLisp, Clozure CL, Allegro CL and LispWorks do not signal an error
if FLET shadows a global function (from CL package in this case).

> In principle, one could avoid this error by unlocking the package
> (I did that accidentally yesterday by using SB-EXT:UNLOCK-PACKAGE
> somewhere in my ~/.stumpwmrc), but it seems to be better to replace
> READ-LINE with a less controversial name (cf. the attached patch).
>
>
>

> _______________________________________________
> Stumpwm-devel mailing list
> Stumpw...@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/stumpwm-devel
>

--
--ska.

[Shawn Betts]

On Sun, Oct 28, 2012 at 10:02 AM, Dirk Sondermann <ds-st...@dyximaq.de> wrote:
> On 10/28/12 01:55, Shawn Betts wrote:
>> On Sat, Oct 27, 2012 at 1:19 AM, Dirk Sondermann wrote:
>>> On 10/26/12 20:54, Shawn Betts wrote:
>>>> Thanks Kamil. Can someone confirm that it still works on clisp and sbcl?
>>>
>>> It builds and works on SBCL.
>>
>> Good enough for me. Thanks! Kamil, it's been merged.
>
> Unfortunately, I missed an issue while testing the mpd module
> on SBCL yesterday.
>
> In the function MPD-RECEIVE, the symbol READ-LINE is used as the
> name of a function defined by FLET. By default, SBCL locks the
> package COMMON-LISP, to which READ-LINE belongs, so binding this
> symbol by FLET leads to an error:

Thanks Dirk. I've applied the patch. Next time can you format the
patch so I can use 'git am' to apply it? That gives credit where
credit is due and it's easier for me. The github pull request stuff
works too.