Cool, I see you've already grabbed the trac ticket [T] for this too.
> Currently we have a page Chris K put up for the actual event here [1] but
> the news item will, in part, duplicate the information here.
Woah, we do‽ This should definitely be linked to from the home page
key dates - in the same manner that the tech days are.
Apologies, I see that this is in fact already included in the patch
that I didn't get around to reviewing. I'll push this this evening if
it hasn't already been.
P
Chewett
Looks good, pushed.
P
I think a short news item that contains some warm-up text, a reminder
of the dates & some links will suffice. I think that it makes more
sense for the schedule to be added to the events/comp page.
Peter
Attached is two patches, The first comp_event.patch adds parking
information and the preliminary schedule for the day, found on trac [1]
The second comp_news.patch creates a starting point for a news article,
it uses the old one as a basis and mentions tickets, where the event is
being held and that both days are compulsory. This can be seen here [2]
Iv never edited a news page before, so have no clue how //PUB_DATE:
should be completed, so just added tomorrows date, at 9am
Feel free to take either patch and make changes as needed and/or suggest
necessary changes
Chewett
[1] https://www.studentrobotics.org/trac/wiki/2012/Competition/Schedule
[2]
https://www.studentrobotics.org/~chewett/srweb-dev/news/2012-04-04_sr2012_comp_nearly_here
There is a spelling error in your comp_event_page.patch (schedual ->
schedule). I'd also change preliminary to provisional. Otherwise, looks
good. Thanks for doing it!
Regards,
Andy
As noted in the README, the PUB_DATE is used for the apparent date at
which the item was published in the news and RSS feeds. I'm assuming
that the sorting there also uses this. The dates that happen to also
be in the page names aren't material, and are just used to keep things
separate and their context clear.
As a general comment, I'd suggest a preference towards:
[things](there), things and more things.
Rather than
things, things and more things can be found [here](there)
The reasons vary from it generally reading better to it providing
better context for search engines. The website as a whole also uses
the former, so it would be good to stick with that where possible.
From the patch:
> In addition, all team members must bring along their ticket, obtainable here once a Media Consent Form has been received by Student Robotics.
It might be worth moving the link to the Tickets section on "Resources
for Team Leaders". I'd also make it clearer what the latter does. On
first reading, I'd assumed that the MCF link would serve up a PDF I
could complete & post off, but I see that this instead links to the
tickets section, which I think is a little confusing. I'd suggest
something like:
In addition, all team members must bring along their
[ticket](RfTL#Tickets), obtainable from the [ticketing
system](/tickets/) once a [Media Consent Form](direct-link-to-MCF) has
been received by Student Robotics.
The thing that follows from this is whether or not a postal address
[1] for them is on the website, and if not whether one should be
added.
> +- 13:45: Initial robot inspections (Obviously not all robots need
> + inspecting within this time slot, just the ones that are going to play soon)
Remove the stuff in brackets - this is for us!
I think that it would also be useful to have a link to the competition
page from the events/sr2012/2012-04-14-competition page, just as the
Tech Days have.
Andy wrote:
> I'd also change preliminary to provisional. Otherwise, looks
> good. Thanks for doing it!
Indeed.
P
[1] I'd suggest using the one from Jeremy's recent email:
http://thread.gmane.org/gmane.science.robotics.srobo.general/1310/focus=1341
Attached is:
news_item.patch which should include all the suggestions you and andy
made and can be viewed online here [1]
add_link_to_tickets.patch adds the ticket link to the team-leaders page
comp_event_page.patch adds a link to the main competition page
parking_info.patch adds the parking infomation to the site, which has an
associated ticket [2]
In the meantime rob has uploaded the schedule
[1]
https://www.studentrobotics.org/~chewett/srweb-dev/news/2012-04-04_sr2012_comp_nearly_here
[2] https://www.studentrobotics.org/trac/ticket/1163
These all looked pretty good, so I've pushed them (admittedly with
some minor tweaks).
P
Thanks
Chewett
It looks like someone else has already added similar information to
the page since you created the patch. Are there things that you still
think are missing?
Separately, feel free to re-user branches in your repos if they're
covering the same topic - I see you added a comp2012-news-article2
branch for this work. I'd generally have fast-forwarded the existing
branch and then made a new commit there rather than having a whole new
branch.
P
Chewett