review: fix Python-3.3 incompatibility implementations/tests

59 views
Skip to first unread message

Takayuki Shimizukawa

unread,
Oct 31, 2012, 12:28:47 AM10/31/12
to sphin...@googlegroups.com
Hi maintainers,

I'm trying to fix some problem at Python 3.3.
I make a pull-request.

https://bitbucket.org/birkenfeld/sphinx/pull-request/83

Please review and give me comments (inline comment at PR is better?).
Best regards,
--
Takayuki SHIMIZUKAWA
Sphinx-users.jp

Georg Brandl

unread,
Nov 1, 2012, 1:04:55 PM11/1/12
to sphin...@googlegroups.com, Takayuki Shimizukawa
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 31.10.2012 05:28, schrieb Takayuki Shimizukawa:
> Hi maintainers,
>
> I'm trying to fix some problem at Python 3.3. I make a pull-request.
>
> https://bitbucket.org/birkenfeld/sphinx/pull-request/83
>
> Please review and give me comments (inline comment at PR is better?). Best
> regards,

Hi Takayuki,

I've made some comments. Together with Jon's fixes, I think this handles
our Python 3.3 issues well. A very good start!

Thanks!
Georg
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iEYEARECAAYFAlCSq7cACgkQN9GcIYhpnLAGfwCghG1CcNYZM0qzIFFJmHVL8ne1
1EMAoIWym/lR3wTjDFQzsKzkiQt9MC+m
=ISpY
-----END PGP SIGNATURE-----
Reply all
Reply to author
Forward
0 new messages