Hello,
I'm starting to play with the tests,
the first issue is with FileSystemViewFolder.ListViews(string path)
EmbeddedViewFolderTester.ListViewsSameResults issues folder.ListViews
("home") instead of folder.ListViews("Home")
fixing that makes the test pass, EmbeddedViewFolder works ok with case
typos
I'm unsure what is the intended result, because ListViews is
implemented from IViewFolder interface:
what is the behaviour of IViewFolder.ListViews if there are matching
(possibly nested) directories with case insensitive search, may
ListViews work even with case typos?
IMHO, the developer should use strictly the same directory name when
running on case sensitive file systems so the test should be fixed.
On Jun 4, 8:17 pm, Louis DeJardin <
louis.dejar...@gmail.com> wrote:
> Some quick notes on doing that if you're interested:
>
> 1) sign up on
github.com - free and easy to use
>
> 2) if windows, install msysgit - seehttp://
whereslou.com/2009/05/06/recipe-for-spark-build-dev-machine-on...
> some steps to installing windows git client and adding workstation's
> ssh
> key to github account info
>
> 3) fork spark withhttp://
github.com/loudej/spark/fork
>
> 4) clone your repos locally and checkout a tracking mono branch:
> git clone --no-checkout g...@github.com:yourgithubname/spark.git
> cd spark
> git checkout --track -b mono origin/mono
>
> (or use git gui instead of step 4)
>
> On Wed, Jun 3, 2009 at 7:11 PM, Louis DeJardin <
louis.dejar...@gmail.com>wrote:
>
>
>
> > I pushed some changes onto a "mono" branch to try to update tests and
> > remove use of '\' constants in paths. Would you like to fork the repos and
> > commit changes onto that branch? It can be merged back onto "master" once we
> > find everything working on both environments.
>
> > On Wed, Jun 3, 2009 at 5:33 PM, Louis DeJardin <
louis.dejar...@gmail.com>wrote:
>
> >> I'd say +1 for mono. I'll see if I can make the tests and IViewFolder
> >> implemenations separator agnostic.
>