about spark on mono

8 views
Skip to first unread message

Gauthier Segay

unread,
Jun 3, 2009, 3:51:16 PM6/3/09
to Spark View Engine Dev
I did some checks of spark under a linux box with mono 2.4

after adding the mono-2.0 configuration section in the nant script, it
compiles fine, but there is an issue with all the path related things
that make a big part of the tests to fail.

most of the tests and perhaps some code in view loading use antislash

I think that when path separator should be used in a platform agnostic
manner (also thinking web uri) and hardwritten in code, they should
be '/' instead of '\' because the second one seems to be a valid
character for filename on unixes.

There is also Path.PathSeparator which should be used in situation
like this (well without string interpollation in c#, it would mess a
bit with the readability of thoses tests)

some other incompatibilities may also exists but it's hard to head to
them with most of the tests failling due to the path issue, also I
did'nt check that some modifications that make some of them green
would also keep them green under windows.

leading to my question, is there any plan/interest to make spark work
under mono?

Louis DeJardin

unread,
Jun 3, 2009, 6:33:10 PM6/3/09
to spar...@googlegroups.com
I'd say +1 for mono. I'll see if I can make the tests and IViewFolder implemenations separator agnostic.

Louis DeJardin

unread,
Jun 3, 2009, 8:11:54 PM6/3/09
to spar...@googlegroups.com
I pushed some changes onto a "mono" branch to try to update tests and remove use of '\' constants in paths. Would you like to fork the repos and commit changes onto that branch? It can be merged back onto "master" once we find everything working on both environments.

Louis DeJardin

unread,
Jun 4, 2009, 2:17:42 PM6/4/09
to spar...@googlegroups.com
Some quick notes on doing that if you're interested:

1) sign up on github.com - free and easy to use

2) if windows, install msysgit - see http://whereslou.com/2009/05/06/recipe-for-spark-build-dev-machine-on-virtual-pc for some steps to installing windows git client and adding workstation's ssh key to github account info

3) fork spark with http://github.com/loudej/spark/fork

4) clone your repos locally and checkout a tracking mono branch:
git clone --no-checkout g...@github.com:yourgithubname/spark.git
cd spark
git checkout --track -b mono origin/mono

(or use git gui instead of step 4)

Gauthier Segay

unread,
Jun 8, 2009, 4:20:25 PM6/8/09
to Spark View Engine Dev
Hello,

I'm starting to play with the tests,

the first issue is with FileSystemViewFolder.ListViews(string path)

EmbeddedViewFolderTester.ListViewsSameResults issues folder.ListViews
("home") instead of folder.ListViews("Home")

fixing that makes the test pass, EmbeddedViewFolder works ok with case
typos

I'm unsure what is the intended result, because ListViews is
implemented from IViewFolder interface:

what is the behaviour of IViewFolder.ListViews if there are matching
(possibly nested) directories with case insensitive search, may
ListViews work even with case typos?

IMHO, the developer should use strictly the same directory name when
running on case sensitive file systems so the test should be fixed.

On Jun 4, 8:17 pm, Louis DeJardin <louis.dejar...@gmail.com> wrote:
> Some quick notes on doing that if you're interested:
>
> 1) sign up on github.com - free and easy to use
>
> 2) if windows, install msysgit - seehttp://whereslou.com/2009/05/06/recipe-for-spark-build-dev-machine-on...
> some steps to installing windows git client and adding workstation's
> ssh
> key to github account info
>
> 3) fork spark withhttp://github.com/loudej/spark/fork
>
> 4) clone your repos locally and checkout a tracking mono branch:
> git clone --no-checkout g...@github.com:yourgithubname/spark.git
> cd spark
> git checkout --track -b mono origin/mono
>
> (or use git gui instead of step 4)
>
> On Wed, Jun 3, 2009 at 7:11 PM, Louis DeJardin <louis.dejar...@gmail.com>wrote:
>
>
>
> > I pushed some changes onto a "mono" branch to try to update tests and
> > remove use of '\' constants in paths. Would you like to fork the repos and
> > commit changes onto that branch? It can be merged back onto "master" once we
> > find everything working on both environments.
>
> > On Wed, Jun 3, 2009 at 5:33 PM, Louis DeJardin <louis.dejar...@gmail.com>wrote:
>
> >> I'd say +1 for mono. I'll see if I can make the tests and IViewFolder
> >> implemenations separator agnostic.
>

Louis DeJardin

unread,
Jun 8, 2009, 9:29:31 PM6/8/09
to spar...@googlegroups.com
I agree, it's best for tests to use correct case on either file system
unless it's specifically testing the results of incorrect case.

That also raises the question of capitalization of well-known files
and folders like Shared, Layouts, Application.spark, and
_global.spark. I believe that's how they're capitalized, though I
don't know if it's used consistently in every test.

Say - is the virtualpathprovider case insensitive? I'm kind of curious
if aspx urls on mono will match incorrect case to expected file.

Gauthier Segay

unread,
Jun 12, 2009, 3:51:28 PM6/12/09
to Spark View Engine Dev
quick report here:

I checked last week some of your likely fixes (.AsPath()),

last I recall is that:
- there is issue with linking to dll (add assembly in spark
configuration) for some reason (dig through the c# codegen stuff to
seek out)
- also some issues with the parser or Chunks (html encode seemed to
fail)

currently I've .biz hanging me for a while but I'll try to post a xml
testresult in case anyone want to look around the remaining failling
tests to inspect

On Jun 9, 3:29 am, Louis DeJardin <louis.dejar...@gmail.com> wrote:
> I agree, it's best for tests to use correct case on either file system
> unless it's specifically testing the results of incorrect case.
>
> That also raises the question of capitalization of well-known files
> and folders like Shared, Layouts, Application.spark, and
> _global.spark. I believe that's how they're capitalized, though I
> don't know if it's used consistently in every test.
>
> Say - is the virtualpathprovider case insensitive? I'm kind of curious
> if aspx urls on mono will match incorrect case to expected file.
>
Reply all
Reply to author
Forward
0 new messages