Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Issue 33 in snappy: simpler configure.ac
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  5 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
sna...@googlecode.com  
View profile  
 More options Apr 16 2011, 11:54 am
From: sna...@googlecode.com
Date: Sat, 16 Apr 2011 15:54:57 +0000
Local: Sat, Apr 16 2011 11:54 am
Subject: Issue 33 in snappy: simpler configure.ac
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 33 by fdman...@gmail.com: simpler configure.ac
http://code.google.com/p/snappy/issues/detail?id=33

The following patch simplifies configure.ac and snappy-stubs-public.h.in

I'm no expert with the autotools, but I believe this change doesn't change  
any behaviour.

cheers

Attachments:
        simpler_configure.patch  1.3 KB


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
sna...@googlecode.com  
View profile  
 More options Apr 16 2011, 3:38 pm
From: sna...@googlecode.com
Date: Sat, 16 Apr 2011 19:38:47 +0000
Local: Sat, Apr 16 2011 3:38 pm
Subject: Re: Issue 33 in snappy: simpler configure.ac
Updates:
        Status: Invalid

Comment #1 on issue 33 by se...@google.com: simpler configure.ac
http://code.google.com/p/snappy/issues/detail?id=33

This won't work. You need to get HAVE_STDINT_H from somewhere; the usual  
place would be config.h, but you cannot include config.h in a public header  
file, since that would pull in definitions (e.g. of VERSION) that would  
conflict with other autotools-based projects' config.h.

In short, the current behavior is correct and needed.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
sna...@googlecode.com  
View profile  
 More options Apr 16 2011, 3:56 pm
From: sna...@googlecode.com
Date: Sat, 16 Apr 2011 19:56:52 +0000
Local: Sat, Apr 16 2011 3:56 pm
Subject: Re: Issue 33 in snappy: simpler configure.ac

Comment #2 on issue 33 by fdman...@gmail.com: simpler configure.ac
http://code.google.com/p/snappy/issues/detail?id=33

Hum, you're right, thanks for the explanation :)


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
sna...@googlecode.com  
View profile  
 More options Apr 16 2011, 6:14 pm
From: sna...@googlecode.com
Date: Sat, 16 Apr 2011 22:14:37 +0000
Local: Sat, Apr 16 2011 6:14 pm
Subject: Re: Issue 33 in snappy: simpler configure.ac

Comment #3 on issue 33 by fdman...@gmail.com: simpler configure.ac
http://code.google.com/p/snappy/issues/detail?id=33

Looking at snappy.h:

http://code.google.com/p/snappy/source/browse/trunk/snappy.h#42

Unlike snappy-stubs-public.h.in, the inclusion of stddef.h is not  
conditional.
Isn't this a problem?


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
sna...@googlecode.com  
View profile  
 More options Apr 16 2011, 6:49 pm
From: sna...@googlecode.com
Date: Sat, 16 Apr 2011 22:49:43 +0000
Local: Sat, Apr 16 2011 6:49 pm
Subject: Re: Issue 33 in snappy: simpler configure.ac

Comment #4 on issue 33 by se...@google.com: simpler configure.ac
http://code.google.com/p/snappy/issues/detail?id=33

stddef.h should always be available (by the C standard), as far as I know,  
so I think the HAVE_ for stddef.h is redundant. The other header isn't.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »