Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Issue 64 in snappy: make snappy compilation using msvc
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  3 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
sna...@googlecode.com  
View profile  
 More options Jul 26 2012, 8:33 am
From: sna...@googlecode.com
Date: Thu, 26 Jul 2012 12:33:32 +0000
Local: Thurs, Jul 26 2012 8:33 am
Subject: Issue 64 in snappy: make snappy compilation using msvc
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 64 by hume...@gmail.com: make snappy compilation using msvc
http://code.google.com/p/snappy/issues/detail?id=64

snappy_test.h line 47 sys/time.h is not present in MSVC, so it should be  
protected by macro and configure scripts should be updated correspondingly.

#ifdef HAVE_SYS_TIME_H
#include <sys/time.h>
#endif

there are some compilation complains under msvc under win32/64 build, I'd  
examine them and see if there should be some patch to suppress them.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
sna...@googlecode.com  
View profile  
 More options Jul 31 2012, 7:46 am
From: sna...@googlecode.com
Date: Tue, 31 Jul 2012 11:46:42 +0000
Local: Tues, Jul 31 2012 7:46 am
Subject: Re: Issue 64 in snappy: make snappy compilation using msvc
Updates:
        Status: Fixed

Comment #1 on issue 64 by se...@google.com: make snappy compilation using  
msvc
http://code.google.com/p/snappy/issues/detail?id=64

Hi,

The missing include guard is fixed in r66. As of warnings, it's  
nigh-impossible to keep a project warning free on a compiler you don't even  
have; thus I doubt we're going to make an effort ourselves to fix MSVC  
warnings, but feel free to send patches as long as they don't uglify the  
rest of the code.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
sna...@googlecode.com  
View profile  
 More options Jul 31 2012, 9:01 am
From: sna...@googlecode.com
Date: Tue, 31 Jul 2012 13:01:12 +0000
Local: Tues, Jul 31 2012 9:01 am
Subject: Re: Issue 64 in snappy: make snappy compilation using msvc

Comment #2 on issue 64 by hume...@gmail.com: make snappy compilation using  
msvc
http://code.google.com/p/snappy/issues/detail?id=64

Hi sesse:
   Yes, I agree with you that compiler warning free is not necessary, there  
are some warnings under win64 build because size_t is 64bit and long is  
32bit under win64, some cast trunctions may cause problems though, maybe  
these need some instigation, snappy is excel at speed and compression  
ratio, thanks for your effort.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »