[Bug 395007] [NEW] Infinite loop in transform.py

[Tim Godfrey]

Public bug reported:

When some links are set up in FCKEditor, they are entered in the form of
"http://plone.org/../../../../../../../../../www.abc.com"

Although clearly wrong, this causes singing & dancing to go into an
infinite loop if you try and put one of these links into a newsletter
using the "Send as Newsletter" action.

The code where it happens is at line 77 of
collective/dancing/transform.py

while '..' in parts:
dots = parts.index('..')
del parts[dots]

I propose to change it to

while '..' in parts:
dots = parts.index('..')
del parts[dots]

if dots > 0:
del parts[dots - 1]

To avoid the infinite loop state.

Would you consider including this in the next release?

** Affects: singing-dancing
Importance: Undecided
Status: New

--
Infinite loop in transform.py
https://bugs.launchpad.net/bugs/395007
You received this bug notification because you are a member of Singing &
Dancing developers, which is the registrant for Singing & Dancing.

Status in Singing & Dancing: New

Bug description:
When some links are set up in FCKEditor, they are entered in the form of "http://plone.org/../../../../../../../../../www.abc.com"

Although clearly wrong, this causes singing & dancing to go into an infinite loop if you try and put one of these links into a newsletter using the "Send as Newsletter" action.

The code where it happens is at line 77 of collective/dancing/transform.py

while '..' in parts:
dots = parts.index('..')
del parts[dots]

I propose to change it to

while '..' in parts:
dots = parts.index('..')
del parts[dots]

if dots > 0:
del parts[dots - 1]

To avoid the infinite loop state.

Would you consider including this in the next release?