Re: Singing and Dancing - new release ?

[Daniel Nouri]

Hi Vincent,

Vincent Pretre <v.pr...@zestsoftware.nl> writes:

> Hello Daniel,
>
> I'm Vincent Pretre and I work at Zest software. For one of our
> customers, we had to create a new option in Singing and Dancing channels
> that allows to send the newsletter to the members of the site.
> I created two branches of Singing and Dancing to make this option
> possible:
> https://svn.plone.org/svn/collective/collective.dancing/branches/zest-add_members_to_mailing_list
> https://svn.plone.org/svn/collective/collective.singing/branches/zest-add_members_to_mailing_list
>
> I wanted to know if I could integrate those changes into the trunk and
> possibly make a new release of the product ?

Thanks for your patch. I like. I see two problems with it though:

1) You're not testing the new functionality. Although I believe you
that it's working, it'd be nice to have tests to make sure that it'll
keep working in the future.

2) While this functionality is definitely be useful to a lot of people,
I don't think that a single checkbox "send to all users" is fine-grained
enough to go into the core. I think what we want is to be able to
select members based on group etc.

That said, I'd love to see your change as a third party package (a
Channel implementation that you can plug instead of the default). If
you need some infrastructural changes in the core to make that possible,
that's no problem!



--
http://danielnouri.org