bugfix #300720 -- "$" in collected content causes "Invalid placeholder in string:"

[Russ Ferriday]

Hi all,

https://bugs.launchpad.net/singing-dancing/+bug/300720

This is a bug that will hit you anytime an unescaped $ appears in a message. Whether in a header, footer, or collected item.

It hit me out of the blue when the client started collecting financial news items. (Iceland was the topic at the time ;)

The symptom is a traceback like this:

2008-11-21 14:45:25 ERROR Zope.SiteErrorLog http://.../preview-newsletter.html
Traceback (innermost last):
  Module ZPublisher.Publish, line 119, in publish
  Module ZPublisher.mapply, line 88, in mapply
  Module Products.PDBDebugMode.pdbzope.runcall, line 60, in pdb_runcall
  Module ZPublisher.Publish, line 42, in call_object
  Module collective.dancing.browser.preview, line 62, in __call__
  Module collective.singing.scheduler, line 99, in render_message
  Module collective.dancing.composer, line 224, in render
  Module string, line 172, in substitute
  Module string, line 169, in convert
  Module string, line 145, in _invalid

The fix is in svn, revision 76316.

Tests are running, of course, but I'd welcome someone checking it.

Best,

--r.

Russ Ferriday - Topia Systems - Open Source content management with Plone and Zope
ru...@topia.com - office: +44 2076 1777588 - mobile: +44 7789 338868 - skype: ferriday