legend gradient widget

[David Karger]

Ryan, in the feature-gap page on the wiki,
https://github.com/zepheira/exhibit3/wiki/Previous-Release-Comparison
it says that the legend-gradient-widget "does not appear to have been in
reasonable working order in Exhibit 2.2.0 and was removed". I think I
had to fix a minor bug, but if you look here:
http://people.csail.mit.edu/karger/Exhibit/Tribune/act.html
and switch to the map view, you'll see the legend gradient widget
working fine in the trunk.

[Ryan Lee]

Now that I'm on this list.

It is surprising it works given the code in that widget was terrible.
It contained a while loop with all of the code in the loop body repeated
underneath to cover the terminal case. That's a glaring sign of
incompetence to me - it may have been coincidentally made to do what it
was supposed to, but the entire file is suspect to me.

If somebody wants to write it properly, I'd be happy to reintegrate it.

[David Karger]

I agree the code isn't good; on the other hand it works. If our goal is
to migrate people from e2 to e3, it seems preferable to offer the
functionality (and encourage replacing the code) instead of forcing
people to give it up.

[Ryan Lee]

We can consider it a blocker that super bad code be rewritten as a
condition for release. Exhibit 3.0 hasn't been officially released, nor
is it being advertised as being bereft of a gradient legend as part of a
release effort. This is just the current status; you can help change it
if interests you: fill out an issue, rewrite it, etc.