Translatable: URLs - SilverStripe Core Development

The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Message from discussion Translatable: URLs
Received-SPF: pass (google.com: domain of i...@silverstripe.com designates 209.85.210.51 as permitted sender) client-ip=209.85.210.51;
From: Ingo Schommer <i...@silverstripe.com>
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: multipart/alternative; boundary=Apple-Mail-15-703849964
Subject: Re: [silverstripe-dev] Re: Translatable: URLs
Date: Thu, 9 Jun 2011 11:34:07 +1200
In-Reply-To: <B64905C7-75FC-416F-ACB7-196710D51E0C@chillu.com>
To: silverstripe-dev@googlegroups.com
References: <28ce2aa1-668e-4bd3-b05e-86c0bd38ecc9@l26g2000yqm.googlegroups.com> <16683979.2607.1307482016624.JavaMail.geo-discussion-forums@prhk39> <BANLkTikbhPW8AdM77m5hV4GaKBn3XoF...@mail.gmail.com> <B64905C7-75FC-416F-ACB7-196710D51...@chillu.com>
Message-Id: <70DC2AAD-B841-4314-82ED-9F17DCFE8...@silverstripe.com>


--Apple-Mail-15-703849964
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

Hey Chris,


On 8/06/2011, at 2:04 PM, Chris Bryer wrote:

> Thanks Ingo,
> My time has been split between iOS development and building a foxycart =
module for silverstripe lately, and i can probably get back to this in a =
month.  In the meantime, if anyone else wants to add patches that would =
be great.
>=20
> regarding the $ContentLocale flag, thats awesome theres a fix for =
this.  I didnt see anything about that in any docs like =
http://doc.silverstripe.org/sapphire/en/topics/translation.  itd be a =
nice recipe to document.
Good point, I've added this to the module docs: =
https://github.com/silverstripe/silverstripe-translatable/commit/96e28f6b9=
bd356481760dc2842c517bb4991369b
>=20
> I havent done anything with canonical urls, thats a good thought. =
regarding the locale parameter, the domain always overrides the =
parameters.=20
Override in which way? Browser language detection? Google?
I'm not aware of any built-in domain logic to Translatable in 2.4,
so that shouldn't interfere with things.

> the one time that is a problem is when you click to view the published =
or draft site inside the cms in a non-default locale.. the cms always =
sticks inside the current TLD when viewing a page which will make you =
view the default locale's record instead.  any ideas on this?  should we =
make it so that using a ?locale param overrides the TLD or switches the =
domain to the correct one for the record?  any other options?
You could influence this by customizing SiteTree->AbsoluteLink(). =
SilverStripeNavigatorItem (the class responsible for the bottom links)
already uses this method rather than RelativeLink() in 2.4.

Ingo
>=20
> -Chris

--Apple-Mail-15-703849964
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=us-ascii

<html><body style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; =
-webkit-line-break: after-white-space; "><div style=3D"word-wrap: =
break-word; -webkit-nbsp-mode: space; -webkit-line-break: =
after-white-space; ">Hey Chris,<div><br></div><div><br><div><div>On =
8/06/2011, at 2:04 PM, Chris Bryer wrote:</div><br =
class=3D"Apple-interchange-newline"><blockquote type=3D"cite">Thanks =
Ingo,<br>My time has been split between iOS development and building a =
foxycart module for silverstripe lately, and i can probably get back to =
this in a month.&nbsp; In the meantime, if anyone else wants to add =
patches that would be great.<br><br>regarding the $ContentLocale flag, =
thats awesome theres a fix for this.&nbsp; I didnt see anything about =
that in any docs like&nbsp;<a =
href=3D"http://doc.silverstripe.org/sapphire/en/topics/translation">http:/=
/doc.silverstripe.org/sapphire/en/topics/translation</a>.&nbsp; itd be a =
nice recipe to document.<br></blockquote>Good point, I've added this to =
the module docs:&nbsp;<a =
href=3D"https://github.com/silverstripe/silverstripe-translatable/commit/9=
6e28f6b9bd356481760dc2842c517bb4991369b">https://github.com/silverstripe/s=
ilverstripe-translatable/commit/96e28f6b9bd356481760dc2842c517bb4991369b</=
a></div><div><blockquote type=3D"cite"><br>I havent done anything with =
canonical urls, thats a good thought. regarding the locale parameter, =
the domain always overrides the parameters.&nbsp;</blockquote>Override =
in which way? Browser language detection? Google?</div><div>I'm not =
aware of any built-in domain logic to Translatable in 2.4,</div><div>so =
that shouldn't interfere with things.</div><div><br><blockquote =
type=3D"cite">the one time that is a problem is when you click to view =
the published or draft site inside the cms in a non-default locale.. the =
cms always sticks inside the current TLD when viewing a page which will =
make you view the default locale's record instead.&nbsp; any ideas on =
this?&nbsp; should we make it so that using a ?locale param overrides =
the TLD or switches the domain to the correct one for the record?&nbsp; =
any other options?<br></blockquote>You could influence this by =
customizing SiteTree-&gt;AbsoluteLink(). SilverStripeNavigatorItem (the =
class responsible for the bottom links)</div><div>already uses this =
method rather than RelativeLink() in =
2.4.</div><div><br></div><div>Ingo<br><blockquote =
type=3D"cite"><br>-Chris</blockquote></div></div></div></body></html>=

--Apple-Mail-15-703849964--
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
Account Options
