Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
"Remember me" fail
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  14 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Uncle Cheese  
View profile  
 More options Jul 31 2012, 12:11 pm
From: Uncle Cheese <aaroncarl...@gmail.com>
Date: Tue, 31 Jul 2012 09:11:05 -0700 (PDT)
Local: Tues, Jul 31 2012 12:11 pm
Subject: "Remember me" fail

I've been using SilverStripe for five years, and not once, on any computer,
in any environment, on any version of SS, on any website, has this ever
worked full stop. Simply put, it doesn't remember me, or, it may for a
short period of time, but not long enough to justify the label "remember
me."

It's reproducible on SS.org. I check "remember me" every time I log in.

Anyone else having this issue? I feel like it's misleading to my clients
when they click "remember me" and it just.. doesn't.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
matt clegg  
View profile  
 More options Jul 31 2012, 12:15 pm
From: matt clegg <cleggm...@gmail.com>
Date: Tue, 31 Jul 2012 17:15:25 +0100
Local: Tues, Jul 31 2012 12:15 pm
Subject: Re: [silverstripe-dev] "Remember me" fail

Yes, its never worked for me..

ss.org is also annoying when you want want to reply to a thread and you
need to log in but after logging in it take's you to a different page
rather then the thread you were looking at.

--

Matt Clegg

--Easiest way to deal with new EU cookie law when your site has google
analytics. Just create a link to  http://cookiestatement.eu/

On Tue, Jul 31, 2012 at 5:11 PM, Uncle Cheese <aaroncarl...@gmail.com>wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Gary Greenberg  
View profile  
 More options Jul 31 2012, 1:25 pm
From: Gary Greenberg <gigt...@gmail.com>
Date: Tue, 31 Jul 2012 19:25:10 +0200
Local: Tues, Jul 31 2012 1:25 pm
Subject: Re: [silverstripe-dev] "Remember me" fail
I second that

Sent from my iPhone

On 31 Jul 2012, at 18:11, Uncle Cheese <aaroncarl...@gmail.com> wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Simon J Welsh  
View profile  
 More options Jul 31 2012, 6:56 pm
From: Simon J Welsh <welsh.si...@gmail.com>
Date: Wed, 1 Aug 2012 10:56:17 +1200
Local: Tues, Jul 31 2012 6:56 pm
Subject: Re: [silverstripe-dev] "Remember me" fail
Remember me works exactly as expected. If you use the same cookie file to access a site, you will be logged in. This only works if you don't log into your account from another computer/browser, as that changes the token associated with the account.

On 1/08/2012, at 5:25 AM, Gary Greenberg <gigt...@gmail.com> wrote:

---
Simon Welsh
Admin of http://simon.geek.nz/

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Nicolaas Thiemen Francken - Sunny Side Up  
View profile  
 More options Jul 31 2012, 7:08 pm
From: Nicolaas Thiemen Francken - Sunny Side Up <m...@sunnysideup.co.nz>
Date: Wed, 1 Aug 2012 11:08:18 +1200
Local: Tues, Jul 31 2012 7:08 pm
Subject: Re: [silverstripe-dev] "Remember me" fail

What I am wondering is

(a) you are logged in automatically (i.e. you go straight to the admin
section) or that it
(b) it remembers your username and password but you still go via the login
screen.

The (a) scenario does not seem to be happening for me.

Nicolaas


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Al Twohill  
View profile  
 More options Jul 31 2012, 7:10 pm
From: Al Twohill <moebiusproj...@gmail.com>
Date: Wed, 1 Aug 2012 11:10:26 +1200
Local: Tues, Jul 31 2012 7:10 pm
Subject: Re: [silverstripe-dev] "Remember me" fail

On 1/08/2012, at 10:56 AM, Simon J Welsh <welsh.si...@gmail.com> wrote:

> Remember me works exactly as expected. If you use the same cookie file to access a site, you will be logged in. This only works if you don't log into your account from another computer/browser, as that changes the token associated with the account.

Ah, so you're saying that if you check 'Remember me' on one computer then also another, it will only remember the last? That's a bit dumb.

  smime.p7s
6K Download

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Marcus Nyeholt  
View profile  
 More options Jul 31 2012, 7:28 pm
From: Marcus Nyeholt <nyeh...@gmail.com>
Date: Wed, 1 Aug 2012 09:28:09 +1000
Local: Tues, Jul 31 2012 7:28 pm
Subject: Re: [silverstripe-dev] "Remember me" fail

> > Remember me works exactly as expected. If you use the same cookie file
> to access a site, you will be logged in. This only works if you don't log
> into your account from another computer/browser, as that changes the token
> associated with the account.

> Ah, so you're saying that if you check 'Remember me' on one computer then
> also another, it will only remember the last? That's a bit dumb.

It has a nice side effect though in that if you forget logout on a 'public'
computer but login from your home pc, the 'public' location is no longer
able to get into your account.

The problem with the Remember stuff looks to be fixed in 3.0 - for a long
long time though (and it's still the case on 2.4 branch) the autoLogin
logic will only work once, after which it will never work again. The
problem lies in

https://github.com/silverstripe/sapphire/blob/2.4/security/Member.php...

$member->RememberLoginToken = $generator->generateHash('sha1');
Cookie::set('alc_enc', $member->ID . ':' . $token, 90, null, null, false, true);

wherein the RemeberLoginToken is reset, but the cookie that is set is
for the OLD login token (looks like a copy/paste error from logIn()).

The fix is simple - change $token for $member->RememberLoginToken

$member->RememberLoginToken = $generator->generateHash('sha1');                          
Cookie::set('alc_enc', $member->ID . ':' .
$member->RememberLoginToken, 90, null, null, false, true);


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
matt clegg  
View profile  
 More options Aug 1 2012, 3:25 am
From: matt clegg <cleggm...@gmail.com>
Date: Wed, 1 Aug 2012 08:25:48 +0100
Local: Wed, Aug 1 2012 3:25 am
Subject: Re: [silverstripe-dev] "Remember me" fail

Cool, looks like its fixed in post-2.4 too

https://github.com/silverstripe/sapphire/blob/post-2.4/security/Membe...


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Paul Clarke  
View profile  
 More options Aug 1 2012, 6:34 pm
From: Paul Clarke <p...@silverstripe.com>
Date: Wed, 1 Aug 2012 15:34:34 -0700 (PDT)
Local: Wed, Aug 1 2012 6:34 pm
Subject: Re: "Remember me" fail

SS.org will be getting a makeover fairly soon with an upgrade to 3.0 so
hopefully we can address this issue at the same time.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Simon J Welsh  
View profile  
 More options Aug 23 2012, 3:27 am
From: Simon J Welsh <welsh.si...@gmail.com>
Date: Thu, 23 Aug 2012 19:27:31 +1200
Local: Thurs, Aug 23 2012 3:27 am
Subject: Re: [silverstripe-dev] "Remember me" fail
I have created a ticket on Trac for changing this system to allowing many remember me tokens. The ticket's http://open.silverstripe.org/ticket/7806 and I've copied+pasted the description:

The current remember me system stores one token per user, that is either wiped or set on login, and then updated whenever used. While this works, it does mean that as soon as you log in to your account from another browser, or switch out of private browsing, or do anything that changes the cookie store, the token stored in the user's cookies no longer matches the one in the database.

My proposed solution to this is to extract this single field out of Member and into its own DataObject (say MemberRememberToken) that has a has_many relationship with Member. When logging in with remember me enabled, a new MemberRememberToken is created, and its value is used in the cookie.

When falling back to a remember token, Member::autoLogin() will look for a matching MemberRememberToken instead of just a single field. If a matching one is found, the user is logged in and the value of the MemberRememberToken is changed, which is then stored in the cookie again.

On Member::logout(), only the current MemberRememberToken is deleted.

Facebook/Gmail-esque lists of other sessions, browser types and locations can be added on a per site basis, with an extension hooking into populateDefaults()/onBeforeWrite() (depending on if you want the information from when it's created, or every time it changes) storing the UA and IP. I don't see a need for this information to be stored in the core.

On 1/08/2012, at 7:25 PM, matt clegg <cleggm...@gmail.com> wrote:

---
Simon Welsh
Admin of http://simon.geek.nz/

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Ingo Schommer  
View profile  
 More options Aug 23 2012, 3:37 am
From: Ingo Schommer <i...@silverstripe.com>
Date: Thu, 23 Aug 2012 09:37:47 +0200
Local: Thurs, Aug 23 2012 3:37 am
Subject: Re: [silverstripe-dev] "Remember me" fail
I'm with Marcus on this one: A single token means users can log out
of other systems "remotely", e.g. after forgetting to sign off from an internet cafe.
While this can be custom-built based on the available data of course,
I think SS core should give users that level of control over their login status (and hence their data).
We could work around this by removing *all* tokens on logout by default,
with a core config option to allow staying logged-in?

Can you review the security system to see if there's anything blocking
you from making it a module? It sounds like a bit of unnecessary bloat in core.

On 23/08/2012, at 9:27 AM, Simon J Welsh <welsh.si...@gmail.com> wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Simon J Welsh  
View profile  
 More options Aug 23 2012, 4:10 am
From: Simon J Welsh <welsh.si...@gmail.com>
Date: Thu, 23 Aug 2012 20:10:19 +1200
Local: Thurs, Aug 23 2012 4:10 am
Subject: Re: [silverstripe-dev] "Remember me" fail
The main problem I have with a single token is it makes it a lot easier to sniff, as it can't change (if you allow the use of the single token across multiple machines). Having it change leads to the problem in this thread where people are expecting it to work, then it doesn't because they logged in on another machine.

There are no hooks in Member::currentUserId(), Member::autoLogin(), Member::member_from_autologinhash(), or anything else in the automated login process until after the member has been selected. There is a usable hook in Member::logout() though.
On 23/08/2012, at 7:37 PM, Ingo Schommer <i...@silverstripe.com> wrote:

---
Simon Welsh
Admin of http://simon.geek.nz/

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Ingo Schommer  
View profile  
 More options Aug 23 2012, 4:22 am
From: Ingo Schommer <i...@silverstripe.com>
Date: Thu, 23 Aug 2012 10:22:34 +0200
Local: Thurs, Aug 23 2012 4:22 am
Subject: Re: [silverstripe-dev] "Remember me" fail
In terms of security ("sniffing"), I don't really see a big difference between
having a single and multiple tokens, given they all grant you the same access,
so its enough to obtain a single one. We can tie tokens to some client uniqueness
checks like used browser and OS, but nothing a determined hacker can't circumvent.

On the missing hooks: Maybe that's a good place to start? :)

On 23/08/2012, at 10:10 AM, Simon J Welsh <welsh.si...@gmail.com> wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Che Van Lawrence  
View profile  
 More options Aug 23 2012, 4:27 pm
From: Che Van Lawrence <c...@silverstripe.com>
Date: Thu, 23 Aug 2012 13:27:40 -0700 (PDT)
Local: Thurs, Aug 23 2012 4:27 pm
Subject: Re: [silverstripe-dev] "Remember me" fail

Interestingly, I've had this happen on a few sites but not ss.org.
 Conversely, CHROME seems to need to ask me about my password every time
but ss.org seems to remember me fine.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »