little gems on trac

[Nicolaas Thiemen Francken - Sunny Side Up]

Hi Everyone

We just had a look at 

http://open.silverstripe.org/ticket/6230

aka JS part of checkbox validation not working and can be fixed with just one line replacement. 

Then we checked if it has been fixed in the master and it does not appear to be the case:

https://github.com/silverstripe/sapphire/blob/master/javascript/Validator.js (see line 153)  

I am wondering:

(a) is this "master" the correct one? 

(b) are these bugs on trac still looked at?

(c) is there a way to get a bunch of these small fixes implemented?

Note: I am not 100% sure if this is actually broken and I am also not 100% sure if this fixes it - however, we know for sure that there are a bunch of little gems on trac that would make a big difference to Sapphire 3.0

Maybe what we could do is to ask people on this mailing list to send their "sure thing super gem" quick-fixes to a special list for high priority processing or maybe we should resubmit these patches as git ones? 

Nicolaas

[Will Rossiter]

(a) is this "master" the correct one? 

Correct in what context? As a general rule, all features into master, bugfixs in post 2.4 if generally useful and well tested. In this case, I'll think it would make sense to merge to both master (3.0) and post 2.4 as long as it doesn't have any side effects.

(b) are these bugs on trac still looked at?

That bug was posted over a year ago and no response does look bad, but the core devs have been much more on top of things if submitted via Github. 

The ticket is tagged as a defect, and not a patch. When at least when I'm reviewing tickets these days, I'm looking a patches first then defects simply due to lack of time.

(c) is there a way to get a bunch of these small fixes implemented?

That's what the hackfests are for! You'll have to come along to our next one Nicolaas if you're in town :D

Submit bugfixes as pull requests against github and you'd be more likely to get a quick response. Otherwise, posting a comment on the issue to validate that it fixes the issue for you and that you've tested in other browsers, etc would mean more notifications flying around.

[Nicolaas Thiemen Francken - Sunny Side Up]

thanks for your response Will, I would definitely like to come to the next hackfest if at all possible.

Nicolaas

[Will Rossiter]

http://www.meetup.com/SilverStripe-Wellington-Meetup-Group/events/53445632/

On 2/03/2012, at 3:36 PM, Nicolaas Thiemen Francken - Sunny Side Up wrote:

thanks for your response Will, I would definitely like to come to the next hackfest if at all possible.

Nicolaas

--
You received this message because you are subscribed to the Google Groups "SilverStripe Core Development" group.
To post to this group, send email to silverst...@googlegroups.com.
To unsubscribe from this group, send email to silverstripe-d...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/silverstripe-dev?hl=en.