Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
ShowSlow
Home
+ new post
About this group
Join this group
New development in my GitHub repo
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   8 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Liz  
View profile  
 More options May 19 2012, 3:27 pm
From: Liz <ecortellcho...@gmail.com>
Date: Sat, 19 May 2012 12:27:21 -0700 (PDT)
Local: Sat, May 19 2012 3:27 pm
Subject: New development in my GitHub repo
Print | Individual message | Show original | Report this message | Find messages by this author
I'm working on the implementation of the Page Speed full beacon and
stocking of asset urls, and have pushed some initial commits to my
GitHub fork of ShowSlow.

Anyone interested may examine the work in progress on  at
https://github.com/zrusilla/showslow/commits/master .

A list of changes:

* Added new tables asset_urls, pagespeed_asset_urls and
yslow2_asset_urls
* Added two new classes, PageSpeed and PageSpeedRule, with tests
  * Moved the rule_metric_map to class PageSpeed; accessible by
PageSpeed::getRuleMetricMap
* beacon/pagespeed/index.php: add support for full beacon.
  * Changed success status code from 204 to 200 because that is what
the PageSpeed plugin expects
* Added table url_properties as an all-purpose place to store extra
info about urls
* Refactored dropQueryStrings into a separate function

As always, comments appreciated. Do bear in mind that the work is far
from done.

Cheers

Liz


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Liz  
View profile  
 More options Jun 15 2012, 5:36 am
From: Liz <ecortellcho...@gmail.com>
Date: Fri, 15 Jun 2012 02:36:42 -0700 (PDT)
Local: Fri, Jun 15 2012 5:36 am
Subject: Re: New development in my GitHub repo
Print | Individual message | Show original | Report this message | Find messages by this author

Sergey,

I'm testing my changes in preparation for a pull request; would you have
some time to review my code and comment thereupon?

Do I need to git rebase my commits or some such in order to create a more
coherent ensemble of changes? I am not fully fluent in git yet.

Cheers,

Liz


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Sergey Chernyshev  
View profile  
 More options Jun 16 2012, 12:55 am
From: Sergey Chernyshev <sergey.chernys...@gmail.com>
Date: Sat, 16 Jun 2012 00:55:04 -0400
Local: Sat, Jun 16 2012 12:55 am
Subject: Re: [showslow] New development in my GitHub repo
Print | Individual message | Show original | Report this message | Find messages by this author

Yes, I'll try to test the code when you have it - rebate might make sense
if you did lots of commits, up to you.

           Sergey

--

Thank you,

         Sergey

--
Sergey Chernyshev
http://www.sergeychernyshev.com/
http://www.meetup.com/Web-Performance-NY/
http://www.showslow.com/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Elizabeth Cholet  
View profile  
 More options Jun 18 2012, 5:06 am
From: Elizabeth Cholet <ecortellcho...@gmail.com>
Date: Mon, 18 Jun 2012 11:06:17 +0200
Local: Mon, Jun 18 2012 5:06 am
Subject: Re: [showslow] New development in my GitHub repo
Print | Individual message | Show original | Report this message | Find messages by this author

Sergey,

Before I rebase and issue a pull request, you might just want to clone my
repo directly.  Anyone else interested is welcome to do this too.

I am very interested in your feedback in order to come up with solutions
that are acceptable to both you (and other users) and $work.

Cheers,

Liz

On Sat, Jun 16, 2012 at 6:55 AM, Sergey Chernyshev <


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Elizabeth Cholet  
View profile   Translate to Translated (View Original)
 More options Jul 10 2012, 5:56 am
From: Elizabeth Cholet <ecortellcho...@gmail.com>
Date: Tue, 10 Jul 2012 11:56:49 +0200
Local: Tues, Jul 10 2012 5:56 am
Subject: Re: [showslow] New development in my GitHub repo
Print | Individual message | Show original | Report this message | Find messages by this author

Hello Sergey,

Have you finished reading or testing my modifications for the full beacon?
Any new comments or criticisms? Shall I rebase (not quite sure how but I'll
figure it out) and issue a pull request or shall I wait?

Cheers,

Liz

On Mon, Jun 18, 2012 at 11:06 AM, Elizabeth Cholet <ecortellcho...@gmail.com


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Sergey Chernyshev  
View profile   Translate to Translated (View Original)
 More options Jul 10 2012, 11:58 am
From: Sergey Chernyshev <sergey.chernys...@gmail.com>
Date: Tue, 10 Jul 2012 11:58:58 -0400
Local: Tues, Jul 10 2012 11:58 am
Subject: Re: [showslow] New development in my GitHub repo
Print | Individual message | Show original | Report this message | Find messages by this author

Sorry, didn't have time for this yet - will try to do this week.

I noticed that your dbupgrade has some unused downgrade queries that
actually fail:

Here's the patch:

index b3dbc8e..6f0ac7e 100644
--- a/dbupgrade.php
+++ b/dbupgrade.php
@@ -44,9 +44,6 @@ $versions[35]['up'][] = "CREATE TABLE `yslow2_asset_urls`
(
   ) ENGINE=INNODB";

-$versions[35]['down'][] = "ALTER TABLE `urls` DROP COLUMN
`destination_url`";
-$versions[35]['down'][] = "DROP TABLE `url_properties`";
-$versions[35]['down'][] = "DROP INDEX `unique_asset_url_hash` ON
`asset_urls`";
 $versions[35]['down'][] = "DROP TABLE `asset_urls`";
 $versions[35]['down'][] = "DROP TABLE `pagespeed_asset_urls`";
 $versions[35]['down'][] = "DROP TABLE `yslow2_asset_urls`";

try running

       php dbupgrade down
       php dbupgrade

To test if table structure changes work in both directions - will save you
lots of time on debugging production changes.

I'll take a closer look and try firing some beacons. Are there any
configuration variables that control the process?

         Sergey

On Tue, Jul 10, 2012 at 5:56 AM, Elizabeth Cholet
<ecortellcho...@gmail.com>wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Elizabeth Cholet  
View profile  
 More options Jul 10 2012, 12:10 pm
From: Elizabeth Cholet <ecortellcho...@gmail.com>
Date: Tue, 10 Jul 2012 18:10:44 +0200
Local: Tues, Jul 10 2012 12:10 pm
Subject: Re: [showslow] New development in my GitHub repo
Print | Individual message | Show original | Report this message | Find messages by this author

Hey thanks for the heads up on db[up|down]grade. I did run a number of ups
and downs in development but evidently missed that.  Will fix.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Sergey Chernyshev  
View profile  
 More options Jul 10 2012, 12:24 pm
From: Sergey Chernyshev <sergey.chernys...@gmail.com>
Date: Tue, 10 Jul 2012 12:24:24 -0400
Local: Tues, Jul 10 2012 12:24 pm
Subject: Re: [showslow] New development in my GitHub repo
Print | Individual message | Show original | Report this message | Find messages by this author

Also, can you add the documentation to /beacon/pagespeed/index.php on how
to fire a full beacon - current page shows only minimal beacon.

         Sergey

On Tue, Jul 10, 2012 at 12:10 PM, Elizabeth Cholet <ecortellcho...@gmail.com


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google