Serf 1.2.x backports

7 views
Skip to first unread message

Ivan Zhakov

unread,
May 20, 2013, 10:14:14 AM5/20/13
to serf...@googlegroups.com
I would to backport following changes to serf 1.2.x branch:
* r1803 and r1804:
Improve diagnostic of SSPI authentication failures.
Justification:
Provide user real SSPI error instead of general "Serf authentication
failure".

* r1819
SPNego authentication optimization.
Justification:
Avoid lookup through response headers on every read.

Any objections?

--
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com

Justin Erenkrantz

unread,
May 20, 2013, 10:20:51 AM5/20/13
to serf...@googlegroups.com
Sounds good to me as these don't modify the API.  -- justin
--
You received this message because you are subscribed to the Google Groups "Serf Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to serf-dev+u...@googlegroups.com.
To post to this group, send email to serf...@googlegroups.com.
Visit this group at http://groups.google.com/group/serf-dev?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Lieven Govaerts

unread,
May 20, 2013, 10:29:42 AM5/20/13
to serf...@googlegroups.com
On Mon, May 20, 2013 at 4:14 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
I would to backport following changes to serf 1.2.x branch:
* r1803 and r1804:
  Improve diagnostic of SSPI authentication failures.
Justification:
  Provide user real SSPI error instead of general "Serf authentication
failure".

* r1819
  SPNego authentication optimization.
Justification:
  Avoid lookup through response headers on every read.

Any objections?

Fine by me.

Lieven 


--
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com

Ivan Zhakov

unread,
May 21, 2013, 6:19:47 AM5/21/13
to serf...@googlegroups.com, Lieven Govaerts, Justin Erenkrantz
On Mon, May 20, 2013 at 6:29 PM, Lieven Govaerts
<lieven....@gmail.com> wrote:
>
>
> On Mon, May 20, 2013 at 4:14 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
>>
>> I would to backport following changes to serf 1.2.x branch:
>> * r1803 and r1804:
>> Improve diagnostic of SSPI authentication failures.
>> Justification:
>> Provide user real SSPI error instead of general "Serf authentication
>> failure".
>>
Merged in r1805.

>> * r1819
>> SPNego authentication optimization.
>> Justification:
>> Avoid lookup through response headers on every read.
>>
Merged in r1868.

I think it would be nice to roll 1.2.1 before next Subversion 1.8.0
Release Candidate.

Justin Erenkrantz

unread,
May 21, 2013, 10:28:41 AM5/21/13
to serf...@googlegroups.com, Lieven Govaerts
On Tuesday, May 21, 2013, Ivan Zhakov wrote:
I think it would be nice to roll 1.2.1 before next Subversion 1.8.0
Release Candidate.

+1 and if you need any help to do the release, just let me know.  -- justin
Reply all
Reply to author
Forward
0 new messages